Cleanup: remove BLI_make_file_string

This function did multiple things making it difficult to know
what was intended by the caller:

- Directory & file join.
- Expand relative '//' prefix to an optional directory.
- Expand drive letters on windows (guessing with fall-backs).
- Switch slashes to native direction.

This functionality wasn't needed as the full directory was always passed
in, so guessing the drive letter wasn't needed.

If functionality to add drive letters onto paths is needed in the future
a function that only does this can be added.

1 files changed, 1 insertions, 2 deletions

diff --git a/source/blender/windowmanager/intern/wm_files.c b/source/blender/windowmanager/intern/wm_files.c
index 38747bd706c..186edfe68d6 100644
--- a/source/blender/windowmanager/intern/wm_files.c
+++ b/source/blender/windowmanager/intern/wm_files.c
@@ -1923,8 +1923,7 @@ static void wm_autosave_location(char filepath[FILE_MAX])
   /* XXX Need to investigate how to handle default location of `/tmp/`
    * This is a relative directory on Windows, and it may be found. Example:
    * Blender installed on `D:\` drive, `D:\` drive has `D:\tmp\` Now, `BLI_exists()`
-   * will find `/tmp/` exists, but #BLI_make_file_string will create string
-   * that has it most likely on `C:\` through #BLI_windows_get_default_root_dir.
+   * will find `/tmp/` exists, but  #BLI_windows_get_default_root_dir will expand this to `C:\`.
    * If there is no `C:\tmp` autosave fails. */
   if (!BLI_exists(tempdir_base)) {
     const char *savedir = BKE_appdir_folder_id_create(BLENDER_USER_AUTOSAVE, NULL);