diff options
author | Joshua Leung <aligorith@gmail.com> | 2013-06-12 16:32:07 +0400 |
---|---|---|
committer | Joshua Leung <aligorith@gmail.com> | 2013-06-12 16:32:07 +0400 |
commit | 2aab2d97de00e39c1c623e544df2c285131e6e2d (patch) | |
tree | 11663bfdcca126261dc91b94037af6a4ef40ad53 /source/blender | |
parent | 0c91ebfeee94500ebd76d15119261c6d0f72b41f (diff) |
Bugfix [#35668] Tooltip for Euler Discontinuity Filter was misleading
The tooltip seemed to hint that this tool is able to resolve all manner of
gimble-lock situations by untangling the curves (i.e. performing some kind of
equivalent-angles resolution, keeping in mind the nearest situations nearby).
However, this tool currently only performs corrections for the most basic case
when large jump+flip discontinuity artifacts appear in euler rotation curves as
a result of rotation values getting clipped to +/- 180 degrees, which arises
when these rotation curves are the result of baking some physics sim or so.
(Also, fixed an unrelated "replace-all" typo in a comment)
Diffstat (limited to 'source/blender')
-rw-r--r-- | source/blender/blenkernel/intern/nla.c | 2 | ||||
-rw-r--r-- | source/blender/editors/space_graph/graph_edit.c | 4 |
2 files changed, 4 insertions, 2 deletions
diff --git a/source/blender/blenkernel/intern/nla.c b/source/blender/blenkernel/intern/nla.c index 7b5b6a28421..1fbc2432595 100644 --- a/source/blender/blenkernel/intern/nla.c +++ b/source/blender/blenkernel/intern/nla.c @@ -503,7 +503,7 @@ float nlastrip_get_frame(NlaStrip *strip, float cframe, short mode) /* Non clipped mapping for strip-time <-> global time - * mode = eNlaTime_ConvertModesp[] -> NLATIME_CONVERT_* + * mode = eNlaTime_ConvertModes -> NLATIME_CONVERT_* * * Public API method - perform this mapping using the given AnimData block * and perform any necessary sanity checks on the value diff --git a/source/blender/editors/space_graph/graph_edit.c b/source/blender/editors/space_graph/graph_edit.c index a51fef6c692..9d22d6fcc95 100644 --- a/source/blender/editors/space_graph/graph_edit.c +++ b/source/blender/editors/space_graph/graph_edit.c @@ -1745,7 +1745,9 @@ void GRAPH_OT_euler_filter(wmOperatorType *ot) /* identifiers */ ot->name = "Euler Discontinuity Filter"; ot->idname = "GRAPH_OT_euler_filter"; - ot->description = "Fixes the most common causes of gimbal lock in the selected Euler Rotation F-Curves"; + ot->description = "Fix large jumps and flips in the selected " + "Euler Rotation F-Curves arising from rotation " + "values being clipped when baking physics"; /* api callbacks */ ot->exec = graphkeys_euler_filter_exec; |