diff options
author | Mitchell Stokes <mogurijin@gmail.com> | 2014-05-01 05:37:47 +0400 |
---|---|---|
committer | Mitchell Stokes <mogurijin@gmail.com> | 2014-05-01 05:53:32 +0400 |
commit | 60c8c130fed60dc1fe5387b960549385188feadf (patch) | |
tree | 20a986e078ec4c79a321e3a2d12cb4a0d22b724c /source/gameengine/Ketsji/KX_ConstraintActuator.cpp | |
parent | 8d42e7b20d884937f7bf5491b0bddeec3e54b67b (diff) |
BGE cleanup: KX_GameObject::GetParent() no longer increases the object's refcount.
I'm not sure why this function ever increased the object's refcount. Any
place in the code that calls KX_GameObject::GetParent() has to turn
around and call parent->Release(). Forgetting to call Release() was a
common cause of memory leaks (in fact, KX_SteeringActuator was probably
leaking). If the refcount needs to be increased, the calling code can
handle calling AddRef().
Diffstat (limited to 'source/gameengine/Ketsji/KX_ConstraintActuator.cpp')
-rw-r--r-- | source/gameengine/Ketsji/KX_ConstraintActuator.cpp | 1 |
1 files changed, 0 insertions, 1 deletions
diff --git a/source/gameengine/Ketsji/KX_ConstraintActuator.cpp b/source/gameengine/Ketsji/KX_ConstraintActuator.cpp index 0c5e21322df..e5662b54b83 100644 --- a/source/gameengine/Ketsji/KX_ConstraintActuator.cpp +++ b/source/gameengine/Ketsji/KX_ConstraintActuator.cpp @@ -342,7 +342,6 @@ bool KX_ConstraintActuator::Update(double curtime, bool frame) KX_GameObject *parent = obj->GetParent(); if (parent) { spc = parent->GetPhysicsController(); - parent->Release(); } } KX_RayCast::Callback<KX_ConstraintActuator> callback(this,dynamic_cast<PHY_IPhysicsController*>(spc)); |