diff options
| author | Mitchell Stokes <mogurijin@gmail.com> | 2014-05-01 05:37:47 +0400 |
|---|---|---|
| committer | Mitchell Stokes <mogurijin@gmail.com> | 2014-05-01 05:53:32 +0400 |
| commit | 60c8c130fed60dc1fe5387b960549385188feadf (patch) | |
| tree | 20a986e078ec4c79a321e3a2d12cb4a0d22b724c /source/gameengine/Ketsji/KX_Scene.cpp | |
| parent | 8d42e7b20d884937f7bf5491b0bddeec3e54b67b (diff) | |
BGE cleanup: KX_GameObject::GetParent() no longer increases the object's refcount.
I'm not sure why this function ever increased the object's refcount. Any
place in the code that calls KX_GameObject::GetParent() has to turn
around and call parent->Release(). Forgetting to call Release() was a
common cause of memory leaks (in fact, KX_SteeringActuator was probably
leaking). If the refcount needs to be increased, the calling code can
handle calling AddRef().
Diffstat (limited to 'source/gameengine/Ketsji/KX_Scene.cpp')
| -rw-r--r-- | source/gameengine/Ketsji/KX_Scene.cpp | 5 |
1 files changed, 0 insertions, 5 deletions
diff --git a/source/gameengine/Ketsji/KX_Scene.cpp b/source/gameengine/Ketsji/KX_Scene.cpp index 65f5ff15501..b2dca147f67 100644 --- a/source/gameengine/Ketsji/KX_Scene.cpp +++ b/source/gameengine/Ketsji/KX_Scene.cpp @@ -575,9 +575,6 @@ KX_GameObject* KX_Scene::AddNodeReplicaObject(class SG_IObject* node, class CVal newctrl->SetNewClientInfo(newobj->getClientInfo()); newobj->SetPhysicsController(newctrl, newobj->IsDynamic()); newctrl->PostProcessReplica(motionstate, parentctrl); - - if (parent) - parent->Release(); } return newobj; @@ -758,8 +755,6 @@ void KX_Scene::DupliGroupRecurse(CValue* obj, int level) KX_GameObject *parent = gameobj->GetParent(); if (parent != NULL) { - parent->Release(); // GetParent() increased the refcount - // this object is not a top parent. Either it is the child of another // object in the group and it will be added automatically when the parent // is added. Or it is the child of an object outside the group and the group |