UI: Clarify descriptions in properties popover

Updates the descriptions and labels for outliner sync in the properties
editor popover to be more clear.

Differential Revision: https://developer.blender.org/D10010

3 files changed, 17 insertions, 7 deletions

diff --git a/source/blender/editors/space_buttons/buttons_context.c b/source/blender/editors/space_buttons/buttons_context.c
index 5f347451c4a..3efaff72637 100644
--- a/source/blender/editors/space_buttons/buttons_context.c
+++ b/source/blender/editors/space_buttons/buttons_context.c
@@ -756,7 +756,7 @@ bool ED_buttons_should_sync_with_outliner(const bContext *C,
   ScrArea *active_area = CTX_wm_area(C);
   const bool auto_sync = ED_area_has_shared_border(active_area, area) &&
                          sbuts->outliner_sync == PROPERTIES_SYNC_AUTO;
-  return auto_sync || sbuts->outliner_sync == PROPERTIES_SYNC_ON;
+  return auto_sync || sbuts->outliner_sync == PROPERTIES_SYNC_ALWAYS;
 }
 
 void ED_buttons_set_context(const bContext *C,
diff --git a/source/blender/makesdna/DNA_space_types.h b/source/blender/makesdna/DNA_space_types.h
index 4d705f3aa34..dc1775b09c6 100644
--- a/source/blender/makesdna/DNA_space_types.h
+++ b/source/blender/makesdna/DNA_space_types.h
@@ -241,8 +241,8 @@ typedef enum eSpaceButtons_Flag {
 /* SpaceProperties.outliner_sync */
 typedef enum eSpaceButtons_OutlinerSync {
   PROPERTIES_SYNC_AUTO = 0,
-  PROPERTIES_SYNC_OFF = 1,
-  PROPERTIES_SYNC_ON = 2,
+  PROPERTIES_SYNC_NEVER = 1,
+  PROPERTIES_SYNC_ALWAYS = 2,
 } eSpaceButtons_OutlinerSync;
 
 /** \} */
diff --git a/source/blender/makesrna/intern/rna_space.c b/source/blender/makesrna/intern/rna_space.c
index c56ddeb9053..9578c5d8228 100644
--- a/source/blender/makesrna/intern/rna_space.c
+++ b/source/blender/makesrna/intern/rna_space.c
@@ -4805,13 +4805,21 @@ static void rna_def_space_properties(BlenderRNA *brna)
   PropertyRNA *prop;
 
   static const EnumPropertyItem tab_sync_items[] = {
-      {PROPERTIES_SYNC_ON, "ON", 0, "On", "Always sync from outliner editors to this editor"},
-      {PROPERTIES_SYNC_OFF, "OFF", 0, "Off", "Never sync from outliner editors to this editor"},
+      {PROPERTIES_SYNC_ALWAYS,
+       "ALWAYS",
+       0,
+       "Always",
+       "Always change tabs when clicking an icon in an outliner"},
+      {PROPERTIES_SYNC_NEVER,
+       "NEVER",
+       0,
+       "Never",
+       "Never change tabs when clicking an icon in an outliner"},
       {PROPERTIES_SYNC_AUTO,
        "AUTO",
        0,
        "Auto",
-       "Sync when this editor shares an edge with an outliner editor"},
+       "Change tabs only when this editor shares a border the outliner"},
       {0, NULL, 0, NULL, NULL},
   };
 
@@ -4870,7 +4878,9 @@ static void rna_def_space_properties(BlenderRNA *brna)
   prop = RNA_def_property(srna, "outliner_sync", PROP_ENUM, PROP_NONE);
   RNA_def_property_enum_sdna(prop, NULL, "outliner_sync");
   RNA_def_property_enum_items(prop, tab_sync_items);
-  RNA_def_property_ui_text(prop, "Outliner Sync", "Sync tabs from outliner datablock selection");
+  RNA_def_property_ui_text(prop,
+                           "Outliner Sync",
+                           "Change to the corresponding tab when outliner data icons are clicked");
   RNA_def_property_update(prop, NC_SPACE | ND_SPACE_PROPERTIES, NULL);
 }