Cleanup: Make automated code check happy.

- Assert that one of the thwo branches in
  `id_override_library_create_hierarchy` are always processed.
- Init success value regardless.

1 files changed, 4 insertions, 1 deletions

diff --git a/source/blender/editors/space_outliner/outliner_tools.cc b/source/blender/editors/space_outliner/outliner_tools.cc
index e1aa695a262..80ee3bbb6a1 100644
--- a/source/blender/editors/space_outliner/outliner_tools.cc
+++ b/source/blender/editors/space_outliner/outliner_tools.cc
@@ -1025,7 +1025,7 @@ static void id_override_library_create_hierarchy(
     }
     FOREACH_MAIN_ID_END;
 
-    bool success;
+    bool success = false;
     if (do_hierarchy) {
       ID *id_root_override = nullptr;
       success = BKE_lib_override_library_create(&bmain,
@@ -1073,6 +1073,9 @@ static void id_override_library_create_hierarchy(
       BKE_main_id_newptr_and_tag_clear(&bmain);
       BKE_main_id_tag_all(&bmain, LIB_TAG_DOIT, false);
     }
+    else {
+      BLI_assert_unreachable();
+    }
 
     /* Remove the instance empty from this scene, the items now have an overridden collection
      * instead. */