diff options
author | Sergey Sharybin <sergey.vfx@gmail.com> | 2017-11-29 19:55:28 +0300 |
---|---|---|
committer | Sergey Sharybin <sergey.vfx@gmail.com> | 2017-11-29 19:55:28 +0300 |
commit | 5b5939c6e6494583a0c99f6dccb8ca8c617d204b (patch) | |
tree | 3e899f8d47175aeeb13e9e8455a959031a50762a /source | |
parent | 1136dee23273830ce16a624526b45d145a7e4020 (diff) |
Depsgraph: Cleanup, use explicit NULL pointer checks
Diffstat (limited to 'source')
-rw-r--r-- | source/blender/depsgraph/intern/builder/deg_builder_nodes_scene.cc | 40 | ||||
-rw-r--r-- | source/blender/depsgraph/intern/builder/deg_builder_relations_scene.cc | 34 |
2 files changed, 24 insertions, 50 deletions
diff --git a/source/blender/depsgraph/intern/builder/deg_builder_nodes_scene.cc b/source/blender/depsgraph/intern/builder/deg_builder_nodes_scene.cc index a7b2906cefd..3c523b1a23c 100644 --- a/source/blender/depsgraph/intern/builder/deg_builder_nodes_scene.cc +++ b/source/blender/depsgraph/intern/builder/deg_builder_nodes_scene.cc @@ -65,71 +65,55 @@ namespace DEG { void DepsgraphNodeBuilder::build_scene(Scene *scene) { - /* scene ID block */ + /* Scene ID block. */ add_id_node(&scene->id); - /* timesource */ add_time_source(); - /* build subgraph for set, and link this in... */ // XXX: depending on how this goes, that scene itself could probably store its // own little partial depsgraph? - if (scene->set) { + if (scene->set != NULL) { build_scene(scene->set); } - /* Setup currently building context. */ scene_ = scene; - /* scene objects */ LINKLIST_FOREACH (Base *, base, &scene->base) { Object *object = base->object; build_object(base, object); } - - /* rigidbody */ - if (scene->rigidbody_world) { + /* Rigidbody. */ + if (scene->rigidbody_world != NULL) { build_rigidbody(scene); } - - /* scene's animation and drivers */ - if (scene->adt) { + /* Scene's animation and drivers. */ + if (scene->adt != NULL) { build_animdata(&scene->id); } - - /* world */ - if (scene->world) { + /* World. */ + if (scene->world != NULL) { build_world(scene->world); } - - /* compo nodes */ - if (scene->nodetree) { + /* Compositor nodes. */ + if (scene->nodetree != NULL) { build_compositor(scene); } - - /* sequencer */ - // XXX... - - /* grease pencil */ - if (scene->gpd) { + /* Grease pencil. */ + if (scene->gpd != NULL) { build_gpencil(scene->gpd); } - /* Cache file. */ LINKLIST_FOREACH (CacheFile *, cachefile, &bmain_->cachefiles) { build_cachefile(cachefile); } - /* Masks. */ LINKLIST_FOREACH (Mask *, mask, &bmain_->mask) { build_mask(mask); } - /* Movie clips. */ LINKLIST_FOREACH (MovieClip *, clip, &bmain_->movieclip) { build_movieclip(clip); } - /* Parameters evaluation for scene relations mainly. */ add_operation_node(&scene->id, DEG_NODE_TYPE_PARAMETERS, diff --git a/source/blender/depsgraph/intern/builder/deg_builder_relations_scene.cc b/source/blender/depsgraph/intern/builder/deg_builder_relations_scene.cc index bface46c201..feb32442cb7 100644 --- a/source/blender/depsgraph/intern/builder/deg_builder_relations_scene.cc +++ b/source/blender/depsgraph/intern/builder/deg_builder_relations_scene.cc @@ -69,54 +69,44 @@ namespace DEG { void DepsgraphRelationBuilder::build_scene(Scene *scene) { - if (scene->set) { + if (scene->set != NULL) { build_scene(scene->set); } - /* Setup currently building context. */ scene_ = scene; - - /* scene objects */ + /* Scene objects. */ LINKLIST_FOREACH (Base *, base, &scene->base) { Object *object = base->object; build_object(object); } - - /* rigidbody */ - if (scene->rigidbody_world) { + /* Rigidbody. */ + if (scene->rigidbody_world != NULL) { build_rigidbody(scene); } - - /* scene's animation and drivers */ - if (scene->adt) { + /* Scene's animation and drivers. */ + if (scene->adt != NULL) { build_animdata(&scene->id); } - - /* world */ - if (scene->world) { + /* World. */ + if (scene->world != NULL) { build_world(scene->world); } - - /* compo nodes */ - if (scene->nodetree) { + /* Compositor nodes. */ + if (scene->nodetree != NULL) { build_compositor(scene); } - - /* grease pencil */ - if (scene->gpd) { + /* Grease pencil. */ + if (scene->gpd != NULL) { build_gpencil(scene->gpd); } - /* Masks. */ LINKLIST_FOREACH (Mask *, mask, &bmain_->mask) { build_mask(mask); } - /* Movie clips. */ LINKLIST_FOREACH (MovieClip *, clip, &bmain_->movieclip) { build_movieclip(clip); } - for (Depsgraph::OperationNodes::const_iterator it_op = graph_->operations.begin(); it_op != graph_->operations.end(); ++it_op) |