diff options
author | Campbell Barton <ideasman42@gmail.com> | 2015-02-01 11:18:39 +0300 |
---|---|---|
committer | Campbell Barton <ideasman42@gmail.com> | 2015-02-01 11:18:39 +0300 |
commit | 01ec66423cab11a02fa0a1392b4d713c833680ee (patch) | |
tree | 6fc558d35c3bf8dd950facd31eabef3659e15022 /source | |
parent | 26f9a9245387ced59214840f99ccf4aabc0c39f4 (diff) |
BMesh: remove redundant connect-nonplanar loop
Diffstat (limited to 'source')
-rw-r--r-- | source/blender/bmesh/operators/bmo_connect_nonplanar.c | 21 |
1 files changed, 6 insertions, 15 deletions
diff --git a/source/blender/bmesh/operators/bmo_connect_nonplanar.c b/source/blender/bmesh/operators/bmo_connect_nonplanar.c index 6859ce2060c..c9ce2c5f6b8 100644 --- a/source/blender/bmesh/operators/bmo_connect_nonplanar.c +++ b/source/blender/bmesh/operators/bmo_connect_nonplanar.c @@ -153,23 +153,11 @@ void bmo_connect_verts_nonplanar_exec(BMesh *bm, BMOperator *op) { BMOIter siter; BMFace *f; - int totface = 0, totloop = 0; + bool changed = false; BLI_LINKSTACK_DECLARE(fstack, BMFace *); const float angle_limit = BMO_slot_float_get(op->slots_in, "angle_limit"); - - BMO_ITER (f, &siter, op->slots_in, "faces", BM_FACE) { - if (f->len > 3) { - totface += 1; - totloop += f->len; - } - } - - if (totface == 0) { - return; - } - BLI_LINKSTACK_INIT(fstack); BMO_ITER (f, &siter, op->slots_in, "faces", BM_FACE) { @@ -188,11 +176,14 @@ void bmo_connect_verts_nonplanar_exec(BMesh *bm, BMOperator *op) BLI_LINKSTACK_PUSH(fstack, f_pair[j]); } } + changed = true; } } BLI_LINKSTACK_FREE(fstack); - BMO_slot_buffer_from_enabled_flag(bm, op, op->slots_out, "edges.out", BM_EDGE, EDGE_OUT); - BMO_slot_buffer_from_enabled_flag(bm, op, op->slots_out, "faces.out", BM_FACE, FACE_OUT); + if (changed) { + BMO_slot_buffer_from_enabled_flag(bm, op, op->slots_out, "edges.out", BM_EDGE, EDGE_OUT); + BMO_slot_buffer_from_enabled_flag(bm, op, op->slots_out, "faces.out", BM_FACE, FACE_OUT); + } } |