diff options
author | Aaron Carlisle <carlisle.b3d@gmail.com> | 2022-03-30 15:00:00 +0300 |
---|---|---|
committer | Aaron Carlisle <carlisle.b3d@gmail.com> | 2022-03-30 15:00:23 +0300 |
commit | ecafa4c27c67bda074217adba81a0d211c764370 (patch) | |
tree | c98363374165c18b84ef363a87033d1e28e47643 /source | |
parent | 3656e66ac24d1c3b43b70f3782ea8ba2056bad52 (diff) |
Compositor: Fix Missing output UI for Normal node
There were multiple issues at hand here:
- The default value has been changed to `{0, 0, 1}` see: rB25f1783673de636a6f0ca4457df8c05bc685981a
- The output needs the subtype set `PROP_DIRECTION`
- The noder properties were missing in `node_composit_set_butfunc`
Fixes T96860
Diffstat (limited to 'source')
-rw-r--r-- | source/blender/editors/space_node/drawnode.cc | 3 | ||||
-rw-r--r-- | source/blender/nodes/composite/nodes/node_composite_normal.cc | 8 |
2 files changed, 9 insertions, 2 deletions
diff --git a/source/blender/editors/space_node/drawnode.cc b/source/blender/editors/space_node/drawnode.cc index d4b7640cfe3..c6839099827 100644 --- a/source/blender/editors/space_node/drawnode.cc +++ b/source/blender/editors/space_node/drawnode.cc @@ -791,6 +791,9 @@ static void node_composit_set_butfunc(bNodeType *ntype) ntype->draw_buttons = node_composit_buts_image; ntype->draw_buttons_ex = node_composit_buts_image_ex; break; + case CMP_NODE_NORMAL: + ntype->draw_buttons = node_buts_normal; + break; case CMP_NODE_CURVE_RGB: ntype->draw_buttons = node_buts_curvecol; break; diff --git a/source/blender/nodes/composite/nodes/node_composite_normal.cc b/source/blender/nodes/composite/nodes/node_composite_normal.cc index c04e4bed660..b4dd0bbacd0 100644 --- a/source/blender/nodes/composite/nodes/node_composite_normal.cc +++ b/source/blender/nodes/composite/nodes/node_composite_normal.cc @@ -14,11 +14,15 @@ namespace blender::nodes::node_composite_normal_cc { static void cmp_node_normal_declare(NodeDeclarationBuilder &b) { b.add_input<decl::Vector>(N_("Normal")) - .default_value({1.0f, 1.0f, 1.0f}) + .default_value({0.0f, 0.0f, 1.0f}) + .min(-1.0f) + .max(1.0f) + .subtype(PROP_DIRECTION); + b.add_output<decl::Vector>(N_("Normal")) + .default_value({0.0f, 0.0f, 1.0f}) .min(-1.0f) .max(1.0f) .subtype(PROP_DIRECTION); - b.add_output<decl::Vector>(N_("Normal")); b.add_output<decl::Float>(N_("Dot")); } |