diff options
author | Jacques Lucke <jacques@blender.org> | 2020-07-03 16:27:02 +0300 |
---|---|---|
committer | Jacques Lucke <jacques@blender.org> | 2020-07-03 16:27:02 +0300 |
commit | 1e255ce0319d6cf45b6951a2a87590d2ca236e9f (patch) | |
tree | b5f47ea26bcad96e1205b2e9c59bd422e364a148 /tests/gtests/blenlib | |
parent | 2633683b52054d15006aea1314f62f73a8505b42 (diff) |
Fix T72214: Fluids: noise does not work with negative frame numbers
The issue is duplicated code. There are two functions that zero-fill
the frame number. They worked the same for positive frames numbers, but
behaved differently for negative ones.
On frame `-100`, `BLI_path_frame` outputs `-0100` and
`fluid_cache_get_framenr_formatted_$ID$` outputted `-100`.
I changed the behavior of the latter, because we depend on the behavior
of the former for much longer already.
Reviewers: sebbas
Differential Revision: https://developer.blender.org/D8107
Diffstat (limited to 'tests/gtests/blenlib')
-rw-r--r-- | tests/gtests/blenlib/BLI_path_util_test.cc | 14 |
1 files changed, 14 insertions, 0 deletions
diff --git a/tests/gtests/blenlib/BLI_path_util_test.cc b/tests/gtests/blenlib/BLI_path_util_test.cc index 480d48d6080..734bbc2b31e 100644 --- a/tests/gtests/blenlib/BLI_path_util_test.cc +++ b/tests/gtests/blenlib/BLI_path_util_test.cc @@ -408,6 +408,20 @@ TEST(path_util, Frame) EXPECT_FALSE(ret); EXPECT_STREQ("test_middle", path); } + + /* negative frame numbers */ + { + char path[FILE_MAX] = "test_####"; + ret = BLI_path_frame(path, -1, 4); + EXPECT_TRUE(ret); + EXPECT_STREQ("test_-0001", path); + } + { + char path[FILE_MAX] = "test_####"; + ret = BLI_path_frame(path, -100, 4); + EXPECT_TRUE(ret); + EXPECT_STREQ("test_-0100", path); + } } /* BLI_split_dirfile */ |