diff options
-rw-r--r-- | source/blender/blenlib/BLI_gsqueue.h | 3 | ||||
-rw-r--r-- | source/blender/blenlib/intern/BLI_linklist.c | 15 | ||||
-rw-r--r-- | source/blender/blenlib/intern/gsqueue.c | 6 | ||||
-rw-r--r-- | source/blender/blenlib/intern/scanfill.c | 3 |
4 files changed, 14 insertions, 13 deletions
diff --git a/source/blender/blenlib/BLI_gsqueue.h b/source/blender/blenlib/BLI_gsqueue.h index d17897df665..4600d6f6325 100644 --- a/source/blender/blenlib/BLI_gsqueue.h +++ b/source/blender/blenlib/BLI_gsqueue.h @@ -30,8 +30,6 @@ /** \file BLI_gsqueue.h * \ingroup bli - * \brief A generic structure queue (a queue for fixed length - * (generally small) structures. */ typedef struct _GSQueue GSQueue; @@ -46,4 +44,3 @@ void BLI_gsqueue_pushback(GSQueue *gq, const void *item); void BLI_gsqueue_free(GSQueue *gq); #endif /* __BLI_GSQUEUE_H__ */ - diff --git a/source/blender/blenlib/intern/BLI_linklist.c b/source/blender/blenlib/intern/BLI_linklist.c index 66fcfd21fbb..a0b61e7945c 100644 --- a/source/blender/blenlib/intern/BLI_linklist.c +++ b/source/blender/blenlib/intern/BLI_linklist.c @@ -38,17 +38,12 @@ int BLI_linklist_length(LinkNode *list) { - if (0) { - return list ? (1 + BLI_linklist_length(list->next)) : 0; - } - else { - int len; + int len; - for (len = 0; list; list = list->next) - len++; - - return len; - } + for (len = 0; list; list = list->next) + len++; + + return len; } int BLI_linklist_index(LinkNode *list, void *ptr) diff --git a/source/blender/blenlib/intern/gsqueue.c b/source/blender/blenlib/intern/gsqueue.c index 67703c3f033..94d18ce3c77 100644 --- a/source/blender/blenlib/intern/gsqueue.c +++ b/source/blender/blenlib/intern/gsqueue.c @@ -27,6 +27,12 @@ /** \file blender/blenlib/intern/gsqueue.c * \ingroup bli + * + * \brief A generic structure queue + * (a queue for fixed length generally small) structures. + * + * \note Only use this if you need (first-in-first-out), + * otherwise #BLI_stack is more efficient (first-in-last-out). */ #include <string.h> diff --git a/source/blender/blenlib/intern/scanfill.c b/source/blender/blenlib/intern/scanfill.c index 05e4984d9a3..3d3dfeef302 100644 --- a/source/blender/blenlib/intern/scanfill.c +++ b/source/blender/blenlib/intern/scanfill.c @@ -865,6 +865,9 @@ unsigned int BLI_scanfill_calc_ex(ScanFillContext *sf_ctx, const int flag, const /* Newell's Method */ /* Similar code used elsewhere, but this checks for double ups * which historically this function supports so better not change */ + + /* warning: this only gives stable direction with single polygons, + * ideally we'd calcualte connectivity and calculate each polys normal, see T41047 */ const float *v_prev; zero_v3(n); |