1 files changed, 39 insertions, 6 deletions

diff --git a/source/blender/nodes/geometry/nodes/node_geo_curve_primitive_star.cc b/source/blender/nodes/geometry/nodes/node_geo_curve_primitive_star.cc
index b5bafce17c6..9004681c246 100644
--- a/source/blender/nodes/geometry/nodes/node_geo_curve_primitive_star.cc
+++ b/source/blender/nodes/geometry/nodes/node_geo_curve_primitive_star.cc
@@ -22,17 +22,29 @@ namespace blender::nodes {
 
 static void geo_node_curve_primitive_star_declare(NodeDeclarationBuilder &b)
 {
-  b.add_input<decl::Int>(N_("Points")).default_value(8).min(3).max(256).subtype(PROP_UNSIGNED);
+  b.add_input<decl::Int>(N_("Points"))
+      .default_value(8)
+      .min(3)
+      .max(256)
+      .subtype(PROP_UNSIGNED)
+      .description(N_("Number of points on each of the circles"));
   b.add_input<decl::Float>(N_("Inner Radius"))
       .default_value(1.0f)
       .min(0.0f)
-      .subtype(PROP_DISTANCE);
+      .subtype(PROP_DISTANCE)
+      .description(N_("Radius of the inner circle; can be larger than outer radius"));
   b.add_input<decl::Float>(N_("Outer Radius"))
       .default_value(2.0f)
       .min(0.0f)
-      .subtype(PROP_DISTANCE);
-  b.add_input<decl::Float>(N_("Twist")).subtype(PROP_ANGLE);
+      .subtype(PROP_DISTANCE)
+      .description(N_("Radius of the outer circle; can be smaller than inner radius"));
+  b.add_input<decl::Float>(N_("Twist"))
+      .subtype(PROP_ANGLE)
+      .description(N_("The counterclockwise rotation of the inner set of points"));
   b.add_output<decl::Geometry>(N_("Curve"));
+  b.add_output<decl::Bool>(N_("Outer Points"))
+      .field_source()
+      .description(N_("An attribute field with a selection of the outer points"));
 }
 
 static std::unique_ptr<CurveEval> create_star_curve(const float inner_radius,
@@ -57,9 +69,22 @@ static std::unique_ptr<CurveEval> create_star_curve(const float inner_radius,
   spline->attributes.reallocate(spline->size());
   curve->add_spline(std::move(spline));
   curve->attributes.reallocate(curve->splines().size());
+
   return curve;
 }
 
+static void create_selection_output(CurveComponent &component,
+                                    StrongAnonymousAttributeID &r_attribute)
+{
+  OutputAttribute_Typed<bool> attribute = component.attribute_try_get_for_output_only<bool>(
+      r_attribute.get(), ATTR_DOMAIN_POINT);
+  MutableSpan<bool> selection = attribute.as_span();
+  for (int i : selection.index_range()) {
+    selection[i] = i % 2 == 0;
+  }
+  attribute.save();
+}
+
 static void geo_node_curve_primitive_star_exec(GeoNodeExecParams params)
 {
   std::unique_ptr<CurveEval> curve = create_star_curve(
@@ -67,9 +92,17 @@ static void geo_node_curve_primitive_star_exec(GeoNodeExecParams params)
       std::max(params.extract_input<float>("Outer Radius"), 0.0f),
       params.extract_input<float>("Twist"),
       std::max(params.extract_input<int>("Points"), 3));
-  params.set_output("Curve", GeometrySet::create_with_curve(curve.release()));
-}
+  GeometrySet output = GeometrySet::create_with_curve(curve.release());
 
+  if (params.output_is_required("Outer Points")) {
+    StrongAnonymousAttributeID attribute_output("Outer Points");
+    create_selection_output(output.get_component_for_write<CurveComponent>(), attribute_output);
+    params.set_output("Outer Points",
+                      AnonymousAttributeFieldInput::Create<bool>(
+                          std::move(attribute_output), params.attribute_producer_name()));
+  }
+  params.set_output("Curve", std::move(output));
+}
 }  // namespace blender::nodes
 
 void register_node_type_geo_curve_primitive_star()