Welcome to mirror list, hosted at ThFree Co, Russian Federation.

git.blender.org/blender.git - Unnamed repository; edit this file 'description' to name the repository.
summaryrefslogtreecommitdiff
AgeCommit message (Collapse)Author
2020-10-21Cleanup: Clang-tidy readability-named-parameterAnkit Meel
No functional change.
2020-10-21Cleanup: Clang-tidy readability-redundant-string-initAnkit Meel
No functional change.
2020-10-21Clang-tidy: disable new warnings.Ankit Meel
Until it is decided whether to work on, or ignore these warning, disable them. See T78535 Reviewed By: sergey Differential Revision: https://developer.blender.org/D9281
2020-09-04Cleanup: Clang-Tidy readability-inconsistent-declaration-parameter-name fixSebastian Parborg
No functional changes
2020-09-04Cleanup: Clang-Tidy bugprone-copy-constructor-init fixSybren A. Stüvel
No expected functional changes.
2020-09-04Cleanup: Clang-Tidy, describe current status of rulesSybren A. Stüvel
No functional changes.
2020-09-04Cleanup: Clang-Tidy bugprone-incorrect-roundings fixesSybren A. Stüvel
Should cause no noticeable difference.
2020-09-04Cleanup: Enable Clang-Tidy readability-qualified-auto ruleSybren A. Stüvel
No functional changes. No changes except enabling the rule, even.
2020-09-04Cleanup: Clang-Tidy readability-redundant-declaration fixSybren A. Stüvel
No functional changes.
2020-09-04Cleanup: Clang-Tidy readability-static-accessed-through-instance fixesSybren A. Stüvel
No functional changes.
2020-09-04Cleanup: Clang-Tidy readability-const-return-type fixesSybren A. Stüvel
No functional changes.
2020-09-04Cleanup: Clang-Tidy readability-redundant-preprocessor fixesSybren A. Stüvel
Remove redundantly nested `#if` and `#ifdef` statements. One nested `#if 0` block was left untouched, as it's in particle code that's no longer maintained. Furthermore, that block also has some explanation as to the differences between the enabled & disabled parts. One nested `#if 0` construct was completely removed, leaving only the actually used bit of code. There was no explanation as to the usefulness of the disabled code, and it hasn't been touched in years. No functional changes.
2020-08-07Cleanup: enable Clang-Tidy `bugprone-parent-virtual-call` ruleSybren A. Stüvel
I added a single `NOLINT` exception with explanation. No functional changes.
2020-08-07Cleanup: enabled Clang-Tidy `bugprone-suspicious-missing-comma` ruleSybren A. Stüvel
No functional changes because no code changed.
2020-08-07Cleanup: enabled Clang-Tidy `bugprone-not-null-terminated-result` ruleSybren A. Stüvel
No functional changes because no code changed.
2020-08-07Cleanup: fixed Clang-Tidy `bugprone-suspicious-string-compare` warningsSybren A. Stüvel
No functional changes.
2020-08-07Cleanup: enabled Clang-Tidy rule `bugprone-infinite-loop`Sybren A. Stüvel
Enabling it and doing a full rebuild didn't cause any warnings, so nothing else to do here. No functional changes.
2020-08-07Cleanup: enable and silence Clang-Tidy readability-function-sizeSybren A. Stüvel
Enable Clang-Tidy's `readability-function-size` rule and add a few `NOLINT` markers to explicitly silence warnings for three functions. These functions are huge and would IMO benefit from splitting up, but are hard to without intimate knowledge of the code. At least by enabling the rule, we can start tweaking the values and refactoring other functions that bubble up as being too long/complex. No functional changes.
2020-08-07Cleanup: Clang-Tidy else-after-return fixesSybren A. Stüvel
This addresses warnings from Clang-Tidy's `readability-else-after-return` rule. This should be the final commit of the series of commits that addresses this particular rule. No functional changes.
2020-08-07Clang-Tidy: Address readability-redundant-string-initSergey Sharybin
2020-07-15Clang-Tidy: ignore some newer checksJacques Lucke
Those checks have been added to clang tidy within the last year. They fail when I use a clang tidy version I built from source. Reviewers: sergey Differential Revision: https://developer.blender.org/D8302
2020-07-13Clang Tidy: enable readability-non-const-parameter warningJacques Lucke
Clang Tidy reported a couple of false positives. I disabled those `NOLINTNEXTLINE`. Differential Revision: https://developer.blender.org/D8199
2020-07-03Clang-tidy: Enable braces-around-statements warningSebastian Parborg
2020-07-03Clang-Tidy: Enable bugprone-misplaced-widening-castSergey Sharybin
2020-07-03Clang-Tidy: enable readability-named-parameterJacques Lucke
2020-07-03Clang-Tidy: enable bugprone-too-small-loop-variableJacques Lucke
2020-07-03Clang-Tidy: enable bugprone-assert-side-effectJacques Lucke
Looks like we have no assertions with side effects.
2020-07-03Clang-Tidy: enable bugprone-argument-commentJacques Lucke
It was called `inverted` in the header.
2020-07-03Clang-Tidy: Fix readability-delete-null-pointer warningsSergey Sharybin
Also enable it in the configuration.
2020-07-03Clang-Tidy: Enable readability-redundant-string-cstrJacques Lucke
2020-07-03Clang-Tidy: Enable readability-redundant-control-flowHans Goudey
2020-07-03Clang-tidy: enable readability-container-size-empty warningJacques Lucke
Reviewers: sergey Differential Revision: https://developer.blender.org/D8197
2020-07-03Clang-Tidy: Enable redundant static qualifier warningSergey Sharybin
This change enables readability-static-definition-in-anonymous-namespace warning in .clang-tidy configuration.
2020-07-03Clang-tidy: Enable bugprone-lambda-function-name warningSergey Sharybin
2020-07-03Clang-Tidy: Silence warning affecting newer codeSergey Sharybin
For now Clang-Tidy should be passable with the codebase as is. This warning will be addressed as quality day task.
2020-07-03Initial support of clang-tidy toolchainSergey Sharybin
Clang Tidy is a Clang based "linter" tool which goal is to help fixing typical programming errors. It is run as a separate compile step of every file, which slows compilation down but allows to fully analyze the file the same way as compiler does and catch non-trivial bugprone cases. This change includes: - CMake option called `WITH_CLANG_TIDY` which enables Clang Tidy linter tool on all source in the `source/` directory. This option is only available on Linux, as it is currently the easiest platform to get the Clang Tidy toolchain to work. - CMake module which is aimed to find latest available Clang Tidy. - Set of rules which allows to have Blender fully compiled without extra issues. The goal of this change is to provide a base ground so that solving all the warnings can happen later on, as a team effort. It should be possible to use Clang Tidy side-by-side with both GCC and Clang, but there seems to be some tweaks to be done in CMake to make it really work for Blender. For now use Clang toolchain if there are issues with GCC+Clang Tidy. It will be worked on in the nearest future to bring seamless experience for all configurations. Currently there is no official way of getting Clang Tidy on macOS, and on Windows there are some difficulties of hooking up Clang Tidy from LLVM package to the MSVC compiler toolchain. The actual warnings in the code will be addressed as a part of the Code Quality Days, task T78535. Differential Revision: https://developer.blender.org/D7937