Age | Commit message (Collapse) | Author |
|
outflow objects.
Reviewed By: brecht
Differential Revision: https://developer.blender.org/D2719
|
|
Previous fix relying on __cplusplus value didn't fix for older
gcc's on linux, but this fix does.
|
|
Older C++ compilers use finite instead of isfinite.
|
|
D2556 by @chrisr
|
|
The Issue
=======
For a long time now MinGW has been unsupported and unmaintained and at this point,
it looks like something that we should just leave behind and move on.
Why Remove
==========
One of the big motivations for MinGW back in the day is that it was free compared to MSVC which was licensed based.
However, now that this is no longer true we have basically stopped updating the need CMake files.
Along with the CMake files, there are several patches to the extern libs needed to make this work. For example, see:
https://developer.blender.org/diffusion/B/browse/master/extern/carve/patches/mingw_w64.patch
If we wanted to keep MinGW then we would need to make more custom patches to the external libs and
this is not something our platform maintainers are willing to do.
For example, here is the patches needed to build python: https://github.com/Alexpux/MINGW-packages/tree/master/mingw-w64-python3
Fixes T51301
Differential Revision: https://developer.blender.org/D2648
|
|
|
|
Fixes for clamp-omp, fewer shared variables, fix some cases of threads writing
to the same memory location. Issue found by Jens Verwiebe, who reports 30%
speedup with 16 core CPU, when using this with a recent clang-omp version.
|
|
Was polluting compile output too much.
|
|
This mainly touches extern libraries and few debug-only places in intern.
Some summary:
- External libraries are not strict at all about missing declarations,
so we can rather safely remove such warning together with other strict
flags.
- Bullet has some static functions which are not used.
Those were commented out.
- Carve now has some unused debug-only functions commented out as well.
While we're on the way of getting rid of Carve, it makes sense to make
things a bit cleaner for the time being.
- In LZMA we have some parts disabled which gives some set but unused
variables which is rather correct.
- Elbeem had quite some variables set and never used because their usage
is inside of debug-only code which is commented out.
Note about patching upstream libraries: surely one might say that we
have to make local patchset against this, but own experience says it
only gives extra work trying to merge such tweaks to a new upstream
version and usually it's just faster to re-apply such fixes again after
bundling new upstream library.
|
|
While SCons building system was serving us really good for ages it's no longer
having much attention by the developers and started to become quite a difficult
task to maintain.
What's even worse -- there started to be quite serious divergence between SCons
and CMake which was only accumulating over the releases now. The fact that none
of the active developers are really using SCons and that our main studio is also
using CMake spotting bugs in the SCons builds became quite a difficult task and
we aren't always spotting them in time.
Meanwhile CMake became really mature building system which is available on every
platform we support and arguably it's also easier and more robust to use.
This commit includes:
- Removal of actual SCons building system
- Removal of SCons git submodule
- Removal of documentation which is stored in the sources and covers SCons
- Tweaks to the buildbot master to stop using SCons submodule
(this change requires deploying to the server)
- Tweaks to the install dependencies script to skip installing or mentioning
SCons building system
- Tweaks to various helper scripts to avoid mention of SCons folders/files
as well
Reviewers: mont29, dingto, dfelinto, lukastoenne, lukasstockner97, brecht, Severin, merwin, aligorith, psy-fi, campbellbarton, juicyfruit
Reviewed By: campbellbarton, juicyfruit
Differential Revision: https://developer.blender.org/D1680
|
|
|
|
|
|
|
|
|
|
Crash only happened when the number of openmp threads were greater than the resolution.
|
|
Changes for VC2013
Now, I can build Blender with VC2013 with Cycles, Collada, OpenExr,OpenImageIO disabled. Also, you need VC2008 sp1 installed to make old libs compatible.
|
|
|
|
|
|
Global OpenMP threads override is not a good idea because this would affect
all possible OpenMP blocks running at the same time as simulation.
And that was actually a big on restoring number of threads: code needed to
store current number of threads, not maximal one.
|
|
checks weren't needed.
also remove redundant dot_v3v3 in shrinkwrap constraint.
|
|
BLI_scanfill_begin().
|
|
threadcount to logical threadcount of machine
|
|
todo: default should be logical corecount
|
|
enabled
|
|
|
|
|
|
I am unsure if I did catch all problematic code but I ran out of memorybefore the sim started ;)
|
|
to include a few more that gcc is using too.
|
|
Also changed shebang to '#!/usr/bin/env python', this is more portable across unixes...
|
|
Thanks to Brecht for providing a patch and example blend.
I changed and extended it a bit since there was another bug in that loop.
|
|
keyframe
Also fix:
- Fluid simulation was always lagging 1 frame behind: E.g. the 250th frame in blender showed 249th frame of the fluid simulation.
Change:
- Animated enabled/disabled property only gets counted as "on" if value >= 1
Note that this bugfix should solve many problems with timings of animated fluid sim properties.
|
|
|
|
Fixed as suggested by Campbell, thank you!
|
|
Note: Compile still fails during ceres compile (namespace tr1 problems).
|
|
also fix for building ghost test and fix double free in one of the tests
|
|
- remove duplicate includes
- blender builds with -Werror in C++ for fluids/smoke
|
|
Patch provided by Matteo F. Vescovi, thanks!
|
|
Thank you for submitting!
|
|
and looks like -fpermissive is used in linux too
|
|
to ints. All cases found were harmless and the error behaviour could be turned off by the -fpermissive flag but I'd rather keep that off to detect any real problems should they arise.
|
|
PVS-Studio.
Remark: I think that "!(nbored & CFBnd)" would be correct but it introduced other bugs so, I just quiet compiler warnings leaving the running system untouched.
|
|
Canceling fluid simulation did not work when speed was zero.
|
|
Note: Supporting obstacles which can be enabled/disabled as animated propoerty is not likely to happen. So I marked this as "Won't fix"/TODO.
I also reverted last commit on this bug because it didn't work and disabled the property from UI to avoid confusion.
|
|
Needs testing for sideeffects.
If there are negative sideeffects, revert commit and mark as "will not fix"/"not supported"/"needs UI fix".
|
|
|
|
http://markmail.org/message/fp7ozcywxum3ar7n
|
|
gave wrong results. Note how in this code it already incremented to the start
time and then incorrectly added it again. Patch by Chris Foster, thanks!
|
|
http://projects.blender.org/tracker/?func=detail&atid=498&aid=28748&group_id=9
I'd say better be careful with code so complex as the fluid sim!
|
|
intern/elbeem/intern/solver_relax.h)
|
|
|