Welcome to mirror list, hosted at ThFree Co, Russian Federation.

git.blender.org/blender.git - Unnamed repository; edit this file 'description' to name the repository.
summaryrefslogtreecommitdiff
AgeCommit message (Collapse)Author
2020-11-06Cleanup: doxygen comments in ghostCampbell Barton
Use colon after parameters, use hash to reference symbols.
2020-11-06Cleanup: use ELEM macroCampbell Barton
2020-11-06Cleanup: use string APPEND/PREPENDCampbell Barton
Replace 'set' with 'string(APPEND/PREPEND ...)'. This avoids duplicating the variable name.
2020-11-04macOS: remove deprecated touch event API callBrecht Van Lommel
Now that the minimum version is macOS 10.13, we can use the new API. This reverts commit f97a64aa9b7b384f8221a1ef4f2eef9cde1238db.
2020-11-03Fix T64138: Windows Ink continuous grab at window edge.Nicholas Rishel
WM_POINTERLEAVE occurs when the pen goes out of range or when a hovering pen leaves the window's boundary. When leaving the window boundary the xy position is invalid for some Wacom devices. This change removes creation of GHOST_EventCursor during WM_POINTERLEAVE events. This prevents unexpected jumping behavior during continuous grab.
2020-10-31Cleanup: clang-formatLukas Stockner
2020-10-31Previous check seems to have a race condition, resulting in Wintab not being ↵Nicholas Rishel
enabled.
2020-10-31Add explanation for dequing Wintab PACKETs during WT_PACKET event into a ↵Nicholas Rishel
local queue to consume during WM_* mouse events.
2020-10-31Commented assumption was incorrect, using tickCountToMillis causes underflow ↵Nicholas Rishel
when compared to current time.
2020-10-31Cleanup: rename functions for consistency with other process*Events functions.Nicholas Rishel
2020-10-31Cleanup: Use C style comments, punctuation, and capitalization.Nicholas Rishel
Added missing function documentation.
2020-10-31Remove Wintab logging.Nicholas Rishel
2020-10-31Add Wintab debug logging as a CMake option WITH_WINTAB_DEBUG.Nicholas Rishel
Signed-off-by: Nicholas Rishel <rishel.nick@gmail.com>
2020-10-31Finish the comment's thought explaining pessimistic button ups events forNicholas Rishel
Wintab.
2020-10-31Return of the Wintab refactor.Nicholas Rishel
Previously Wintab was handled by saving the most recent tablet pressure and tilt information and deferred appending tablet infromation to Windows mouse events. This caused synchronization issues evident at the beginning and ending of strokes where pressure and tilt were either ahead or behind in time from mouse button up or down events. This also dicarded swaths of data which resulted in blockly grease pencil lines most apparent when a context switch resulted in several coalesced mouse events. This patch changes the behavior of Wintab to instead rely entirely on Wintab information for pressure, tilt, position, and button input. Wintab has several design decisions and conventions which complicate relying soley on it's input while retaining current workflows reliant on non-API behavior. For example, many device optionally allow the user to map barrel buttons to non-mouse actions. These mappings may or may not modify the intended behavior when touching the stylus down, such as scroll vs alt mappings. This behavior is not exposed in the Wintab API, but Wintab will continue updating button state sans this necessary context. To work around the problem, this refactor synchronizations tablet input to Windows mouse down and up events, this captures events which should result in pen input while allowing events such as pen scrolling. Until a Windows mouse down event fires Wintab input is left unprocessed; when a Windows up event occurs Wintab is processed until a corresponding button up event is found. Wintab allows for either button state or changes to be reported, but not both. An earlier refactor tried to use button changes to let state to be managed by Wintab. This was replaced when it was found that button change events were unreliable at corner cases such as switching windows. It was also found that with Wacom drivers Wintab peek functions would modify events in the queue causing errant and loss of button events. For the latter stated reason this patch opts to read all Wintab events into a queue as they arrive, removing events as they become stale. This was chosen over using Wintab peek functions due to the afformentioned issue. As a bonus this seems to work better as it prevents the queue in Wintab from filling, thus neither a flood of events need to be handled when Wintab processing begins and a Wintab implementation need not be trusted to overwrite old events in it's queue. Maniphest Tasks: T75566 Differential Revision: https://developer.blender.org/D7840
2020-10-31Before a wintab button event is generated, generate a GHOST mouse moveNicholas Rishel
event to the button down location as this should be a more accurate point of contact than the last mouse move event. Signed-off-by: Nicholas Rishel <rishel.nick@gmail.com>
2020-10-31Adding explanitory comment to explain why tablet API check is necessaryNicholas Rishel
for Pointer input even when Wintab should be preventing Pointer events. Signed-off-by: Nicholas Rishel <rishel.nick@gmail.com>
2020-10-31When there are not associated button events, assume there is no buttonNicholas Rishel
events until one is found. This prevents errant cursor moves that occur before the Wintab button event is reported. We need to skip these events because if no button event exists, we generate one assuming it will either arrive later in the Wintab queue or that the button was from a non-Wintab device. For the case that this was generated by a non-wintab device, such as buttons mapped to mouse on the tablet pad, these cursor move events can significantly move the cursor from the intended click position. Signed-off-by: Nicholas Rishel <rishel.nick@gmail.com>
2020-10-31Clarify comment to be more specific so that in the future someone knowsNicholas Rishel
the issue with Wintab button events are more significant than simply setting what buttons should receive button up/down events during context initialization. Signed-off-by: Nicholas Rishel <rishel.nick@gmail.com>
2020-10-31Save Wintab packets to a local queue as WT_PACKET events arrive or whenNicholas Rishel
handling mouse input. This Wintab to mouse synchronization issues, and likely prevents queue exhaustion for some Wintab implmenetations. Signed-off-by: Nicholas Rishel <rishel.nick@gmail.com>
2020-10-31Correcting the type for indexing Wintab buttons.Nicholas Rishel
Signed-off-by: Nicholas Rishel <rishel.nick@gmail.com>
2020-10-31Change updateWintab interface to include whether window is visible so thatNicholas Rishel
window intitialization can specify whether it will be visible regardless of whether it is yet visible. Signed-off-by: Nicholas Rishel <rishel.nick@gmail.com>
2020-10-31Revert "Mask all button down/up and switch back to using relative button input."Nicholas Rishel
This reverts commit 045aaf6f78f1fbb6e2bbefd234b7bae04844d42b.
2020-10-31Fix type for physicalButton in wintabMouseToGhost.Nicholas Rishel
Signed-off-by: Nicholas Rishel <rishel.nick@gmail.com>
2020-10-31Fix return value of WTPacketsGet.Nicholas Rishel
Signed-off-by: Nicholas Rishel <rishel.nick@gmail.com>
2020-10-31Move assignments into initializer list for GHOST_EventButtonNicholas Rishel
and GHOST_EventCursor. Signed-off-by: Nicholas Rishel <rishel.nick@gmail.com>
2020-10-31Mask all button down/up and switch back to using relative button input.Nicholas Rishel
Signed-off-by: Nicholas Rishel <rishel.nick@gmail.com>
2020-10-31Document inline that PACKETDATA and PACKETMODE modify external headers toNicholas Rishel
discourage reducing their scope to the only place they're used internally. Signed-off-by: Nicholas Rishel <rishel.nick@gmail.com>
2020-10-31Allow double button up, otherwise there may be a trailing 0 pressure line.Nicholas Rishel
Signed-off-by: Nicholas Rishel <rishel.nick@gmail.com>
2020-10-31Fix T75566Nicholas Rishel
Button events now include tabletdata, so move is unnecessary. Generate mouse button events when the system has an event but Wintab did not find a correlated event. Only filter mouse button events, not Win32 Pointer events. Signed-off-by: Nicholas Rishel <rishel.nick@gmail.com> Maniphest Tasks: T75566 Differential Revision: https://developer.blender.org/D7404
2020-10-31Button events now include tabletdata, so move is unnecessary.Nicholas Rishel
Signed-off-by: Nicholas Rishel <rishel.nick@gmail.com>
2020-10-31Revert "Revert "Windows: support high resolution tablet pen events for Wintab""Nicholas Rishel
This reverts commit e90d8422d0ed38743390f2184fde27550d7b48a7.
2020-10-30Merge remote-tracking branch 'origin/blender-v2.91-release'Dalai Felinto
2020-10-30Fix macOS mouse positions inaccuracyBrecht Van Lommel
Don't use the current mouse position at the time the event is handled, but rather the position at the time of the event. This should make e.g. brush stroke paths more accurate. In addition, this may solve issues with other software that does mouse position smoothing. Ref T82143. Use of the current mouse position was added in 12b642062c6f as part of a large commit that also made continuous grab work. But it appears to still work getting the mouse position from the event.
2020-10-27Cleanup: use over-line for doxy commentsCampbell Barton
Follow our code style for doxygen sections.
2020-10-19Spelling: MiscellaneousHarley Acheson
Corrects 34 miscellaneous misspelled words. Differential Revision: https://developer.blender.org/D9248 Reviewed by Campbell Barton
2020-10-19Spelling: Then Versus ThanHarley Acheson
Corrects incorrect usages of the words 'then' and 'than'. Differential Revision: https://developer.blender.org/D9246 Reviewed by Campbell Barton
2020-10-19Spelling: It's Versus ItsHarley Acheson
Corrects incorrect usage of contraction for 'it is', when possessive 'its' was required. Differential Revision: https://developer.blender.org/D9250 Reviewed by Campbell Barton
2020-10-15Fix part of T74918: 3D Viewport: Jump, when mouse crosses a window corner.Bastien Montagne
We need a separate time stamp for each axis, and we have to add a few milliseconds of padding to those, to ensure wrapping on both axes get properly performed when it happens almost simultaneously, and avoid extra wrapping caused by very close events sometimes. This only addresses the Linux (X11 backend) case. Differential Revision: https://developer.blender.org/D9209
2020-10-09Cleanup: spellingCampbell Barton
2020-10-01Windows: workaround to make Windows Ink tablet API workNicholas Rishel
Now Wintab is not initialized when starting Blender with the tablet API preference set to native, since that disables Windows Ink. Note that changing the tablet API requires restarting Blender for changes to take effect. This serves as a stopgap to allow use of Windows Ink until runtime API switching is merged. Differential Revision: https://developer.blender.org/D9051
2020-10-01macOS: support for key repeat events in keymapsYevgeny Makarov
Differential Revision: https://developer.blender.org/D8882
2020-09-30Cleanup: convert gforge task ID's to phabricator formatValentin
Cleanup old tracker task format to the new. e.g: [#34039] to T34039 Ref D8718
2020-09-30Cleanup: spellingCampbell Barton
2020-09-12Cleanup: use C style doxygen commentsCampbell Barton
2020-09-08GPUImmediate: Make activation / deactivation implicitClément Foucault
This avoids unecessary complexity. Also makes the GPUImmediate threadsafe by using a threadlocal imm variable.
2020-09-07Cleanup: spellingCampbell Barton
Also correct wrapped lines of example code in threads.cc.
2020-09-02Fix unused variable warning on Windows with WITH_INPUT_IME disabledJulian Eisel
2020-09-01GHOST: Enable debug context on offscreen context tooClément Foucault
This was a long standing TODO. This was also preventing debug callbacks form other context than the main window.
2020-08-26Fix T77900: File Browser in macOS fullscreen crashesYevgeny Makarov
When Blender is started in fullscreen mode from the command line, or if the fullscreen state is saved in the startup file, all temporary windows will also open in fullscreen mode. When closing the fullscreen File Browser, Blender would either crash or parent window becomes black. This does not happen if the Blender switches to full screen manually. `NSWindowCollectionBehaviorFullScreenPrimary` should be set for windows that can enter full-screen mode. Otherwise macOS will turn the wrong window into full-screen. Similar fix: rB4b39de677d20 Differential Revision: https://developer.blender.org/D8708 Reviewed by: Julian Eisel