| Age | Commit message (Collapse) | Author |
|---|
|
While this looks trivial it already allowed to catch issues in one
of previous attempt to optimize memory usage. It will totally be
useful for an upcoming refactor of face topology storage.
|
|
Move all API to happen via MeshTopology.
This is a preparation for an upcoming memory optimization.
|
|
There is no need in edge map anymore.
|
|
|
|
|
|
Allows to perform comparison by doing linear comparison of indices.
Before cyclic match was used to deal with possibly changed winding from
OpenSubdiv side.
Speeds up comparison (and hence improves FPS), makes code more reliable
nut uses more memory.
|
|
This change makes it so topology refiner comparison will check vertices
of all existing/provided edges.
The initial claim that due to manifold nature of mesh there is no need
in "deep" edges check was wrong: some areas might only provide edges
with non-zero creases. So if crease of one edge goes changes from 1.0
to 0.0 and crease of other edge goes from 0.0 to 1.0 the old comparison
code would not have caught it.
|
|
Makes it easier to follow and extend.
|
|
Similar to previous change in vertex sharpness, explicitly store value
provided by the converter.
Allows to avoid rather fragile check for boundary edges.
Also allows to avoid need in constructing edge map. This lowers memory
footprint of the comparison process and avoids memory allocations
during the comparison (which is an extra benefit from the performance
point of view).
|
|
|
|
|
|
This change starts the transition of topology refiner comparison
to compare actual values given by the converter, which will not be
affected by the refinement or face winding synchronization steps.
Currently is only implemented for vertex sharpness, but will be
extended further as followup development.
Fixes T71908: Subdiv: Incorrect topology comparison, leading to poor performance
|
|
The idea is to use this explicit storage for topology comparison rather
than using base level. While this will have memory overhead it allows
to simplify comparison of such things as:
- Vertex sharpness (where base level from topology refiner will have it
refined, meaning it will be different from what application requested
for non-manifold and corner vertices).
- It will allow to simplify face-vertices comparison, where currently
O(N^2) algorithm is used due to possible difference in face winding.
- It will also allow to avoid comparison-time allocation of edge map.
Currently no functional changes, just preparing for development which
will happen next.
|
|
|
|
|
|
Also split them across utilities and types.
|
|
|
|
Avoid indirection via define.
|
|
|
|
|
|
|
|
Previously it was enabled for debug builds, now it is to be enabled
explicitly.
The reason for this is to reduce overhead when debugging other areas
which might involve subdivision surface. When conversion is to be
debugged set this manually in the code.
|
|
|
|
Consolidate it inside of the topology refiner implementation class,
which would allow to store extra data acquired during construction
of the OpenSubdiv's object.
|
|
Only use OBJECT_GUARDED_{NEW. DELETE} for structures which are part of
public C-API (and hence can not have new/delete operators overloaded).
Could try being brave and override new/delete from under C++ ifdef.
|
|
|
|
In the future factory will also be moved there.
|
|
Also, move all device files to own folder.
Makes it so checks for device availability are done in a localized
place.
|
|
Enabled round linear hair in Embree.
Differential Revision: https://developer.blender.org/D7623
|
|
Caused deprecated-copy warnings as it wasn't used.
|
|
|
|
|
|
This patch uses the sampling method described in "A Low Distortion Map Between Triangle and Square" by Eric Heitz.
The benefit is avoiding sqrt in the calculation, which could be cheaper on some architectures, and the result is
more even sampling across the triangle surface.
Based on ideas from
https://pharr.org/matt/blog/2019/02/27/triangle-sampling-1.html
https://pharr.org/matt/blog/2019/03/13/triangle-sampling-1.5.html
Reviewed By: Brecht Van Lommel
Differential Revision: https://developer.blender.org/D6566
|
|
|
|
|
|
|
|
This wasn't returning milliseconds, causing problems with key repeat.
|
|
|
|
# Conflicts:
# source/blender/draw/engines/eevee/eevee_volumes.c
|
|
The problem was that Cycles would store a pointer to an object in
`DEGObjectIterData->templ_dupli_object`. This pointer was then accessed
when the iterator was already freed.
Reviewers: brecht
Differential Revision: https://developer.blender.org/D7797
|
|
|
|
Previously this would be enabled when threads were used, but threads are now
basically always in use so there is no point. Further, this is only needed for
guarded allocation with --debug-memory which is not performance critical.
|
|
This helped to go beyond the 4GB limit, but is no longer relevant for 64 bit.
|
|
This code was accidentally reintroduced in e73d7d27dc66.
|
|
|
|
Makes use of the new particle skipping option introduced in f25a882955cb.
|
|
Reviewers: sergey, brecht
Differential Revision: https://developer.blender.org/D7787
|
|
|
|
Adapted mesh generation to account for domains with disabled fractionstoo.
|
|
Differential Revision: https://developer.blender.org/D7782
|
