Age | Commit message (Collapse) | Author | |
---|---|---|---|
2018-11-14 | Cleanup: comment block tabs | Campbell Barton | |
2018-06-17 | Cleanup: trailing space for compositor | Campbell Barton | |
2018-06-01 | Cleanup: trailing whitespace (comment blocks) | Campbell Barton | |
Strip unindented comment blocks - mainly headers to avoid conflicts. | |||
2017-11-09 | Moved alignment attributes from my last commit to BLI_compiler_attrs.h for ↵ | Stefan Werner | |
future use. | |||
2017-11-09 | Compositor: Ensured 16 byte alignment for variables accessed by SSE ↵ | Stefan Werner | |
instructions. Before this patch, the XBlur/YBlur compositor nodes would crash for me when run in a MSVC 2015 debug build (test scene: BMW27_cpu). I added the compiler instructions to explicitly align the local variables that the SSE instructions are accessing. | |||
2015-03-27 | Compositor: Code cleanup, prepare for strict C++ flags | Sergey Sharybin | |
2014-10-06 | Compositor: implement OpenCL backend for gaussian blur | Sergey Sharybin | |
Pretty much straightforward change which gives around 30% speedup on my laptop and around 2x speedup on desktop in the BI (which uses gts580). Tested with huge blurs (like 10% of blur) which was rather common during Caminandes. For now OpenCL is only limited for blur size more than 100 pixels. This is a bit experimental still, feedback is welcome. Reviewers: jbakker, lukastoenne Subscribers: ton Differential Revision: https://developer.blender.org/D576 | |||
2014-06-13 | Use advantage of SSE2 instructions in gaussian blur node | Sergey Sharybin | |
This gives around 30% of speedup for gaussian blur node. Pretty much straightforward implementation inside the node itself, but needed to implement some additional things: - Aligned malloc. It's needed to load data onto SSE registers faster. based on the aligned_malloc() from Libmv with some additional trickery going on to support arbitrary alignment (this magic is needed because of MemHead). In the practice only 16bit alignment is supported because of the lack of aligned malloc with arbitrary alignment for OSX. Not a bit deal for now because we need 16 bytes alignment at this moment only. Could be tweaked further later. - Memory buffers in compositor are now aligned to 16 bytes. Should be harmless for non-SSE cases too. just mentioning. Reviewers: campbellbarton, lukastoenne, jbakker Reviewed By: campbellbarton CC: lockal Differential Revision: https://developer.blender.org/D564 | |||
2014-06-01 | Fix T40459: Gauss table can be NULL when ending the blur node operation, | Lukas Tönne | |
which must not be passed to MEM_freeN. | |||
2014-04-15 | Structural cleanup and improvements for the compositor. | Lukas Tönne | |
Many parts of the compositor are unnecessarily complicated. This patch aims at reducing the complexity of writing nodes and making the code more transparent. == Separating Nodes and Operations == Currently these are both mixed in the same graph, even though they have very different purposes and are used at distinct stages in the compositing process. The patch introduces dedicated graph classes for nodes and for operations. This removes the need for a lot of special case checks (isOperation etc.) and explicit type casts. It simplifies the code since it becomes clear at every stage what type of node we are dealing with. The compiler can use static typing to avoid common bugs from mixing up these types and fewer runtime sanity checks are needed. == Simplified Node Conversion == Converting nodes to operations was previously based on "relinking", i.e. nodes would start with by mirroring links in the Blender DNA node trees, then add operations and redirect these links to them. This was very hard to follow in many cases and required a lot of attention to avoid invalid states. Now there is a helper class called the NodeConverter, which is passed to nodes and implements a much simpler API for this process. Nodes can add operations and explicit connections as before, but defining "external" links to the inputs/outputs of the original node now uses mapping instead of directly modifying link data. Input data (node graph) and result (operations graph) are cleanly separated. == Removed Redundant Data Structures == A few redundant data structures have been removed, notably the SocketConnection. These are only needed temporarily during graph construction. For executing the compositor operations it is perfectly sufficient to store only the direct input link pointers. A common pointer indirection is avoided this way (which might also give a little performance improvement). == Avoid virtual recursive functions == Recursive virtual functions are evil. They are very hard to follow during debugging. At least in the parts this patch is concerned with these functions have been replaced by a non-virtual recursive core function (which might then call virtual non-recursive functions if needed). See for example NodeOperationBuilder::group_operations. | |||
2014-02-13 | Fix T38529, Blur node size 0 doesn't work. | Lukas Tönne | |
The blur operations were clamping the filter size to 1, which prevents no-op blur nodes. Further any value < 1 would also be ignored and in many combinations the filter scale setting ("Size") would only work in integer steps. Now most blur settings will work with smooth Size value scaling as well, meaning you can choose a reasonably large filter size (e.g. 10) and then use the Size factor to scale the actual blur radius smoothly. Note that non-integer filter sizes also depend on the filter type selected in the Blur node, e.g. "Flat" filtering will still ignore smooth filter sizes. Gaussian filters work best for this purpose. | |||
2013-12-22 | Style Cleanup: remove preprocessor indentation (updated wiki style guide too) | Campbell Barton | |
2013-06-08 | Fix for bug [#35400] Dilate Erode Feather Bug - feathering wraps around image | Monique Dewanchand | |
2013-05-13 | Fix #35330: Blur node crash due to size overflow | Sergey Sharybin | |
Issue was caused by too hight value used for size, which came from infinite Z-buffer point. Solved the crash by clamoing maximal gaussian table radius to 30K, which seems to be reasonable. | |||
2013-02-04 | style cleanup | Campbell Barton | |
2013-02-03 | Fix for [#34022] Lines on renders using Blur node in flat mode | Jeroen Bakker | |
2012-11-04 | fix own error in r51819, was reading outside of the buffer, also comment ↵ | Campbell Barton | |
unused vars. | |||
2012-11-02 | fix for compositor regression where blur note offset the image one pixel to ↵ | Campbell Barton | |
the top right. | |||
2012-09-30 | fix for double free. | Campbell Barton | |
2012-08-16 | compositor: replace C++ new/delete with guardedalloc. | Campbell Barton | |
2012-08-10 | code cleanup: compositor - define size for executePixel function output ↵ | Campbell Barton | |
float array | |||
2012-07-13 | Inner loop optimization of blur node | Jeroen Bakker | |
2012-07-13 | Removed parameter from executePixel and initializeTileData. | Jeroen Bakker | |
2012-07-12 | Small optimizations in compositor. | Jeroen Bakker | |
Most of them are not noticeable. | |||
2012-06-26 | use m_ prefix for compositor class members (all compositor operations). | Campbell Barton | |
2012-06-25 | fix for crash with blur - happened most when there was a size input, need to ↵ | Campbell Barton | |
mutex lock before allocating the gauss array. also add suspiciously missing call to BlurBaseOperation::initExecution, X had but Y was missing. | |||
2012-06-16 | code cleanup: make names more logical | Campbell Barton | |
2012-06-16 | code cleanup: spelling 'multiplyer' --> 'multiplier' | Campbell Barton | |
2012-06-16 | feather option for dilate/erode node - needed for alpha masks so we can ↵ | Campbell Barton | |
(blur in/out), currently only positive values supported. | |||
2012-06-15 | fix for other uninitialized values for the split viewer node as well as ↵ | Campbell Barton | |
incorrect frees for gaussian blue nodes. | |||
2012-06-15 | style cleanup: composite/blur | Campbell Barton | |
2012-06-13 | yse BLI_math for the compositor in more places. | Campbell Barton | |
2012-06-11 | * Blur node had some irregularities at the edge of the screen | Jeroen Bakker | |
only visible when doing large size blurs. also solved the catcom/mitch filter that didn't work at low/medium quality PS never use BokehBlur Gausian filter as it is 99%+ identicat as non bokeh <= top for sergey- :) | |||
2012-06-09 | code cleanup: reduce float/double promotion | Campbell Barton | |
2012-06-04 | Fix for relative blur size for non-fast gaussian blur methods. | Sergey Sharybin | |
Call base blur's initExecution from GaussianBokehBlurOperation and GaussianXBlurOperation | |||
2012-06-01 | Optimize Gaussian blurs | Monique Dewanchand | |
2012-05-18 | style cleanup: compositor, pointer syntax, function brace placement, line length | Campbell Barton | |
2012-05-17 | style cleanup: braces, compositor | Campbell Barton | |
2012-05-17 | ____ | Jeroen Bakker | |
`````|````` | | | ..'''' | | | |______ .'' | | | | ..' | | |_______ |___________ ....'' merge to TRUNK! * The old compositor is still available (Debug Menu: 200) This commit was brought to you by: Developers: * Monique Dewanchand * Jeroen Bakker * Dalai Felinto * Lukas Tönne Review: * Brecht van Lommel Testers: * Nate Wiebe * Wolfgang Faehnle * Carlo Andreacchio * Daniel Salazar * Artur Mag * Christian Krupa * Francesco Siddi * Dan McGrath * Bassam Kurdali But mostly by the community: Gold: Joshua Faulkner Michael Tiemann Francesco Paglia Blender Guru Blender Developers Fund Silver: Pablo Vazquez Joel Heethaar Amrein Olivier Ilias Karasavvidis Thomas Kumlehn Sebastian Koenig Hannu Hoffrén Benjamin Dansie Fred M'ule Michel Vilain Bradley Cathey Gianmichele Mariani Gottfried Hofmann Bjørnar Frøyse Valentijn Bruning Paul Holmes Clemens Rudolph Juris Graphix David Strebel Ronan Zeegers François Tarlier Felipe Andres Esquivel Reed Olaf Beckman Jesus Alberto Olmos Linares Kajimba Maria Figueiredo Alexandr Galperin Francesco Siddi Julio Iglesias Lopez Kjartan Tysdal Thomas Torfs Film Works Teruyuki Nakamura Roger Luethi Benoit Bolsee Stefan Abrahamsen Andreas Mattijat Xavier Bouchoux Blender 3D Graphics and Animation Henk Vostermans Daniel Blanco Delgado BlenderDay/2011 Bradley Cathey Matthieu Dupont de Dinechin Gianmichele Mariani Jérôme Scaillet Bronze (Ivo Grigull, Dylan Urquidi, Philippe Derungs, Phil Beauchamp, Bruce Parrott, Mathieu Quiblier, Daniel Martinez, Leandro Inocencio, Lluc Romaní Brasó, Jonathan Williamson, Michael Ehlen, Karlis Stigis, Dreamsteep, Martin Lindelöf, Filippo Saracino, Douwe van der Veen, Olli Äkräs, Bruno D'Arcangeli, Francisco Sedrez Warmling, Watchmike.ca, peter lener, Matteo Novellino, Martin Kirsch, Austars Schnore, KC Elliott, Massimiliano Puliero, Karl Stein, Wood Design Studios, Omer Khan, Jyrki Kanto, Michał Krupa, Lars Brubaker, Neil Richmond, Adam Kalisz, Robert Garlington, Ian Wilson, Carlo Andreacchio, Jeremias Boos, Robert Holcomb, Gabriel Zöller, Robert Cude, Natibel de Leon, Nathan Turnage, Nicolas Vergnes, Philipp Kleinhenz, Norman Hartig, Louis Kreusel, Christopher Taylor, Giovanni Remondini, Daniel Rentzsch, Nico Partipilo, Thomas Ventresco, Johannes Schwarz, Александр Коротеев, Brendon Harvey, Marcelo G. Malheiros, Marius Giurgi, Richard Burns, Perttu Iso-Metsälä, Steve Bazin, Radoslav Borisov, Yoshiyuki Shida, Julien Guigner, Andrew Hunter, Philipp Oeser, Daniel Thul, Thobias Johansson, Mauro Bonecchi, Georg Piorczynski, Sebastian Michailidis, L M Weedy, Gen X, Stefan Hinze, Nicolò Zubbini, Erik Pusch, Rob Scott, Florian Koch, Charles Razack, Adrian Baker, Oliver Villar Diz, David Revoy, Julio Iglesias Lopez, Coen Spoor, Carlos Folch, Joseph Christie, Victor Hernández García, David Mcsween, James Finnerty, Cory Kruckenberg, Giacomo Graziosi, Olivier Saraja, Lars Brubaker, Eric Hudson, Johannes Schwarz, David Elguea, Marcus Schulderinsky, Karel De Bruijn, Lucas van Wijngaarden, Stefano Ciarrocchi, Mehmet Eribol, Thomas Berglund, Zuofei Song, Dylan Urquidi ) |