Age | Commit message (Collapse) | Author |
|
|
|
|
|
|
|
Reviewers: campbellbarton
Differential Revision: https://developer.blender.org/D6701
|
|
button in the Image slot in the Brush panel
Caused/exposed by rBaf9ca138ba7b
Also relevant was rB828905190e12
Above commits moved the WM_UI_HANDLER_BREAK around so it would not be
returned anymore.
We need WM_UI_HANDLER_BREAK, otherwise we wont get through to to
KM_RELEASE. There are two places that explicitly check for KM_RELEASE
(call to `ui_do_but_extra_operator_icon` in both
`ui_do_but_SEARCH_UNLINK` / `ui_do_button`), and without the above we
only ever get here with KM_PRESS.
This patch restores the behavior regarding WM_UI_HANDLER_BREAK to what
is was before the two culprit commits.
Checked that both this report (T72089) and T69755 are working.
Maniphest Tasks: T72089
Differential Revision: https://developer.blender.org/D6363
|
|
To issues caused this:
* The code to launch the filebrowser from a button didn't respect popup
menus stored in context
* There was actually no popup menu region stored in context for this
case. Doing so *may* introduce other issues, but the way I did things
already fixes all issues I've found.
|
|
|
|
Differential Revision: https://developer.blender.org/D6483
|
|
|
|
Logic to open menus on hover changed since 2.7x for convenience
switching between popovers in the top-bar.
This also made hover open menus in situations where it isn't useful.
Restrict this to buttons placed side-by-side.
|
|
`ARegion.alignment` unfortunately is a mixture of value and bitflag
enumerations. When checking for left/right/top/bottom region alignment,
the flags have to be masked out usually.
Most of the fixed cases here probably didn't cause issues in practice,
but could in fact break at any point when surrounding logic changes.
In fact the assert in #region_visible_rect_calc() failed in an older
file from https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=949035. This
fixes it.
|
|
|
|
|
|
Also correct some outdated symbol references,
add missing 'name' commands.
|
|
Also remove unused vars.
|
|
Custom profiles in bevel allows the profile curve to be controlled by
manually placed control points. Orientation is regularized along
groups of edges, and the 'pipe case' is updated. This commit includes
many updates to comments and changed variable names as well.
A 'cutoff' vertex mesh method is added to bevel in addition to the
existing grid fill option for replacing vertices.
The UI of the bevel modifier and tool are updated and unified.
Also, a 'CurveProfile' widget is added to BKE for defining the profile
in the interface, which may be useful in other situations.
Many thanks to Howard, my mentor for this GSoC project.
Reviewers: howardt, campbellbarton
Differential Revision: https://developer.blender.org/D5516
|
|
Causes undo push in sculpt mode, see: T71434
|
|
Usually Ctrl+C copies the operator name to the clipboard
["bpy.ops.material.new()", "bpy.ops.object.material_slot_remove()"]
Crash happens for all buttons of UI_BTYPE_BUT without associated
operator [some are defined with callbacks only, often these are created
with e.g uiDefIconBut (instead of e.g. uiDefIconButO)]
Other examples that crash with Ctrl+C:
- animation decorators next to animatable properties
- button to show a modifier texture in the texture tab
- ...
2.79 survived here (result in the clipboard was just not changed hitting
Ctrl+C on these buttons), this is what happens with this patch as well.
Maniphest Tasks: T71405
Differential Revision: https://developer.blender.org/D6208
|
|
'is_copy' was not set correctly on all uiButMultiState (it was done once
for uiHandleButtonData), resulting in 'delta' being used on some indices
of the array and not others in `ui_selectcontext_apply`.
Maniphest Tasks: T55632
Differential Revision: https://developer.blender.org/D6201
|
|
When continuous grab, cursor motion was mapped to the min/max.
This caused problems when int/float max values were used.
Now the range is clamped by a value derived from the click-step
so dragging numbers never increases it to an impractically large value.
|
|
F2 rename didn't work with mouse input.
|
|
Caused by 828905190e124
|
|
|
|
There was a mix of old and new constants. Now have one list of WM_CURSOR_*
cursor types, using GHOST standard cursors when available and otherwise falling
back to our custom cursors.
Ref D5197
|
|
Was breaking event handling at the wrong place.
|
|
Differential Revision: https://developer.blender.org/D5582
|
|
Without this patch there could only be one superimposed icon
and the operators were hard coded for the button types.
This keeps the previous, sort of predefined extra icons working in a
rather generic way, but allows adding specific ones for specific case
through `UI_but_extra_operator_icon_set()`.
Reviewed by: Campbell Barton
Differential Revision: https://developer.blender.org/D5730
|
|
When the file browser was opened (from a temporary window since the file
browser redesign) using a button in the UI, under certain conditions
moving the mouse would trigger files to be dragged.
Note that this has been an issue before the new file browser design was
introduced, although under slightly different conditions.
Steps to reproduce:
* With factory settings, press F12
* Open a different image in the appearing Image Editor (not Render
Result)
* Make sure the window is not maximized
* Press N to open the side bar, open Image tab
* Click the folder icon there to change the image
* Change to thumbnail display type in the appearing file browser
* Cancel, click the folder icon again
Moving the mouse now would start dragging files in most cases.
The same issue could be reproduced in a similar way when installing
lights/MatCaps or HDRIs through Preferences -> Lights -> Install...
|
|
Used in following commit.
|
|
|
|
The old layout of `PointerRNA` was confusing for historic reasons:
```
typedef struct PointerRNA {
struct {
void *data;
} id;
struct StructRNA *type;
void *data;
} PointerRNA;
```
This patch updates it to:
```
typedef struct PointerRNA {
struct ID *owner_id;
struct StructRNA *type;
void *data;
} PointerRNA;
```
Throughout the code base `id.data` was replaced with `owner_id`.
Furthermore, many explicit pointer type casts were added which
were implicit before. Some type casts to `ID *` were removed.
Reviewers: brecht, campbellbarton
Differential Revision: https://developer.blender.org/D5558
|
|
This was probably introduced in rBfdef1a6712b.
|
|
|
|
|
|
Originally D5020 by @deadpin, refactored to make the change simpler.
|
|
- When no change is performed on a float button, cancel the action.
- Move left/right clicks into the same block.
- Replace ambiguous names: temp, tempf.
|
|
Report that this isn't supported instead, also for unknown key.
|
|
|
|
This reverts commit 77616571292ab1eeb9805797bfdd4525cc306923.
This commit broke overlapping popovers. For example in the color
management tab it would be impossible to select and of the popover
alternatives as it would switch to the menu button under the cursor.
|
|
I'm unable to redo the original report,
Revert fix for T43247..
|
|
Dragging to select another popup now checks the menus active button.
|
|
|
|
|
|
Caused by b708917d94afa
Solve by restricting this change to popovers
instead of other kinds of menus (enums mainly).
|
|
Changing the brush size for example,
was adding redundant undo steps in paint-modes.
For now, don't store undo steps for property changes
in paint & edit modes.
While not ideal, this is similar to 2.7x behavior.
|
|
Popovers created from `UILayout.prop_with_popover` opening on mouse-over.
|
|
|
|
|
|
|
|
Simplifies future changes to dragging checks and avoids
each check for drag using slightly different logic.
|