Welcome to mirror list, hosted at ThFree Co, Russian Federation.

git.blender.org/blender.git - Unnamed repository; edit this file 'description' to name the repository.
summaryrefslogtreecommitdiff
path: root/source/blender/editors/physics/particle_edit.c
AgeCommit message (Collapse)Author
2019-12-19Fix (unreported) hair particle 'Delete Edit' missing children hairPhilipp Oeser
updates in particle editmode Particles themselves were cleared correctly but this was not tagging batch cache dirty. Might move this to a utility function later [since it is used in more places], but that is for after going over some more reports... Reviewers: sergey Differential Revision: https://developer.blender.org/D5925
2019-10-17Cleanup depsgraph access in particle_edit.cPhilipp Oeser
'PE_set_data' / 'PE_set_view3d_data' would give us a depsgraph already, so use it. Also fix access to PEData->depsgraph without calling 'PE_set_data' prior. Addresses concern raised in rBcf2c09002fae. Reviewed By: sergey Differential Revision: https://developer.blender.org/D6067
2019-10-02Revert "UI: use correct singular and plural nouns in report messages"Brecht Van Lommel
Convention is to use (s) postfix for cases where there can be one or multiple, so stay consistent with that. This reverts commit 3e8276311ed17d12e8b47b4fe8e2f68c1ce8c603.
2019-10-01UI: use correct singular and plural nouns in report messagesYevgeny Makarov
Differential Revision: https://developer.blender.org/D5729
2019-09-30Cleanup: spellingCampbell Barton
2019-09-26Cleanup: clang format for particle loop macrosPhilipp Oeser
See https://developer.blender.org/D5903 Reviewers: JacquesLucke
2019-09-26Fix T68645: Hair Particle Edit - Particle Mirror crash when children arePhilipp Oeser
visible in the viewport Seems to be an issue of not correctly freeing the PTCacheEdit (see T68645 for details), after discussion with sergey we went with the quick and dirty fix to free the path cache early for now. Other solution of freeing it in 'psys_cache_paths' for the non-evaluated psys [which would also fix the particle delete, then undo crash from T69000] needs more deep investigation and, possibly, reconsideration. Reviewers: sergey Maniphest Tasks: T68645 Differential Revision: https://developer.blender.org/D5755
2019-09-26Fix T69488: Hair particles: rekey disolves the hair then crashesPhilipp Oeser
Caused by rB914427afd512. Since above commit 'pe_get_current' checks for an active depsgraph. This caused the skipping of handling `PT_CACHE_EDIT_UPDATE_PARTICLE_FROM_EVAL`for everything calling `PE_get_current` (this passes a NULL depsgraph as opposed to `PE_create_current`). So we now pass a depsgraph here as well... Note there are two RNA cases where we pass NULL, namely - rna_ParticleEdit_editable_get - rna_ParticleEdit_hair_get I guess these should be fine though (no functional change to current master) Reviewers: sergey Maniphest Tasks: T69488 Differential Revision: https://developer.blender.org/D5752
2019-09-26Fix T70259: Hair particle point selection if 'use_fade_time' is setPhilipp Oeser
If fade_time is used, particles would be flagged PEK_HIDE (depending on time settings), but since this is not respected in drawing in 2.8 yet the user would have no indication of them keys being hidden. Also doing this for hair doesnt make much sense anyways... Reviewers: jacqueslucke Maniphest Tasks: T70259 Differential Revision: https://developer.blender.org/D5901
2019-09-26Fix particle lasso selecting non-visible keysPhilipp Oeser
Even though hidden/faded keys are not supported in drawing in 2.8 yet, the selection tools should not be able to select non-visible keys. Spotted while looking into T70259 Reviewers: JacquesLucke Differential Revision: https://developer.blender.org/D5902
2019-09-18Fix excessive dependency graph evaluation while painting strokesBrecht Van Lommel
Particularly noticeable when vertex painting with a subsurf modifier. In some cases every sculpt or paint stroke step would evaluate the dependency graph. This should only happen for redraws. Now more selectively choose if the dependency graph should be evaluated to initialize the view context. Doing it in the view context evaluation is somewhat hidden, now it's more explicit. Differential Revision: https://developer.blender.org/D5844
2019-09-18Fix (unreported) missing viewport update deleting a particlePhilipp Oeser
If children hairs were displayed in particle editmode, these would not update when a particle was deleted. Reviewers: sergey Differential Revision: https://developer.blender.org/D5840
2019-09-14Cleanup: use const args, variablesCampbell Barton
2019-09-11Cleanup: typo/spellingPhilipp Oeser
2019-09-10Fix assert hiding selected particlesPhilipp Oeser
was trying to get a boolean with RNA_enum_get (instead of RNA_boolean_get) Spotted while looking into T69680, T69432
2019-09-07Cleanup: use post increment/decrementCampbell Barton
When the result isn't used, prefer post increment/decrement (already used nearly everywhere in Blender).
2019-08-04Cleanup: spellingCampbell Barton
2019-08-02Fix T68122: Settings for Select root and Select tip in particle edit mode ↵Sebastian Parborg
are missing Do not hide the redo window for root/tip select anymore.
2019-07-31Refactor access to dependency graphSergey Sharybin
This change ensures that operators which needs access to evaluated data first makes sure there is a dependency graph. Other accesses to the dependency graph made it more explicit about whether they just need a valid dependency graph pointer or whether they expect the graph to be already evaluated. This replaces OPTYPE_USE_EVAL_DATA which is now removed. Some general rules about usage of accessors: - Drawing is expected to happen from a fully evaluated dependency graph. There is now a function to access it, which will in the future control that dependency graph is actually evaluated. This check is not yet done because there are some things to be taken care about first: for example, post-update hooks might leave scene in a state where something is still tagged for update. - All operators which needs to access evaluated state must use CTX_data_ensure_evaluated_depsgraph(). This function replaces OPTYPE_USE_EVAL_DATA. The call is generally to be done in the very beginning of the operator, prior other logic (unless this is some comprehensive operator which might or might not need access to an evaluated state). This call is never to be used from a loop. If some utility function requires evaluated state of dependency graph the graph is to be passed as an explicit argument. This way it is clear that no evaluation happens in a loop or something like this. - All cases which needs to know dependency graph pointer, but which doesn't want to actually evaluate it can use old-style function CTX_data_depsgraph_pointer(), assuming that underlying code will ensure dependency graph is evaluated prior to accessing it. - The new functions are replacing OPTYPE_USE_EVAL_DATA, so now it is explicit and local about where dependency graph is being ensured. This commit also contains some fixes of wrong usage of evaluation functions on original objects. Ideally should be split out, but in reality with all the APIs being renamed is quite tricky. Fixes T67454: Blender crash on rapid undo and select Speculation here is that sometimes undo and selection operators are sometimes handled in the same event loop iteration, which leaves non-evaluated dependency graph. Fixes T67973: Crash on Fix Deforms operator Fixes T67902: Crash when undo a loop cut Reviewers: brecht Reviewed By: brecht Subscribers: lichtwerk Maniphest Tasks: T67454 Differential Revision: https://developer.blender.org/D5343
2019-07-31Spelling fixes in comments and descriptions, patch by luzpazBrecht Van Lommel
Differential Revision: https://developer.blender.org/D3744
2019-07-31Particle: Cleanup, remove unused depsgraph argumentSergey Sharybin
2019-07-30BLI_task: Cleanup: rename some structs to make them more generic.Bastien Montagne
TLS and Settings can be used by other types of parallel 'for loops', so removing 'Range' from their names. No functional changes expected here.
2019-07-15Fix T66686: Crash on Particle Edit, then RenderSergey Sharybin
Reviewers: brecht, zeddb Reviewed By: brecht Maniphest Tasks: T66686 Differential Revision: https://developer.blender.org/D5259
2019-07-04Fix T63788: Crash if particle system is turned off in particle editing modeSergey Sharybin
Make sure particle system edit never points to a modifier or particle system which becomes inactive. This is needed because copy-on-write will change pointers of them and those pointers are supposed to be restored from particle system evaluation. But since the particle system is disabled it never updates pointers. Reviewers: brecht Reviewed By: brecht Differential Revision: https://developer.blender.org/D5180
2019-06-21Revert "Particle system: Move runtime data to runtime field"Sergey Sharybin
This reverts commit 36faf739a71624b6ca10cec7233779f9eeace0bd. Somewhat annoying but this change had some unforeseen consequences, which lead to an actual bug. Since this change was not sufficient to get original report fixed is easier to simply revert for now. Fixes T65842: Hair disappears when clicking on particle system name
2019-06-13Particle system: Move runtime data to runtime fieldSergey Sharybin
Allows it to be preserved during copy-on-write update when on-geometry related update is needed. This is a required part for T63537, where we need to preserve the entire evaluation data when object is tagged for only RECALC_COPY_ON_WRITE. Reviewers: brecht Reviewed By: brecht Differential Revision: https://developer.blender.org/D5023
2019-05-01ClangFormat: run with ReflowComments on source/Campbell Barton
Prepare for enabling ReflowComments.
2019-04-29Cleanup: comments (long lines) in editorsCampbell Barton
2019-04-22Cleanup: style, use braces for editorsCampbell Barton
2019-04-21Cleanup: comments (long lines) in editorsCampbell Barton
2019-04-18Fix T63590: Blender crashes when deleting particle hair keysSergey Sharybin
2019-04-17ClangFormat: format '#if 0' code in source/Campbell Barton
2019-04-17ClangFormat: apply to source, most of internCampbell Barton
Apply clang format as proposed in T53211. For details on usage and instructions for migrating branches without conflicts, see: https://wiki.blender.org/wiki/Tools/ClangFormat
2019-04-16Fix T63429: Random deselect function lostSebastian Parborg
Add back the ability to choose the select operation for random select. Now we allow the operator to specify if the select operation should be visible in the GUI or not. Reviewed By: Brecht Differential Revision: http://developer.blender.org/D4665
2019-04-16Fix T63646: Box/Lasso select fails to de-selectCampbell Barton
Select 'New' wasn't de-selecting when there was nothing selected in some cases.
2019-04-16Fix T62849: crash entering particle edit mode with hair dynamicsBrecht Van Lommel
2019-04-10Cleanup: spellingCampbell Barton
2019-04-09Fix T62114: Wireframe mode selection: selects backside objects when clicking ↵Sebastian Parborg
frontside object in 3d-window Now the depth order of objects when trying to select them is only used when not in X-ray mode. Before, this was only the case in wireframe mode regardless of X-ray settings. I've also unified the usage of V3D_XRAY and XRAY_FLAG as they were basically copies of each other. Reviewed By: Clément Differential Revision: http://developer.blender.org/D4504
2019-04-02Fix T63120 Select random in particle edit mode is brokenSebastian Parborg
Fix coding snafu where the variable keeping track of changes only took the state of the last element into account.
2019-03-263D View: move deselect all logic into an optionCampbell Barton
This removes `VIEW3D_OT_select_or_deselect_all`, adding a deselect_all option to the `VIEW3D_OT_select` operator. - Add utility functions to simplify de-selecting all. - Return true from selection functions when they change the selection to avoid redundant updates. - Use arrays of bases when passing objects between selection utility functions since some users require bases. - Fix logical error in box selection that updated all objects after the first hit.
2019-03-21Fix T62808: Hair shape cut crashJacques Lucke
Reviewers: sergey Differential Revision: https://developer.blender.org/D4565
2019-03-20Fix missing refresh when subdividing hair strandSergey Sharybin
This is a part of T62730.i
2019-03-19Cleanup: use BLI_kdtree_3d prefixCampbell Barton
Use prefix now there isn't only the 3d version.
2019-03-18Fix T61226: Make hair editing (more?) thread safeJacques Lucke
This replaces the global `PEData->dist` with a thread local variable that is passed into the callback functions separately. There are two new function types which have `Hit` in the name. Those take the distance to the mouse as an additional parameter. Reviewers: sergey Differential Revision: https://developer.blender.org/D4538
2019-03-15GPU: Simplify select shaders.mano-wii
The shaders are: `GPU_SHADER_3D_FLAT_SELECT_ID` and `GPU_SHADER_3D_UNIFORM_SELECT_ID`. This commit allows the drawing of the mesh select ids to be done on a 32UI format texture. This simplifies the shader that previously acted on the backbuffer and had to do an uint to rgba conversion. Differential Revision: https://developer.blender.org/D4350
2019-03-15Cleanup: indentation, wrappingCampbell Barton
Mostly functions wrapping args, not confirming to our style guide.
2019-03-14Fix T62551: Limited Hair editing (no grab, scale, rotate)Sergey Sharybin
This is actually re-introduced T59963 which got broken by 6752022310b. Use less obscure recalc flag now.
2019-03-07Refactor CDData masks, to have one mask per mesh elem type.Bastien Montagne
We already have different storages for cddata of verts, edges etc., 'simply' do the same for the mask flags we use all around Blender code to request some data, or limit some operation to some layers, etc. Reason we need this is that some cddata types (like Normals) are actually shared between verts/polys/loops, and we don’t want to generate clnors everytime we request vnors! As a side note, this also does final fix to T59338, which was the trigger for this patch (need to request computed loop normals for another mesh than evaluated one). Reviewers: brecht, campbellbarton, sergey Differential Revision: https://developer.blender.org/D4407
2019-03-06Missed last commitCampbell Barton
2019-03-06Fix T62223: Particle brushes disable select toolsCampbell Barton
generated by cgit v1.2.3 (git 2.25.1) at 2024-09-10 18:12:47 +0300