Welcome to mirror list, hosted at ThFree Co, Russian Federation.

git.blender.org/blender.git - Unnamed repository; edit this file 'description' to name the repository.
summaryrefslogtreecommitdiff
path: root/source/blender/editors/space_sequencer/sequencer_draw.c
AgeCommit message (Collapse)Author
2021-06-17VSE: Reduce transform code complexityRichard Antalik
Reduce complexity of sequencer transform code by removing recursivity. This is possible by treating meta strips (mostly) as any other strip and containing all transform code within SEQ_ functions. Unfortunately internally meta strips still require special treatment, but all complexity from code all over transform code seems to be possible to contain within one function. Functional change: Previously adjusting handle of single image strip moved animation. Now animation is not moved, which is behavior for all other strips. Reviewed By: sergey, mano-wii Differential Revision: https://developer.blender.org/D11493
2021-06-11Sequencer: Do not redraw during playback.Jeroen Bakker
When using large sequences including audio the drawing of the audio on top of the strip takes a lot of time. This effects the playback performance heavily. During the animation playback performance there was a solution for this by only drawing the playhead overlay. This was reverted for the sequence editor as it didn't update the color strips when they were animated. This patch checks if there are animated color strips if so the full screen is redrawn, otherwise only the playhead is redrawn. Reviewed By: ISS Differential Revision: https://developer.blender.org/D11580
2021-06-06VSE: Remove seq->tmp usage from transform codeRichard Antalik
This field was used for extend feature to get handle position of metastrip children. Since D9972 extend feature works only on meta strip itself, not it's children. So `SEQ_transform_get_left_handle_frame()` second argument is always false and can be removed. Another instance of `seq->tmp usage` is hack to distinguish strips to be shuffled, which is not covered by this patch. Reviewed By: campbellbarton Differential Revision: https://developer.blender.org/D10321
2021-05-12VSE: Fix meta strip boundary can not be changedRichard Antalik
In e1f3996d740c, logic for changing metastrip start and end frame based on contained strips was removed. This was done intentionally and incorrect functionality wasn't noticed as drawing code reflected seemingly correct state. Original code was mostly correct, because meta strip doesn't store its internal start and end points. This code was restored with minor modifications so function `SEQ_time_update_sequence()` is fully self contained as it is used not only by transform operator. In addition, drawing glitches that happen when meta content is outside of meta boundaries were fixed. These glitches were not caused by e1f3996d740c. Reviewed By: sergey Differential Revision: https://developer.blender.org/D11215
2021-05-07Cleanup: make format (clang-format)Dalai Felinto
2021-05-07VSE: Fix freeing display buffer cache before useRichard Antalik
`IMB_display_buffer_release()` was called before `display_buffer` was used by drawing code. This should not be done as it may cause problems.
2021-03-31Cleanup: Remove SEQ_CURRENT_BEGIN macroRichard Antalik
Use LISTBASE_FOREACH instead. SEQ_CURRENT_BEGIN did null checks, so now these must be explicit. Reviewed By: campbellbarton Differential Revision: https://developer.blender.org/D10823
2021-03-23Fix crash transforming sequencesCampbell Barton
Regression in 3d9ee83d88186248fb66823662a04d1a0429e1ae
2021-03-20VSE: Preview images when moving strip handlesPeter Fog
Add option to override current frame whem transforming strip handles. Option can be found in View menu of VSE preview, or in timeline when using backdrop. Reviewed By: ISS Differential Revision: https://developer.blender.org/D10424
2021-03-16VSE: Simplify proxy settingsRichard Antalik
- Remove Full Render size from VSE preview size. Use just 100% instead. - Add Use Proxies checkbox to control whether proxies are used globally - Move preview size to top so it is most prominent - Set default to 100% preview size and use proxies Reviewed By: sergey, fsiddi Differential Revision: https://developer.blender.org/D10362
2021-03-08Cleanup: use ofs instead of offs as an abbreviation for offsetCampbell Barton
Used for local structs/variables, since `ofs` is by far the most widely used abbreviation.
2021-03-01Cleanup: move some drawing code into ed_draw.cChristoph Lendenfeld
Move some drawing code from `area.c` and `ed_util.c` into `ed_draw.c`. This is to support the new generic slider that wil be used in T81785. No functional changes. Reviewed By: #animation_rigging, #user_interface, Severin, sybren Maniphest Tasks: T81785 Differential Revision: https://developer.blender.org/D9313
2021-02-17Cleanup: Abbreviate enums with 'UNSIGNED_' in the nameGermano Cavalcante
2021-01-25Cleanup: pass 'rctf' rectangle to 2D box drawing functionsCampbell Barton
Passing 4x arguments for the rectangle, mixed in with round-box radius & color wasn't very readable. Instead, pass a `rctf` as the first argument to UI box drawing functions.
2021-01-11Cleanup: skip accessing sequence strip name/source when hiddenCampbell Barton
2021-01-11Fix incorrect use of BLI_snprintf in sequencer text concatenationCampbell Barton
The start of the text was stepped over without subtracting it's length (introduced in fad80a95fd08ec87a37f30f0b94a7061d4e382f2). Replace this logic with BLI_string_join_array to simplify construction.
2021-01-11Fix missing directory separator in image/movie strip identifierCampbell Barton
2021-01-11Cleanup: use switch statement for sequence typesCampbell Barton
Also remove duplicate NULL pointer check and replace BLI_snprintf with BLI_strncpy.
2021-01-10Fix T84529: Crash with strip using deleted scenePeter Fog
If scene strip has no scene assigned, leave source string empty. Same goes for all other strips, that use ID datablocks. Reviewed By: ISS Differential Revision: https://developer.blender.org/D10058
2021-01-05Fix T83094: Alternate rows in the Sequencer are green (macOS)Yevgeny Makarov
The issue is that `UI_GetThemeColorBlendShade4fv()` creates a color with alpha, but there is not any background underneath to blend in with. The solution is just to draw an opaque background first, which also halves the number of rects to draw. Note that the brighter rows get very slightly darker after this change. Differential Revision: https://developer.blender.org/D9947
2021-01-04Cleanup: docy comments beginning with '/**' don't end with '**/'Campbell Barton
2020-12-30Fix unreported: Sequencer grid lines are not drawnYevgeny Makarov
By design, there should be lines between the alternating horizontal stripes in the Sequencer. But currently they are all drawn in one place, on top of each other. Mistake in rBfae895125efe. Differential Revision: https://developer.blender.org/D9962
2020-12-20VSE: Remove cost calculation from cacheRichard Antalik
This value was meant to be used for keeping images that are slowest to render in cache. Method of measurement was flawed, because it doesn't take UI overhead into consideration. Cache panel is to be removed because users should not have to tweak settings like this. It is not useful for development either, therefore it is removed completely.
2020-12-19Cleanup: Split SEQ_sequencer.h fileRichard Antalik
2020-12-19Cleanup: Rename BKE_sequencer functionsRichard Antalik
API functions get SEQ_ prefix. Intern functions get seq_ prefix Functions also have appropriate category included in name.
2020-12-17Fix T83869: Crash when creating Sequencer in new sceneRichard Antalik
Crash on null dereference in `SEQ_timeline_boundbox()`. This function was generalized in rB9e4a4c2e996c to work on arbitrary `seqbase`. Fixed by refactoring `SEQ_timeline_boundbox()` functions to return default sane values if `seqbase` is `NULL` Reviewed By: HooglyBoogly Differential Revision: https://developer.blender.org/D9878
2020-12-16Fix warnings introduced in previous commitRichard Antalik
2020-12-16VSE: Add Overlay popover panelsPeter Fog
Add panels with overlay settings for strips and preview and overlay enable/disable button. Entries from the View menus moved to the overlay panels, which will simplify cluttered View menus. Additional options have been added: - Strip Name - Strip Source(ex. path) - Strip Duration So users can now select what info they need to see on the strips. When No text is displayed, waveforms are drawn in full height. Reviewed By: ISS, HooglyBoogly, pablovazquez Differential Revision: https://developer.blender.org/D9751
2020-12-15VSE: Move remove gaps operator logic to module codeRichard Antalik
Logic was broken into finding gaps and ofsetting strips. Functions were modified so they work on explicitly defined seqbase, so they can be used as python API functions. Functional changes: - Improve performance by calculating gap length and offseting strips at once. Previously strips were offset by one frame. - Calculate gap from start frame. Previously gap was considered only inbetween strips. Reviewed By: sergey Differential Revision: https://developer.blender.org/D9730
2020-11-26UI: Allow theming the alternate row color in the sequencerErik Abrahamsson
Previously, the alternate row color in the Video Sequence Editor was just a shaded version of the editor's background color. This makes it theme-able just like in the file browser and outliner, although the default color is very slightly different. Differential Revision: https://developer.blender.org/D9634
2020-11-06Cleanup: rename time related variablesRichard Antalik
Variables renaned: - cfra -> timeline_frame - nr -> frame index - cfra_over -> overlap_frame Function seq_give_stripelem_index was renamed to seq_give_frame_index.
2020-11-06Cleanup: use ELEM macroCampbell Barton
2020-11-05VSE: cache performance optimizationRichard Antalik
Map frame for cached raw images to strip input media frame range. This means that static images or extended frame range of movies will only generate one cache entry. timeline_frame is stored in cache key as a reference - on what frame was this entry created, so we don't have to reverse lookup frame range. Since each media frame corresponds to one cache frame with same frame index key, there is no need to invalidate raw cache when changing time remapping properties like use_reverse_frames or strobe No changes are needed for disk cache, since invalidating raw entry assumes all data will be invalidated. Reviewed By: sergey Differential Revision: https://developer.blender.org/D9462
2020-11-05Rename extern rendering and proxy functionsRichard Antalik
Replace BKE_sequencer wirh SEQ_render or SEQ_proxy prefixes. In cases where function is very generic, only SEQ prefix is used. Reviewed By: sergey Differential Revision: https://developer.blender.org/D9439
2020-11-01Rename BKE_sequencer.hRichard Antalik
Reviewed By: sergey Differential Revision: https://developer.blender.org/D9349
2020-10-19Spelling: It's Versus ItsHarley Acheson
Corrects incorrect usage of contraction for 'it is', when possessive 'its' was required. Differential Revision: https://developer.blender.org/D9250 Reviewed by Campbell Barton
2020-10-14Fix T81004 Python: Images drawn in the Sequence Editor have wrong colorsClément Foucault
This was caused by the sequencer using a sRGB buffer without using the sRGB transform. This patch make it so that the framebuffer is rebound using the sRGB transform before the python draw callbacks.
2020-10-05Rename eSpaceSeq_Proxy_RenderSize membersRichard Antalik
Remove word proxy from eSpaceSeq_Proxy_RenderSize members if proxy is not used with that item. Otherwise this can be a bit confusing. Reviewed By: brecht Differential Revision: https://developer.blender.org/D8861
2020-09-15Fix T80193 Sequencer: Crash on float images when OCIO GLSL shader can't be usedClément Foucault
This was just an oversight from refactoring this code in rBfaeaf5325554e37981424ded5add7bf2df484c55
2020-09-09Cleanup: reduce variable scopeJacques Lucke
2020-09-05GPUTexture: Change texture creation APIClément Foucault
This is to modernize the API: - Add meaningful name to all textures (except DRW textures). - Remove unused err_out argument: only used for offscreen python. - Add mipmap count to creation functions for future changes. - Clarify the data usage in creation functions. This is a cleanup commit, there is no functional change. # Conflicts: # source/blender/gpu/GPU_texture.h
2020-09-05Cleanup: GPUTexture: Remove use of GPU_texture_create_nDClément Foucault
Use creation + update function instead.
2020-09-04Cleanup: Clang-Tidy readability-inconsistent-declaration-parameter-name fixSebastian Parborg
No functional changes
2020-09-04Cleanup: Clang-Tidy bugprone-incorrect-roundings fixesSybren A. Stüvel
Should cause no noticeable difference.
2020-09-02Cleanup: spellingCampbell Barton
2020-09-01Sequencer: Fix crash caused by stereo rendering fixClément Foucault
Caused by rB2e908156d0c7 This was caused by the sequencer timeline area not using a GPUViewport but still using `sequencer_draw_preview`.
2020-08-30Fix T79940 VSE Editor crash when opening a different scene as a stripClément Foucault
This was caused by a double lock of the DRW context mutex. This changes the logic a bit by releasing the DRW context before rendering with BKE_sequencer_give_ibuf and restoring it after. Critical fix for 2.91 Reviewed By: dfelinto Differential Revision: https://developer.blender.org/D8657
2020-08-23Cleanup: GPU: Use explicit clear value in GPU_clear* commandsClément Foucault
This replace `GPU_clear()` by `GPU_clear_color()` and `GPU_clear_depth()`. Since we always set the clear value before clearing, it is unecessary to track the clear color state. Moreover, it makes it clearer what we clear the framebuffer to.
2020-08-21Cleanup: rename iterators over sequences to be more clear about what they do.Bastien Montagne
No functional changes expected.
2020-08-20GPUState: Use explicit depth test enumClément Foucault
generated by cgit v1.2.3 (git 2.25.1) at 2024-07-29 11:03:42 +0300