Welcome to mirror list, hosted at ThFree Co, Russian Federation.

git.blender.org/blender.git - Unnamed repository; edit this file 'description' to name the repository.
summaryrefslogtreecommitdiff
path: root/source/blender/editors/space_sequencer/sequencer_edit.c
AgeCommit message (Collapse)Author
2021-05-19VSE: Better handling of effect strip splittingRichard Antalik
Splitting of effect strip alone wasn't handled properly. Previously this resulted in duplicating effect strip, and it was broken at least from 2.79. Change in rB8ec6b34b8eb2 was intended to allow splitting strips individually, so it can be used as RNA API function but also so it requires as little glue logic as possible. This is fixed by splitting all dependent strips at once in 2 separate ListBases for left and right strips. Strips can be finally moved into original `ListBase`. With this fix it is still possible to split strips individually with little glue logic. RNA API function could return list of split strips as well, currently at least one strip in chain will be provided so chain can be reconstructed on python side. Reviewed By: sergey Differential Revision: https://developer.blender.org/D10209
2021-05-14Cleanup: spelling, rename metas to meta-strips / meta-ballsCampbell Barton
2021-05-06Cleanup: VSE: move functions from incorrect fileRichard Antalik
`SEQ_recursive_apply` and `SEQ_seqbase_recursive_apply` were incorrectly refactored into `iterator.c` file, but they aren't part and don't use sequencer iterator. Functions are moved to `utils.c` file.
2021-04-23VSE: reset strip transform with "Set Render Size" operatorSybren A. Stüvel
Reset the active strip offset and scale, in the "Set Render Size" operator (`SEQUENCER_OT_rendersize`). This ensures that the active strip will actually fit the new render size, which is what the operator is intended to achieve.
2021-04-23Cleanup: VSE, reduce cognitive complexity of sequencer_rendersize_exec()Sybren A. Stüvel
Reduce the cognitive complexity of the `sequencer_rendersize_exec()` function by flipping some conditions and returning early. No functional changes.
2021-04-19Cleanup: use 'wmOperator.ptr' in draw functionsCampbell Barton
Draw functions used RNA_pointer_create to create the pointer, however this already exists in the operator.
2021-04-19Fix creating operator properties without an owner_idCampbell Barton
Any dynamic enum access would not use the callback. Always set the owner_id to avoid this causing problems. Oversight in 919558854d624f5db40acfa9f5674ac8c94873b6
2021-03-31Cleanup: Remove SEQ_CURRENT_BEGIN macroRichard Antalik
Use LISTBASE_FOREACH instead. SEQ_CURRENT_BEGIN did null checks, so now these must be explicit. Reviewed By: campbellbarton Differential Revision: https://developer.blender.org/D10823
2021-03-02VSE: Refactor meta operatorsRichard Antalik
Move low level logic to module code and versioning logic to versioning code. Metas strip position was handled in diffrent way compared to other strips. This was introduced in c8b0d25794be as bugfix for T28158. I disagree with such design. Meta strips should be handled in same way as any other strips. I have tested this change and haven't found any problems. No problems after checking T28158 as well. There should be no functional changes on user level. Reviewed By: campbellbarton Differential Revision: https://developer.blender.org/D9972
2021-02-10Cleanup: remove redundant headers in source/blender/editors/Campbell Barton
Remove redundant headers using `./source/tools/utils_maintenance/code_clean.py` Reviewed By: jmonteath Ref D10364
2021-01-26Fix T84847: Crash after splitting effect stripRichard Antalik
`seq->tmp` was left in invalid state after `SEQ_sequence_base_dupli_recursive()` which is run by `scene_copy_data()` Ensure all strips have `seq->tmp` set to `NULL` before splitting strips.
2021-01-25Fix T84705: Snapping strip handle offset animationOlivier Jolly
Only offset animation if whole strip is snapped. Bug introduced in e36c05b3d191. Reviewed By: ISS Differential Revision: https://developer.blender.org/D10116
2021-01-19Fix T84642: Reassign effect-strip ignores animdataFalk David
When reassigning an effect strip to another sequence, any animation data in the effect strip will not be offset like expected. The fix calls `SEQ_offset_animdata` to offset the animation data after the seqence has been moved. Reviewed By: ISS Maniphest Tasks: T84642 Differential Revision: https://developer.blender.org/D10096
2020-12-31Cleanup: Move functions from sequencer_edit.cRichard Antalik
These are utility functions that are not used in this file. No functional changes.
2020-12-31Cleanup: Remove unused functions from sequencer_edit.cRichard Antalik
No functional changes.
2020-12-24Cleanup: Fix capitalization in various UI stringsYevgeny Makarov
Approximately 195 changes of capitalization to conform to MLA title style. UI labels and property names should use MLA title case, while descriptions should be capitalized like regular prose, generally with only the start of a sentence capitalized. Differential Revision: https://developer.blender.org/D9922
2020-12-19Cleanup: Split SEQ_sequencer.h fileRichard Antalik
2020-12-19Cleanup: Rename BKE_sequencer functionsRichard Antalik
API functions get SEQ_ prefix. Intern functions get seq_ prefix Functions also have appropriate category included in name.
2020-12-16VSE: Improve motion-picture workflowRichard Antalik
This commit resolves problem introduced in e1665c3d3190 - it was difficult to import media at their original resolution. This is done by using original resolution as reference for scale. All crop and strip transform values and their animation is converted form old files. To make both workflows easy to use, sequencer tool settings have been created with preset for preffered scaling method. This setting is in sequencer timeline header and add image or movie strip operator properties. Two new operators have been added: `sequencer.strip_transform_fit` operator with 3 options: Scale To Fit, Scale to Fill and Stretch To Fill. Operator can fail if strip image or video is not loaded currently, this case should be either sanitized or data loaded on demand. `sequencer.strip_transform_clear` operator with 4 options: Clear position, scale, rotation and all (previous 3 options combined). Reviewed By: sergey, fsiddi Differential Revision: https://developer.blender.org/D9582
2020-12-16VSE: Paste strips after playhead by defaultPeter Fog
Paste copied strips after playhead, because this is more intuitive. Previous functionality is still available by enabling "Keep Offset" property, or under shortcut Ctrl+Shift+V. Reviewed By: ISS Differential Revision: https://developer.blender.org/D9734
2020-12-15VSE: Move remove gaps operator logic to module codeRichard Antalik
Logic was broken into finding gaps and ofsetting strips. Functions were modified so they work on explicitly defined seqbase, so they can be used as python API functions. Functional changes: - Improve performance by calculating gap length and offseting strips at once. Previously strips were offset by one frame. - Calculate gap from start frame. Previously gap was considered only inbetween strips. Reviewed By: sergey Differential Revision: https://developer.blender.org/D9730
2020-12-15Fix crash sliding effect sequence stripsCampbell Barton
Off by one error in array access.
2020-11-19Cleanup: refactor sequencer_edit.c fileRichard Antalik
Move RNA enums and utility functions closer to operator definition. No functional changes.
2020-11-19Cleanup: split sequencer_edit.c fileRichard Antalik
Move proxy operator functions to own file. No functional changes.
2020-11-19VSE: Move split operator logic to module codeRichard Antalik
Code was rewritten to work on per-sequence basis returning reference to created strip. There should be no functional changes. Selection logic is left as is for now. I could simplify it, but it belongs to operator, not split logic. Reviewed By: sergey Differential Revision: developer.blender.org/D9592
2020-11-06Cleanup: rename time related variablesRichard Antalik
Variables renaned: - cfra -> timeline_frame - nr -> frame index - cfra_over -> overlap_frame Function seq_give_stripelem_index was renamed to seq_give_frame_index.
2020-11-06Cleanup: use ELEM macroCampbell Barton
2020-11-05Rename extern rendering and proxy functionsRichard Antalik
Replace BKE_sequencer wirh SEQ_render or SEQ_proxy prefixes. In cases where function is very generic, only SEQ prefix is used. Reviewed By: sergey Differential Revision: https://developer.blender.org/D9439
2020-11-03Fix C operators can't set default display or sort type for File BrowserJulian Eisel
`WM_operator_properties_filesel()` allows C operators to set a display or sort type for the File Browser to use. But the File Browser would always override that because of an invalid `_is_set()` check. (The operators don't actually set the value, they only set the property's default value.) The only operator affected by this is "Recover Auto Save". It is supposed to show a vertical list ordered chronologically. It used settings from the previous File Browser usage before this patch. Operators using the File Browser should generally use `FILE_DEFAULTDISPLAY`/`FILE_SORT_DEFAULT` now, except if they have a reason not to. See comments at their definition. ---- This makes it so operators that set a different display or sort type don't change the sort or display type for the next File Browser operation. So using "Recover Auto Save" entirely isolates display and sort type from other operations. Differential Revision: https://developer.blender.org/D8598 Reviewed by: Bastien Montagne
2020-11-01Rename BKE_sequencer.hRichard Antalik
Reviewed By: sergey Differential Revision: https://developer.blender.org/D9349
2020-10-24UI: Capitalization CorrectionsYevgeny Makarov
Approximately 141 changes of capitalization to conform to MLA title style. Differential Revision: https://developer.blender.org/D8392 Reviewed by Julian Eisel
2020-10-17Fix T81594: Unable to reassign effect inputsRichard Antalik
This was caused by canceling operator if strip has more than 0 inputs. Logic should be reversed - cancel only if strip has 0 inputs. BKE_sequencer_render_loop_check() arguments had to be sanitized because seq_effect_find_selected() can set seq1,2,3 to NULL Reviewed By: sergey Differential Revision: https://developer.blender.org/D9197
2020-09-09Cleanup: reduce variable scopeJacques Lucke
2020-08-26Cleanup: add SEQ_ALL_BEGIN, SEQ_CURRENT_BEGIN to .clang-formatCampbell Barton
These were missed in 70500121b457d which caused reformatting.
2020-08-23Fix T79872: VSE - splitting strip shows the channel number when unusedPhilipp Oeser
This operator is dependent on mouse position (if the Use Cursor Position option is used). The Channel property is irrelevant/unused in this case. So it is not optimal displaying this property when calling this from the menu (or even using the shortcut with default settings). Now use a custom UI in the Adjust Last Operation panel in this case. The properties are now drawn in relation to another then (Channel underneath Use Cursor Position) next to some other minor layout improvements. Thx @HooglyBoogly for feedback (also providing UI code) Maniphest Tasks: T79872 Differential Revision: https://developer.blender.org/D8625
2020-08-21Cleanup: rename iterators over sequences to be more clear about what they do.Bastien Montagne
No functional changes expected.
2020-08-17Merge branch 'blender-v2.90-release'Richard Antalik
2020-08-17Fix T79757: Crash on prefetch when renaming stripsRichard Antalik
Original sequence lookup failed, becase name changed in another thread. Fix is same as 0471349c90df - stop prefetching before changing content of seqbase. I have covered more cases, and added assert so it is more obvious that issue is in lookup, and it shouldn't fail. Reviewed By: sergey Differential Revision: https://developer.blender.org/D8592
2020-08-05Fix T79497: Crash when removing strips with prefetchingRichard Antalik
This was already fixed by 0471349c90df but accidentally removed in refactor.
2020-08-04Merge branch 'blender-v2.90-release'Bastien Montagne
Conflicts: source/blender/editors/gpencil/gpencil_primitive.c
2020-08-04Cleanup: typos & co in UI messages (and some other places).Bastien Montagne
2020-08-02Merge branch 'blender-v2.90-release'Richard Antalik
2020-08-02Fix T66805: No cache invalidation with remove gaps operatorRichard Antalik
Reviewed By: brecht Differential Revision: https://developer.blender.org/D8379
2020-08-01Cleanup: spellingCampbell Barton
2020-07-31Merge branch 'blender-v2.90-release'Sergey Sharybin
2020-07-31Sequencer: Ensure UUIDs are updated when neededSergey Sharybin
Document cases where it seems that they need to be updated, but where the proper behavior is to not update the UUID.
2020-07-30Merge branch 'blender-v2.90-release'Philipp Oeser
2020-07-30Fix T79357: VSE crash on prefetching when performing cutsPhilipp Oeser
Caused by {rBa1a333a1e92e} `BKE_sequencer_prefetch_get_original_sequence` cant get a sequence in `BKE_sequencer_cache_put`. rBa1a333a1e92e moved multiple NULL checks (including the one checking seq) above BKE_sequencer_prefetch_get_original_sequence (this should never return NULL really, but this is for another fix). So solution suggested by @ISS is to just stop prefetching all together before changing content of seqbase. Maniphest Tasks: T79357 Differential Revision: https://developer.blender.org/D8421
2020-07-26VSE: Refactor delete operator and APIRichard Antalik
Operator logic is limited to iterating over selection and executing same code as python API does. Functional changes: - No attempt to preserve effects is made. Dependant effects are deleted. - No attempt to change meta strip boundaries. Partially fixes T73828 Reviewed By: campbellbarton Differential Revision: https://developer.blender.org/D6892
2020-07-26Fix T74958: Infinite loop on using strip as modifier maskRichard Antalik
Add recursion check before assigning strip as a mask for modifier. Same check is used for recursion check when reassigning effect input, so it should not be possible to create recursion at all.
generated by cgit v1.2.3 (git 2.25.1) at 2024-08-07 11:44:06 +0300