Welcome to mirror list, hosted at ThFree Co, Russian Federation.

git.blender.org/blender.git - Unnamed repository; edit this file 'description' to name the repository.
summaryrefslogtreecommitdiff
AgeCommit message (Collapse)Author
2020-04-06Fix T74602: Sequencer slip operator ignores offset constraintsRichard Antalik
Limit offsets, so each strip contains at least 1 frame of content. Reviewed By: campbellbarton Differential Revision: https://developer.blender.org/D7288
2020-04-06Cleanup: Fix comment style and check if they are valid or make sense.Richard Antalik
2020-04-06Cleanup: Use `_fn` as a suffix for callbacks in VSE codeRichard Antalik
2020-04-03Code Quality: Replace for loops with LISTBASE_FOREACHDalai Felinto
Note this only changes cases where the variable was declared inside the for loop. To handle it outside as well is a different challenge. Differential Revision: https://developer.blender.org/D7320
2020-04-03Cleanup: Rename bScreen variables from sc/scr to screenJulian Eisel
Part of T74432. Mostly a careful batch rename but had to do few smaller fixes. Also ran clang-format on affected files.
2020-04-03Cleanup: Rename ScrArea variables from sa to areaJulian Eisel
Follow up of b2ee1770d4c3 and 10c2254d412d, part of T74432. Now the area and region naming conventions should be less confusing. Mostly a careful batch rename but had to do few smaller fixes. Also ran clang-format on affected files.
2020-03-31Cleanup: use '_recursive' suffix instead of '_rec'Campbell Barton
This convention isn't very clear and wasn't used much. Use the more verbose term instead.
2020-03-25Cleanup: use 'r_' prefix for output argumentsCampbell Barton
Also pass some args as 'const'.
2020-03-19Cleanup: `make format` after SortedIncludes changeDalai Felinto
2020-03-19VSE: Strip drawing improvementsRichard Antalik
This patch include changes: - Thicker and clearer selection indication - Slimmer handles - More transparent muted strips - Trim frame number is drawn inside the strip - Strip text is drawn in upper part of strip - Color strips now have specific color, with chosen color drawn under strip text - Transition strip will use color of input strips showing direction of transition - Selecting effect strip will highlight input strips - Selecting multicam strips will highlight target channel - Missing media state is now indicated by a red line drawn on the top part of the strip - A checkerboard pattern is now drawn on the outsides of the meta range - Hold still regions are now always drawn if existent, with a darker shade of the strip’s background color Author: Alessio Monti di Sopra <a.monti> Reviewed By: ISS Differential Revision: https://developer.blender.org/D6883
2020-03-18Cleanup: Resolve HKEY conflictRay Molenkamp
Both the MS headers and blender headers define the HKEY which gives all kind of inclusion order issues. This diff renames all *KEY constants to EVT_*KEY to resolve this conflict. Reviewed By: brecht , dfelinto Differential Revision: http://developer.blender.org/D7164
2020-03-10Fix sequencer Slip tool skipping offset=0 caseCampbell Barton
The slip tool wasn't being applied when the offset was zero. This caused modal operation to skip applying this offset while dragging.
2020-03-10Cleanup: replace term 'terrible' from sequence slipCampbell Barton
Joke from branch name, makes comments unclear.
2020-03-09UI: rename View Frame to Go to Current Frame in video sequencerEitan
For consistency with other editors. Differential Revision: https://developer.blender.org/D7025
2020-03-06Cleanup: Rename ARegion variables from ar to regionJulian Eisel
The old convention was easy to confuse with ScrArea. Part of https://developer.blender.org/T74432. This is mostly a batch rename with some manual fixing. Only single word variable names are changed, no prefixed/suffixed names. Brecht van Lommel and Campbell Barton both gave me a green light for this convention change. Also ran clan clang format on affected files.
2020-03-04UI: rename View Selected" to "Frame Selected"Asad-ullah Khan
Addresses T74331
2020-02-17Fix T68749: BPY: Deprecate height of popupJeroen Bakker
`invoke_props_dialog` and `invoke_popup` had a width and a height field. The height field was ignored as the height is determined based on the content. This change removes the field from the BPY + WM_api Reviewed By: Campbell Barton, Jacques Lucke Differential Revision: https://developer.blender.org/D6694
2020-02-16Rename Sequencer 'Cut' to 'Split'William Reynish
This avoids the ambiguity with the Cut operator in the Sequencer, which could be confused with Cut/Copy/Paste. Use 'Split' for the operator and 'Blade' for the active tool. Patch by Nathan Lovato, with edits Differential Revision: https://developer.blender.org/D5542
2020-02-10Cleanup/refactor: Rename `BKE_library` files to `BKE_lib`.Bastien Montagne
Note that `BKE_library.h`/`library.c` were renamed to `BKE_lib_id.h`/`lib_id.c` to avoid having a too generic name here. Part of T72604.
2020-01-22VSE: Tool system integrationRichard Antalik
Add toolbar to sequencer regions. A bit of refactoring has to be done in RNA space. Currently there is only cut tool implemented to serve as template for anybody who would like to add more.
2020-01-22VSE: Add Adjust Last Operation panel to the video sequencerRichard Antalik
Add Adjust Last Operation panel to Sequencer. `OPTYPE_REGISTER` was removed form some operators and few properties were hidden So they don't show up on the panel Author: a.monti Reviewed By: ISS Differential Revision: http://developer.blender.org/D6210
2019-11-18WM: remove view operators from the undo stackAlessio Monti di Sopra
2019-11-03Fix errors in fix for T68018Campbell Barton
2019-11-03VSE: add a Set frame range to Strips operatorAlessio Monti di Sopra
Add operator that sets the frame range, with an option to choose the regular or the preview one, around the selected strips. Reviewed By: ISS Differential Revision: https://developer.blender.org/D6078
2019-11-03Fix T68018: Crash on building movie proxyRichard Antalik
Skip building proxy if directory can not be created. Crash happens, when setting custom dir to location of source file itself. This results in attempt to create directory with the same name as source file. Differential Revision: https://developer.blender.org/D6148 Reviewed By: sergey
2019-10-08Fix T70626: VSE: Slip Strip Operator doesn't refresh audio on confirmPhilipp Oeser
Maniphest Tasks: T70626 Reviewed By: ISS, sergey Differential Revision: https://developer.blender.org/D6016
2019-09-30Fix T69334: VSE Very low framerateRichard Antalik
Revert "Sequencer: use Alpha Over blend mode by default" This reverts commit 7c6c5b40cae47e2ecb0e2ef2a5ca1883270c0023. Reviewed By: brecht Differential Revision: https://developer.blender.org/D5943
2019-08-24UI: Various tooltip corrections and fixesWilliam Reynish
Patch by Yevgeny Makarov (jenkm) Differential Revision: D5514
2019-08-01VSE: Use sequencer boundbox for view_all operatorRichard Antalik
Fix T67279 Fix T59954 Reviewed By: brecht Differential Revision: https://developer.blender.org/D5368
2019-08-01Fix T66028: Move sequence, movieclip and text editor progressbars to status barRichard Antalik
Reviewed By: brecht Differential Revision: https://developer.blender.org/D5219
2019-08-01Fix T68036: VSE: 'Remove Gaps' causes audio to go out of syncPhilipp Oeser
Reviewers: sergey Maniphest Tasks: T68036 Differential Revision: https://developer.blender.org/D5391
2019-07-31Refactor access to dependency graphSergey Sharybin
This change ensures that operators which needs access to evaluated data first makes sure there is a dependency graph. Other accesses to the dependency graph made it more explicit about whether they just need a valid dependency graph pointer or whether they expect the graph to be already evaluated. This replaces OPTYPE_USE_EVAL_DATA which is now removed. Some general rules about usage of accessors: - Drawing is expected to happen from a fully evaluated dependency graph. There is now a function to access it, which will in the future control that dependency graph is actually evaluated. This check is not yet done because there are some things to be taken care about first: for example, post-update hooks might leave scene in a state where something is still tagged for update. - All operators which needs to access evaluated state must use CTX_data_ensure_evaluated_depsgraph(). This function replaces OPTYPE_USE_EVAL_DATA. The call is generally to be done in the very beginning of the operator, prior other logic (unless this is some comprehensive operator which might or might not need access to an evaluated state). This call is never to be used from a loop. If some utility function requires evaluated state of dependency graph the graph is to be passed as an explicit argument. This way it is clear that no evaluation happens in a loop or something like this. - All cases which needs to know dependency graph pointer, but which doesn't want to actually evaluate it can use old-style function CTX_data_depsgraph_pointer(), assuming that underlying code will ensure dependency graph is evaluated prior to accessing it. - The new functions are replacing OPTYPE_USE_EVAL_DATA, so now it is explicit and local about where dependency graph is being ensured. This commit also contains some fixes of wrong usage of evaluation functions on original objects. Ideally should be split out, but in reality with all the APIs being renamed is quite tricky. Fixes T67454: Blender crash on rapid undo and select Speculation here is that sometimes undo and selection operators are sometimes handled in the same event loop iteration, which leaves non-evaluated dependency graph. Fixes T67973: Crash on Fix Deforms operator Fixes T67902: Crash when undo a loop cut Reviewers: brecht Reviewed By: brecht Subscribers: lichtwerk Maniphest Tasks: T67454 Differential Revision: https://developer.blender.org/D5343
2019-07-31Spelling fixes in comments and descriptions, patch by luzpazBrecht Van Lommel
Differential Revision: https://developer.blender.org/D3744
2019-06-28Fix audio not updating when snapping strips in sequencerSergey Sharybin
2019-06-14Fix T65814: Copy pasting audio strip from video crash BlenderSergey Sharybin
2019-06-12Cleanup: spelling in commentsCampbell Barton
2019-06-11Fix/Cleanup: I18N: Bad usage of IFACE_ instead of TIP_.Bastien Montagne
Cheap tip: anything that is not "Camel Case" and/or that is more than a few words long should use `TIP_` translation, not `IFACE_` one. Also added several missing strings (including the one reported in D5056 by Jean First (@robbott), thanks).
2019-06-11Sound: Fix queries of sound infoSergey Sharybin
A lot of areas were querying sound information directly using audio handle which does not exist on an original sound IDs. This change basically makes it so it's possible to query information about given sound ID, without worrying about whether it's loaded or not: if it is needed to load it first it happens automatically (no automatically-opened handles are left behind though). While this seems a bit extreme to open files on such queries it is still better than the old situation when all sound handles were opened on file load, no matter if it's needed or not. Besides, none of the changed code paths are performance critical, just handful of tools. Fixes T65696: Sequencer fails to create a new sound sequence strip via Python Fixes T65656: Audio strip - SHIFT K crashes Blender Reviewers: brecht Reviewed By: brecht Subscribers: ISS Maniphest Tasks: T65696, T65656 Differential Revision: https://developer.blender.org/D5061
2019-06-11Fix T65715: Instant crash when grouping strips in VSESergey Sharybin
2019-06-07Sequencer: Fix missing sound from nested scene stripsSergey Sharybin
2019-06-07VSE: Cache invalidationRichard Antalik
Add invalidation to strip add functions Add invalidation for scene and movieclip strips Skip invalidation for sound strips Reviewed By: brecht Differential Revision: https://developer.blender.org/D4989
2019-06-05Sound: Port to a copy-on-write conceptSergey Sharybin
This change makes it so sound handles are created for evaluated scene, sequencer and speakers. This allows to have properly evaluated animation on them. For the viewport playback sound uses regular dependency graph. For the final render sound uses dependency graph created for render pipeline, which now also contains sequencer and sound datablocks. All the direct sound update calls are replaced with corresponding dependency graph recalc tag.
2019-05-31Cleanup: style, use braces in source/ (include disabled blocks)Campbell Barton
2019-05-31VSE: don't add crop and transform data for sound stripsRichard Antalik
This also fixes commit rB1fd7b380f4cf8a0489b405de2819f228a4da5ea2 which didn't do allocation for effect strips properly. Reviewed By: brecht, campbellbarton Differential Revision: https://developer.blender.org/D4970
2019-05-29Sequencer: Fix box select using incorrect rectangles for sequencesJacques Lucke
Reviewer: ISS Differential Revision: https://developer.blender.org/D4968
2019-05-23VSE: minimal cache invalidationRichard Antalik
2019-05-18UI: Sequencer menusWilliam Reynish
Add missing menu entries: - Select Box - Sound Crossfade - Toggle Meta - Gap Remove Also: - Rename menu entries to use Playhead rather than the ambiguous Frame - Use icons for the rest of the Add menu categories Thanks to user tintwotin for pointing out the missing items
2019-05-07Sound: Revert all the recent changes to soundSergey Sharybin
This happened to be a bigger rabbit hole to hell than it originally seemed, and there are higher priority design tasks to be handled (at this point high priority design task is more important than high priority bug fix). After talking to Brecht the decision was made to revert to the known isolated issue, which will allow everyone in the studio work same as prior to last Friday. The remaining bits will be worked on after all the design tasks are out of the way. This commit reverts: 4cdb4b9532c Fix T64161: Crashing using undo and multiple windows 064273a4ae7 Sound: Port more cases to be a part of dependency graph 2e582f8ab53 Sound: Fix access wrong dependency graph 5fc49d9c915 Sound: add stubs to build without audaspace c68c81a870b Sound: Make sure spin lock is initialized for new sound datablocks c02534469ac Sound: Delay creating sound scene handle for until is needed 9f681bea68f Fix T64144: Crash when displaying audio waveforms in VSE 2f79286453e Cleanup: unused vars bed8ad6f95a Fix crash in background rendering after recent sound changes 773691310f9 Fix T64143: Crash when scrubbing in the graph editor 888852055c1 Sound: Fix for being unable to jump to a frame during playback with A/V sync 6ab7b384645 Sound: More fixes for access of original scene 35db1195455 Sound: Fix access original scene during playback 211c4fd2e9a Depsgraph: Make comment about evaluation more obvious c5fe16e121e Sound: Make sound handles only be in evaluated datablocks b4e1e0946bf Depsgraph: Preserve sound and audio pointers through copy-on-write 4eedf784b04 Depsgraph: Store original sequencer strip pointer 6990ef151c1 Sound: Move evaluation to dependency graph d02da8de23b Sound: Delay opening handlers for until really needed 3369b828916 Depsgraph: Add scene audio component e8f10d64757 Depsgraph: Tag sequencer for update on changes 6e4b7a6e4d9 Depsgraph: Initial work to cover sequencer 17447ac5a6b Depsgraph: Make sound ID part of the graph
2019-05-06Sound: Port more cases to be a part of dependency graphSergey Sharybin
Mainly covers RNA callbacks which were still doing direct scene update, which was causing crashes. Now corresponding ID_RECALC flags are used, so all scenes can update accordingly. Also tested animated volume/pitch on strips, which now works as well. Fixes T64133: Assert after changing FPS Fixes T64154: Immediate crash when changing the current frame on the timeline Fixes T64185: Client Crashes when the frame position value is changed Fixes T64190: Blender Crash using Timeline Editor Fixes T64128: Click to close bug type on timeline Fixes T64147: Crash when setting current frame from Python Fixes T64152: Blender Auto-Close on timeline change
2019-05-03Depsgraph: Tag sequencer for update on changesSergey Sharybin
Currently only adding, removing and transforming strips. Most likely more tags is needed.