Welcome to mirror list, hosted at ThFree Co, Russian Federation.

git.blender.org/blender.git - Unnamed repository; edit this file 'description' to name the repository.
summaryrefslogtreecommitdiff
path: root/source
AgeCommit message (Collapse)Author
2020-10-02Fix T81200: Crash on certain armature select operators when OpenGL DepthPhilipp Oeser
Picking is disabled Affected were (at least) - Select Linked pick - Select Shortest Path Was originally caused by rB8b347fc2cdc6 [which got improved in rBfc8a7a44b200 - but only partially]. After removal of BONESEL_NOSEL we have to filter out -1 from the hits for any bone picking it seems (since armature drawing uses this). In rBfc8a7a44b200, this was done for 'ED_armature_edit_select_pick' (or 'get_nearest_editbonepoint' precisely), now do this for 'ed_armature_pick_bone_impl' as well. Reviewers: campbellbarton Maniphest Tasks: T81200 Differential Revision: https://developer.blender.org/D9080
2020-10-02UI: Improve UV sticky select mode descriptionHans Goudey
The sticky_select_mode property is an enum where each item has a different behavior, but currently the description is for a single one of the items. It should be more general, especially because one of the items is "Disabled." A couple more problems: - "Automatically" is not so helpful. Many things any program does are "automatic", it doesn't really help to say it. - "Also" is bad grammar. - Overly complex wording This also adjusts the SHARED_VERTEX tooltip, because "irrespective" should have "of" after, but it's also unecessarily complex. Differential Revision: https://developer.blender.org/D9049
2020-10-02Cleanup: Refactor `ed_screen_context()` to use hash lookupsSybren A. Stüvel
Refactor `ed_screen_context()` to use `GHash` lookups instead of a sequence of string comparisons. This should provide a nice speedup, given that the hash for `member` only has to be computed once instead of matching it to each possible string. Reviwed by: brecht Differential Revision: https://developer.blender.org/D9090
2020-10-02Cleanup: split up `ed_screen_context()` into separate functionsSybren A. Stüvel
Refactor `ed_screen_context()` to call separate functions, instead of having the entire functionality in one function. Each function now only retrieves the data it needs from the context. Furthermore, some string comparisons are removed. No functional changes. Reviwed by: brecht Differential Revision: https://developer.blender.org/D9090
2020-10-02Volumes: make Mesh to Volume modifier independent of object transformsJacques Lucke
2020-10-02Experimental Features: More robust way of sanitizing optionsDalai Felinto
2020-10-02Experimental Features: Sanitize missing (latest) optionsDalai Felinto
There was an oversight when adding new experimental user preferences. I can try to overengineer this later to make it more fail-proof. But for now it should be clear what to update when adding a new variable.
2020-10-02Experimental Features: Rename Image editor optionDalai Felinto
This prevents having multiple UI strings starting exactly the same: * Legacy A... * Legacy B ...
2020-10-02CleanUp: Remove header only definitionJeroen Bakker
node_draw_link_straight existed in header files without a body
2020-10-02Cleanup: reduce variable scopesJacques Lucke
2020-10-02Cleanup: remove redundant theme versioningCampbell Barton
All themes older than 2.8x are initialized from the defaults, there is no need to version them.
2020-10-02Cleanup: spellingCampbell Barton
Also correct own correction from 58b8724a4892 thanks @mont29 for raising this.
2020-10-02Fix userpref.blend using version from startup.blendCampbell Barton
Version patching userpref.blend wasn't using the correct version, causing settings not to be properly updated. This seems the likely cause of T70196 and similar bugs.
2020-10-02Fix (unreported) assert in texture code when loading some old 2.74 blend file.Bastien Montagne
Trying to open the 2.74 Fishy Cat file would generate endless asserts in customdata code. This commit refactors and cleans up the code of `psys_get_dupli_texture` to avoid useless calls and data access, and validate data before trying to further access it. No behavioral changes expected here (besides getting rid of the assert).
2020-10-02Cleanup: readfile for workspaces: NULLify non-owned data pointers.Bastien Montagne
`workspace_hook` of wmWindows store pointers for runtime data and to data belonging to other IDs (workspace's layouts). That kind of pointers should always be cleaned up on read, it allows for cleaner segfault crash in case of mistakes in code updating/re-setting them, and avoids potential security issue of accessing random memory address. No behavioral change expected here.
2020-10-02Fix (unreported) design flow in how workspace's relation data are read from ↵Bastien Montagne
.blend file. Relying on pointer addresses across different data-blocks is extremely not recommended (and should be strictly forbidden ideally), in particular in direct_link step of blend file reading. - It assumes a specific order in reading of data, which is not ensured in future, and is in any case a very bad, non explicit, hidden dependency on behaviors of other parts of the codebase. - It is intrinsically unsafe (as in, it makes writing bad code and making mistakes easy, see e.g. fix in rB84b3f6e049b35f9). - It makes advanced handling of data-blocks harder (thinking about partial undo code e.g., even though in this specific case it was not an issue as we do not re-read neither windowmanagers nor worspaces during undo). New code uses windows' `winid` instead as 'anchor' to find again proper workspace hook in windows at read time. As a bonus, it will also cleanup the list of relations from any invalid ones (afaict it was never done previously). Differential Revision: https://developer.blender.org/D9073
2020-10-02CleanUp: snode_group_offset -> space_node_group_offsetJeroen Bakker
2020-10-02CleanUp: Renamed drawnodespace -> node_draw_spaceJeroen Bakker
2020-10-02Fix text editor auto-complete refinement featureCampbell Barton
Left/right arrow keys can refine the completion, this wasn't redrawing and there was an off-by-one error checking the next character.
2020-10-02Fix text editor auto-complete mouse interactionCampbell Barton
- Remove MMB for activating an auto-complete item (use LMB instead). - Update on cursor motion.
2020-10-02Cleanup: pep8 (indentation, spacing, long lines)Campbell Barton
2020-10-02Cleanup: trailing spaceCampbell Barton
2020-10-02Cleanup: compiler warningsCampbell Barton
2020-10-01Fix warnings in cloth brush int castsPablo Dobarro
Use POINTER_AS_INT instead Reviewed By: HooglyBoogly Differential Revision: https://developer.blender.org/D9083
2020-10-01Cleanup: Use DNA defaults for cloth modifierHans Goudey
Followup for rB8398050695 This requires moving a few enum definitions to DNA instead of BKE, and adding default definitions for the two structs the cloth modifier where the cloth modifier stores its settings. The defaults are also reordered to be consistent with the order of each item in the struct.
2020-10-01Cleanup: Clang tidy fixesHans Goudey
Fix a redundant return statement at the end of void function and an inconsistent declaration parameter names.
2020-10-01Fix T80873: Grab active vertex preview not working with shape keysPablo Dobarro
When a Shape Key is active, use the PBVH deformed coordinates for the preview. Reviewed By: sergey Maniphest Tasks: T80873 Differential Revision: https://developer.blender.org/D8921
2020-10-01Fix T81268: Crash when undo from Sculpt Mode to Edit ModePablo Dobarro
This was introduced in 6c9ec1c893f9. The overlays can now be drawn when PBVH drawing is not enabled, but the PBVH should still exist in the SculptSession in order to draw them. Before, it was avoiding the crash by checking use_pbvh as BKE_sculptsession_use_pbvh_draw also checks if the PBVH exists. Reviewed By: sergey Maniphest Tasks: T81268 Differential Revision: https://developer.blender.org/D9044
2020-10-01Paint: Ignore inbetween events for anchored strokesPablo Dobarro
When using anchored strokes, inbetween events are not needed since there is no stroke path to be reconstructed. Handling the inbewteen events are only producing unnecessary updates, creating performance issues. Reviewed By: sergey, brecht Differential Revision: https://developer.blender.org/D9053
2020-10-01Sculpt: Cloth Simulation Dynamic area modePablo Dobarro
This simulation area mode moves the active area with the brush. When enabled, the cloth brush has no restrictions on stroke length, area or mesh vertex count. In order to work, this enables PBVH nodes dynamically for simulation as the stroke location moves and builds the constraints for new nodes during the stroke. When a node is not inside the simulated area, all the constraints that were created for it and vertex collisions are not computed. The simulation limits falloff areas and constraints tweaking control how the simulated and no simulated nodes blend. Reviewed By: sergey, zeddb Differential Revision: https://developer.blender.org/D8726
2020-10-01Cleanup: typo in commentPhilipp Oeser
2020-10-01remove foreachObjectLink callbackJacques Lucke
This removes `foreachObjectLink` from `ModifierTypeInfo`, `GpencilModifierTypeInfo` and `ShaderFxTypeInfo`. There is no need to have both, `foreachObjectLink` and `foreachIDLink`. There is not code that actually depends on `foreachObjectLink`. Reviewers: brecht Differential Revision: https://developer.blender.org/D9078
2020-10-01Volumes: support lower resolution in viewportJacques Lucke
The adds a new option to simplify volumes in the viewport. The setting can be found in the Simplify panel in the render properties. Volume objects use OpenVDB grids, which are sparse. For rendering, we have to convert sparse grids to dense grids (for now). Those require significantly more memory. Therefore, it's often a good idea to reduce the resolution of volumes in the viewport. Reviewers: brecht Differential Revision: https://developer.blender.org/D9040 Ref T73201.
2020-10-01Fix subdivision surface wrong for non-limit surface and subdivision level 1Brecht Van Lommel
Remove the workaround for T59395 that increases the minimal refinement to 2 to work around an OpenSubdiv bug. This bug appears to be fixed in the latest OpenSubdiv version we are using. Problem found by Piotr Ostrowski. Ref D9076
2020-10-01Cleanup: make texture coordinates constJacques Lucke
2020-10-01Use DNA defaults system for modifiersHans Goudey
As noted in T80164, there are quite a few area of Blender where the "Reset to Default Value" operator in button context menus doesn't work. Modifiers are one of them, because the DNA defaults system was never set up for them. Additionally, this should make modifier versioning easier. Whenever a new field is added it should be automatically initialized to the default value. I had to make some ordering changes in the following modifiers to work around an error with `-Wsign-conversion` in the macros: - Solidify Modifier - Corrective Smooth Modifier - Screw Modifier Some modifiers are special cases and are skipped in this commit: - Data Transfer Modifier - Cloth Modifier - Fluid Modifier - Softbody Modifier Differential Revision: https://developer.blender.org/D8747
2020-10-01Cleanup: Remove unused variableHans Goudey
2020-10-01Fix: Mesh to Volume modifier crashes when object is in edit modeJacques Lucke
Bug and fix has been found by dfelinto, thanks.
2020-10-01Volumes: copy display settings in BKE_volume_new_for_evalJacques Lucke
2020-10-01Fix T81248: World nodetree action is linked after duplicationPhilipp Oeser
This was already changed for Material nodetrees on duplication in rBa75ac18638f4. Since it is not obvious from the UI how change World actions - and to be consistent with Material actions, it is best to copy the action as the default behavior. So use generic BKE_id_copy functions with LIB_ID_COPY_ACTIONS flag [which also enables us to get rid of `BKE_world_copy`] Note: taking the User Preference `USER_DUP_ACT` into account here (for both material and world actions) could be a followup step. Maniphest Tasks: T81248 Differential Revision: https://developer.blender.org/D9046
2020-10-01Fix T81267: bad handling of usercount for actions duplicated with some animdata.Bastien Montagne
Those actions are full proper IDs and should therefore not be affected by flags used to duplicate 'owner' ID own data.
2020-10-01Cleanup: clang-formatBrecht Van Lommel
2020-10-01Fx several issues with Outliner's collection editing re linked/override.Bastien Montagne
Most collection operations should not be allowed when either the scene or the parent collection are linked or liboverrides. This commit adds more stricter checks in both polling and execution aspects of several related operators. Fix T81282: Crash on instance to scene of a collection of a linked scene.
2020-10-01Fix some inactive modifier properties not being editableBrecht Van Lommel
The convention is to keep inactive settings editable even if they are grayed out for having no effect due to other settings.
2020-10-01Windows: workaround to make Windows Ink tablet API workNicholas Rishel
Now Wintab is not initialized when starting Blender with the tablet API preference set to native, since that disables Windows Ink. Note that changing the tablet API requires restarting Blender for changes to take effect. This serves as a stopgap to allow use of Windows Ink until runtime API switching is merged. Differential Revision: https://developer.blender.org/D9051
2020-10-01Fix T81340: UBSan: addition of unsigned offset causes overflowAnkit Meel
The warning: runtime error: addition of unsigned offset to 0x61a0000b22d8 overflowed to 0x61a0000b22b8 Fix T81340 (partially) Reviewed By: campbellbarton Maniphest Tasks: T81340 Differential Revision: https://developer.blender.org/D9063
2020-10-01Cleanup: avoid applying offset to null pointerCampbell Barton
Based on D9069 by @ankitm.
2020-10-01Cleanup: dna_genfile API for accessing struct member offsetsCampbell Barton
- Rename `find_elem` to `elem_offset` (matching `elem_exists`). - Remove unused `SDNA_StructMember` return argument. - Return an offset instead of a pointer which was being converted back into an offset by one caller, in this case there was no way to tell the difference between and element that doesn't exist and a struct member at the start of the array. Resolves UBSan warning raised in T81340.
2020-09-30Fix File Browser filtering showing workspaces for "Environment" categoryJulian Eisel
This is not an appropriate category for workspaces. Mistake in 7f564d74f9ed. My intention was probably to add it to the "Miscellaneous" category.
2020-09-30Fix implicit conversion from pointer to boolHans Goudey
Error in 9b6c5268bc20. Also move variable declaration to where it's used to reduce confusion.
generated by cgit v1.2.3 (git 2.25.1) at 2024-07-17 12:26:28 +0300