1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
|
/*
* This program is free software; you can redistribute it and/or
* modify it under the terms of the GNU General Public License
* as published by the Free Software Foundation; either version 2
* of the License, or (at your option) any later version.
*
* This program is distributed in the hope that it will be useful,
* but WITHOUT ANY WARRANTY; without even the implied warranty of
* MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
* GNU General Public License for more details.
*
* You should have received a copy of the GNU General Public License
* along with this program; if not, write to the Free Software Foundation,
* Inc., 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301, USA.
*
* The Original Code is Copyright (C) 2021 Blender Foundation
* All rights reserved.
*/
#include "BKE_action.h"
#include "DNA_action_types.h"
#include "DNA_anim_types.h"
#include "BLI_listbase.h"
#include "MEM_guardedalloc.h"
#include "testing/testing.h"
namespace blender::bke::tests {
TEST(action_groups, ReconstructGroupsWithReordering)
{
/* Construct an Action with three groups. */
bAction action = {{nullptr}};
FCurve groupAcurve1 = {nullptr};
FCurve groupAcurve2 = {nullptr};
FCurve groupBcurve1 = {nullptr};
FCurve groupBcurve2 = {nullptr};
FCurve groupBcurve3 = {nullptr};
/* Group C has no curves intentionally. */
FCurve groupDcurve1 = {nullptr};
FCurve groupDcurve2 = {nullptr};
groupAcurve1.rna_path = (char *)"groupAcurve1";
groupAcurve2.rna_path = (char *)"groupAcurve2";
groupBcurve1.rna_path = (char *)"groupBcurve1";
groupBcurve2.rna_path = (char *)"groupBcurve2";
groupDcurve1.rna_path = (char *)"groupDcurve1";
groupBcurve3.rna_path = (char *)"groupBcurve3";
groupDcurve2.rna_path = (char *)"groupDcurve2";
BLI_addtail(&action.curves, &groupAcurve1);
BLI_addtail(&action.curves, &groupAcurve2);
BLI_addtail(&action.curves, &groupBcurve1);
BLI_addtail(&action.curves, &groupBcurve2);
BLI_addtail(&action.curves, &groupDcurve1);
BLI_addtail(&action.curves, &groupBcurve3); /* <-- The error that should be corrected. */
BLI_addtail(&action.curves, &groupDcurve2);
/* Introduce another error type, by changing some `prev` pointers. */
groupBcurve1.prev = nullptr;
groupBcurve3.prev = &groupBcurve2;
groupDcurve1.prev = &groupBcurve3;
bActionGroup groupA = {nullptr};
bActionGroup groupB = {nullptr};
bActionGroup groupC = {nullptr};
bActionGroup groupD = {nullptr};
strcpy(groupA.name, "groupA");
strcpy(groupB.name, "groupB");
strcpy(groupC.name, "groupC");
strcpy(groupD.name, "groupD");
BLI_addtail(&action.groups, &groupA);
BLI_addtail(&action.groups, &groupB);
BLI_addtail(&action.groups, &groupC);
BLI_addtail(&action.groups, &groupD);
groupAcurve1.grp = &groupA;
groupAcurve2.grp = &groupA;
groupBcurve1.grp = &groupB;
groupBcurve2.grp = &groupB;
groupBcurve3.grp = &groupB;
groupDcurve1.grp = &groupD;
groupDcurve2.grp = &groupD;
groupA.channels.first = &groupAcurve1;
groupA.channels.last = &groupAcurve2;
groupB.channels.first = &groupBcurve1;
groupB.channels.last = &groupBcurve3; /* The last channel in group B, after group C curve 1. */
groupD.channels.first = &groupDcurve1;
groupD.channels.last = &groupDcurve2;
EXPECT_EQ(groupA.channels.first, &groupAcurve1);
EXPECT_EQ(groupA.channels.last, &groupAcurve2);
EXPECT_EQ(groupB.channels.first, &groupBcurve1);
EXPECT_EQ(groupB.channels.last, &groupBcurve3);
EXPECT_EQ(groupC.channels.first, nullptr);
EXPECT_EQ(groupC.channels.last, nullptr);
EXPECT_EQ(groupD.channels.first, &groupDcurve1);
EXPECT_EQ(groupD.channels.last, &groupDcurve2);
BKE_action_groups_reconstruct(&action);
EXPECT_EQ(action.curves.first, &groupAcurve1);
EXPECT_EQ(action.curves.last, &groupDcurve2);
EXPECT_EQ(groupA.prev, nullptr);
EXPECT_EQ(groupB.prev, &groupA);
EXPECT_EQ(groupC.prev, &groupB);
EXPECT_EQ(groupD.prev, &groupC);
EXPECT_EQ(groupA.next, &groupB);
EXPECT_EQ(groupB.next, &groupC);
EXPECT_EQ(groupC.next, &groupD);
EXPECT_EQ(groupD.next, nullptr);
EXPECT_EQ(groupA.channels.first, &groupAcurve1);
EXPECT_EQ(groupA.channels.last, &groupAcurve2);
EXPECT_EQ(groupB.channels.first, &groupBcurve1);
EXPECT_EQ(groupB.channels.last, &groupBcurve3);
EXPECT_EQ(groupC.channels.first, nullptr);
EXPECT_EQ(groupC.channels.last, nullptr);
EXPECT_EQ(groupD.channels.first, &groupDcurve1);
EXPECT_EQ(groupD.channels.last, &groupDcurve2);
EXPECT_EQ(groupAcurve1.prev, nullptr);
EXPECT_EQ(groupAcurve2.prev, &groupAcurve1);
EXPECT_EQ(groupBcurve1.prev, &groupAcurve2);
EXPECT_EQ(groupBcurve2.prev, &groupBcurve1);
EXPECT_EQ(groupBcurve3.prev, &groupBcurve2);
EXPECT_EQ(groupDcurve1.prev, &groupBcurve3);
EXPECT_EQ(groupDcurve2.prev, &groupDcurve1);
EXPECT_EQ(groupAcurve1.next, &groupAcurve2);
EXPECT_EQ(groupAcurve2.next, &groupBcurve1);
EXPECT_EQ(groupBcurve1.next, &groupBcurve2);
EXPECT_EQ(groupBcurve2.next, &groupBcurve3);
EXPECT_EQ(groupBcurve3.next, &groupDcurve1);
EXPECT_EQ(groupDcurve1.next, &groupDcurve2);
EXPECT_EQ(groupDcurve2.next, nullptr);
}
namespace {
/* Allocate fcu->bezt, and also return a unique_ptr to it for easily freeing the memory. */
std::unique_ptr<BezTriple[]> allocate_keyframes(FCurve *fcu, const size_t num_keyframes)
{
auto bezt_uptr = std::make_unique<BezTriple[]>(num_keyframes);
fcu->bezt = bezt_uptr.get();
return bezt_uptr;
}
/* Append keyframe, assumes that fcu->bezt is allocated and has enough space. */
void add_keyframe(FCurve *fcu, float x, float y)
{
/* The insert_keyframe functions are in the editors, so we cannot link to those here. */
BezTriple the_keyframe;
memset(&the_keyframe, 0, sizeof(the_keyframe));
/* Copied from insert_vert_fcurve() in keyframing.c. */
the_keyframe.vec[0][0] = x - 1.0f;
the_keyframe.vec[0][1] = y;
the_keyframe.vec[1][0] = x;
the_keyframe.vec[1][1] = y;
the_keyframe.vec[2][0] = x + 1.0f;
the_keyframe.vec[2][1] = y;
memcpy(&fcu->bezt[fcu->totvert], &the_keyframe, sizeof(the_keyframe));
fcu->totvert++;
}
} // namespace
TEST(action_assets, BKE_action_has_single_frame)
{
/* NULL action. */
EXPECT_FALSE(BKE_action_has_single_frame(nullptr)) << "NULL Action cannot have a single frame.";
/* No FCurves. */
{
const bAction empty = {{nullptr}};
EXPECT_FALSE(BKE_action_has_single_frame(&empty))
<< "Action without FCurves cannot have a single frame.";
}
/* One curve with one key. */
{
FCurve fcu = {nullptr};
std::unique_ptr<BezTriple[]> bezt = allocate_keyframes(&fcu, 1);
add_keyframe(&fcu, 1.0f, 2.0f);
bAction action = {{nullptr}};
BLI_addtail(&action.curves, &fcu);
EXPECT_TRUE(BKE_action_has_single_frame(&action))
<< "Action with one FCurve and one key should have single frame.";
}
/* Two curves with one key each. */
{
FCurve fcu1 = {nullptr};
FCurve fcu2 = {nullptr};
std::unique_ptr<BezTriple[]> bezt1 = allocate_keyframes(&fcu1, 1);
std::unique_ptr<BezTriple[]> bezt2 = allocate_keyframes(&fcu2, 1);
add_keyframe(&fcu1, 1.0f, 327.0f);
add_keyframe(&fcu2, 1.0f, 47.0f); /* Same X-coordinate as the other one. */
bAction action = {{nullptr}};
BLI_addtail(&action.curves, &fcu1);
BLI_addtail(&action.curves, &fcu2);
EXPECT_TRUE(BKE_action_has_single_frame(&action))
<< "Two FCurves with keys on the same frame should have single frame.";
/* Modify the 2nd curve so it's keyed on a different frame. */
fcu2.bezt[0].vec[1][0] = 2.0f;
EXPECT_FALSE(BKE_action_has_single_frame(&action))
<< "Two FCurves with keys on different frames should have animation.";
}
/* One curve with two keys. */
{
FCurve fcu = {nullptr};
std::unique_ptr<BezTriple[]> bezt = allocate_keyframes(&fcu, 2);
add_keyframe(&fcu, 1.0f, 2.0f);
add_keyframe(&fcu, 2.0f, 2.5f);
bAction action = {{nullptr}};
BLI_addtail(&action.curves, &fcu);
EXPECT_FALSE(BKE_action_has_single_frame(&action))
<< "Action with one FCurve and two keys must have animation.";
}
}
} // namespace blender::bke::tests
|
