diff options
| author | Junio C Hamano <gitster@pobox.com> | 2015-10-16 01:43:51 +0300 |
|---|---|---|
| committer | Junio C Hamano <gitster@pobox.com> | 2015-10-16 01:43:51 +0300 |
| commit | 1018f3eea40875843ece4131e662ec3e32a3ab06 (patch) | |
| tree | de0d7fd953157850734daa515cdc310f1aed07e6 | |
| parent | db5adf24bf6e0380d4b4ce97f88b4f874773f424 (diff) | |
| parent | 14886b40c552d3ad4d5492d922948d76762af198 (diff) | |
Merge branch 'js/gc-with-stale-symref'
"git gc" used to barf when a symbolic ref has gone dangling
(e.g. the branch that used to be your upstream's default when you
cloned from it is now gone, and you did "fetch --prune").
* js/gc-with-stale-symref:
pack-objects: do not get distracted by broken symrefs
gc: demonstrate failure with stale remote HEAD
| -rw-r--r-- | reachable.c | 8 | ||||
| -rwxr-xr-x | t/t6500-gc.sh | 13 |
2 files changed, 20 insertions, 1 deletions
diff --git a/reachable.c b/reachable.c index 9cff25b490..43616d49c7 100644 --- a/reachable.c +++ b/reachable.c @@ -25,9 +25,15 @@ static void update_progress(struct connectivity_progress *cp) static int add_one_ref(const char *path, const struct object_id *oid, int flag, void *cb_data) { - struct object *object = parse_object_or_die(oid->hash, path); struct rev_info *revs = (struct rev_info *)cb_data; + struct object *object; + if ((flag & REF_ISSYMREF) && (flag & REF_ISBROKEN)) { + warning("symbolic ref is dangling: %s", path); + return 0; + } + + object = parse_object_or_die(oid->hash, path); add_pending_object(revs, object, ""); return 0; diff --git a/t/t6500-gc.sh b/t/t6500-gc.sh index 63194d819e..5d7d414617 100755 --- a/t/t6500-gc.sh +++ b/t/t6500-gc.sh @@ -30,4 +30,17 @@ test_expect_success 'gc -h with invalid configuration' ' test_i18ngrep "[Uu]sage" broken/usage ' +test_expect_success 'gc is not aborted due to a stale symref' ' + git init remote && + ( + cd remote && + test_commit initial && + git clone . ../client && + git branch -m develop && + cd ../client && + git fetch --prune && + git gc + ) +' + test_done |