diff options
| author | Johannes Schindelin <Johannes.Schindelin@gmx.de> | 2005-11-07 02:59:39 +0300 |
|---|---|---|
| committer | Junio C Hamano <junkio@cox.net> | 2005-11-07 05:31:47 +0300 |
| commit | 90279074ca5cc336a8bfffd47d19d089b291b432 (patch) | |
| tree | e76c7c8b9b08165ae63c0d8796c4b0a1313d76c1 | |
| parent | 67ffdf4c0af47679b8a4ac2b70e722e2f65fc4f9 (diff) | |
http-fetch: do not use curl_message after releasing it
When curl_message is released using curl_multi_remove_handle(), it's
contents are undefined. Therefore, get the information before releasing it.
Signed-off-by: Johannes Schindelin <Johannes.Schindelin@gmx.de>
Signed-off-by: Junio C Hamano <junkio@cox.net>
| -rw-r--r-- | http-fetch.c | 6 |
1 files changed, 3 insertions, 3 deletions
diff --git a/http-fetch.c b/http-fetch.c index b12779dcb4..ea8af1b2de 100644 --- a/http-fetch.c +++ b/http-fetch.c @@ -578,6 +578,7 @@ void process_curl_messages(void) while (curl_message != NULL) { if (curl_message->msg == CURLMSG_DONE) { + int curl_result = curl_message->data.result; slot = active_queue_head; while (slot != NULL && slot->curl != curl_message->easy_handle) @@ -587,7 +588,7 @@ void process_curl_messages(void) active_requests--; slot->done = 1; slot->in_use = 0; - slot->curl_result = curl_message->data.result; + slot->curl_result = curl_result; curl_easy_getinfo(slot->curl, CURLINFO_HTTP_CODE, &slot->http_code); @@ -599,8 +600,7 @@ void process_curl_messages(void) fprintf(stderr, "Received DONE message for unknown request!\n"); } if (request != NULL) { - request->curl_result = - curl_message->data.result; + request->curl_result = curl_result; request->http_code = slot->http_code; request->slot = NULL; request->state = COMPLETE; |