diff options
| author | Johannes Sixt <johannes.sixt@telecom.at> | 2008-02-16 20:36:38 +0300 |
|---|---|---|
| committer | Junio C Hamano <gitster@pobox.com> | 2008-02-23 22:59:44 +0300 |
| commit | e72ae28895b22052b7ca2eef36c039ac62671f7d (patch) | |
| tree | 35e5df11a285b4467054fcec75cf8e35f38093e1 /builtin-verify-tag.c | |
| parent | 923d44aeb7cb6d21eeb459fdc1b58137e37c2b1c (diff) | |
start_command(), .in/.out/.err = -1: Callers must close the file descriptor
By setting .in, .out, or .err members of struct child_process to -1, the
callers of start_command() can request that a pipe is allocated that talks
to the child process and one end is returned by replacing -1 with the
file descriptor.
Previously, a flag was set (for .in and .out, but not .err) to signal
finish_command() to close the pipe end that start_command() had handed out,
so it was optional for callers to close the pipe, and many already do so.
Now we make it mandatory to close the pipe.
Signed-off-by: Johannes Sixt <johannes.sixt@telecom.at>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
Diffstat (limited to 'builtin-verify-tag.c')
| -rw-r--r-- | builtin-verify-tag.c | 1 |
1 files changed, 0 insertions, 1 deletions
diff --git a/builtin-verify-tag.c b/builtin-verify-tag.c index cc4c55d7ee..b3010f9827 100644 --- a/builtin-verify-tag.c +++ b/builtin-verify-tag.c @@ -52,7 +52,6 @@ static int run_gpg_verify(const char *buf, unsigned long size, int verbose) write_in_full(gpg.in, buf, len); close(gpg.in); - gpg.close_in = 0; ret = finish_command(&gpg); unlink(path); |