diff options
| author | Jeff King <peff@peff.net> | 2023-03-28 23:54:32 +0300 |
|---|---|---|
| committer | Junio C Hamano <gitster@pobox.com> | 2023-03-29 00:11:24 +0300 |
| commit | 836c8ceb7a4d26910a70a17ffba5a0d8b87bd1a1 (patch) | |
| tree | 200407e7f7e6f1aec11f0fc230d776e62e666522 /builtin/mktag.c | |
| parent | 9dc607f1c29de88bc5194df49cc7f834e528a3e9 (diff) | |
builtins: always pass prefix to parse_options()
Our builtins receive a "prefix" argument as part of their cmd_foo()
function. We should always pass this to parse_options() if we're calling
it, as it may be used for OPT_FILENAME() options.
In the cases here, there's no option that would use it, so we're not
fixing any bug. This is just future-proofing and setting a good example
(plus quelling some -Wunused-parameter warnings).
Note in the case of revert/cherry-pick, that we plumb the prefix through
to run_sequencer(), as those builtins are just thin wrappers around it.
Signed-off-by: Jeff King <peff@peff.net>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
Diffstat (limited to 'builtin/mktag.c')
| -rw-r--r-- | builtin/mktag.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/builtin/mktag.c b/builtin/mktag.c index 42c2457c70..967a4442de 100644 --- a/builtin/mktag.c +++ b/builtin/mktag.c @@ -81,7 +81,7 @@ int cmd_mktag(int argc, const char **argv, const char *prefix) int tagged_type; struct object_id result; - argc = parse_options(argc, argv, NULL, + argc = parse_options(argc, argv, prefix, builtin_mktag_options, builtin_mktag_usage, 0); |