diff options
| author | Ilari Liusvaara <ilari.liusvaara@elisanet.fi> | 2010-11-17 20:15:34 +0300 |
|---|---|---|
| committer | Junio C Hamano <gitster@pobox.com> | 2010-11-19 22:04:20 +0300 |
| commit | 7851b1e60fabe350216d48e6de03a3ed21a49953 (patch) | |
| tree | 80880c61f51eb749bffd0034a4831e96a55fe57e /builtin/remote-ext.c | |
| parent | 7f3ecebfcda9b32252a4791dc716c1e3d88c9f70 (diff) | |
remote-fd/ext: finishing touches after code review
When compiling with pthread support, transport-helper.c needs to include
necessary header files. Also fix a few error messages in remote-ext and
remote-fd programs, and a potential buffer underrun in remote-fd.
In the documentation, clarify how %G and %V are used; the old description
looked as if they take repository/vhost parameters, which was wrong.
Also fix AsciiDoc markup for the page title of remote-fd/remote-ext manpages,
and tweak the way how section headers are shown.
Signed-off-by: Ilari Liusvaara <ilari.liusvaara@elisanet.fi>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
Diffstat (limited to 'builtin/remote-ext.c')
| -rw-r--r-- | builtin/remote-ext.c | 8 |
1 files changed, 3 insertions, 5 deletions
diff --git a/builtin/remote-ext.c b/builtin/remote-ext.c index 1d3f1cf3cc..1f773171cb 100644 --- a/builtin/remote-ext.c +++ b/builtin/remote-ext.c @@ -142,7 +142,7 @@ static const char **parse_argv(const char *arg, const char *service) for (i = 0; i < arguments; i++) ret[i] = temparray[i]; ret[arguments] = NULL; - return (const char **)ret; + return ret; } static void send_git_request(int stdin_fd, const char *serv, const char *repo, @@ -239,10 +239,8 @@ static int command_loop(const char *child) int cmd_remote_ext(int argc, const char **argv, const char *prefix) { - if (argc < 3) { - fprintf(stderr, "Error: URL missing"); - exit(1); - } + if (argc != 3) + die("Expected two arguments"); return command_loop(argv[2]); } |