diff options
author | Ævar Arnfjörð Bjarmason <avarab@gmail.com> | 2022-08-25 20:09:48 +0300 |
---|---|---|
committer | Junio C Hamano <gitster@pobox.com> | 2022-09-01 20:49:48 +0300 |
commit | 5cf88fd8b059235b21ee2f72b17bf1f421a9c4e7 (patch) | |
tree | 03de8d4160649a0b4c1dd79164d746206743f25d /builtin/rev-parse.c | |
parent | 776515ef8b381d49caeccfe2e8da98cb666e257a (diff) |
git-compat-util.h: use "UNUSED", not "UNUSED(var)"
As reported in [1] the "UNUSED(var)" macro introduced in
2174b8c75de (Merge branch 'jk/unused-annotation' into next,
2022-08-24) breaks coccinelle's parsing of our sources in files where
it occurs.
Let's instead partially go with the approach suggested in [2] of
making this not take an argument. As noted in [1] "coccinelle" will
ignore such tokens in argument lists that it doesn't know about, and
it's less of a surprise to syntax highlighters.
This undoes the "help us notice when a parameter marked as unused is
actually use" part of 9b240347543 (git-compat-util: add UNUSED macro,
2022-08-19), a subsequent commit will further tweak the macro to
implement a replacement for that functionality.
1. https://lore.kernel.org/git/220825.86ilmg4mil.gmgdl@evledraar.gmail.com/
2. https://lore.kernel.org/git/220819.868rnk54ju.gmgdl@evledraar.gmail.com/
Signed-off-by: Ævar Arnfjörð Bjarmason <avarab@gmail.com>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
Diffstat (limited to 'builtin/rev-parse.c')
-rw-r--r-- | builtin/rev-parse.c | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/builtin/rev-parse.c b/builtin/rev-parse.c index 3c448d438b..e5d70ee6d2 100644 --- a/builtin/rev-parse.c +++ b/builtin/rev-parse.c @@ -196,7 +196,7 @@ static int show_default(void) } static int show_reference(const char *refname, const struct object_id *oid, - int UNUSED(flag), void *UNUSED(cb_data)) + int flag UNUSED, void *cb_data UNUSED) { if (ref_excluded(ref_excludes, refname)) return 0; @@ -205,7 +205,7 @@ static int show_reference(const char *refname, const struct object_id *oid, } static int anti_reference(const char *refname, const struct object_id *oid, - int UNUSED(flag), void *UNUSED(cb_data)) + int flag UNUSED, void *cb_data UNUSED) { show_rev(REVERSED, oid, refname); return 0; |