diff options
author | Johannes Schindelin <johannes.schindelin@gmx.de> | 2022-06-13 16:13:08 +0300 |
---|---|---|
committer | Junio C Hamano <gitster@pobox.com> | 2022-06-13 19:58:42 +0300 |
commit | cadcafc3311de7f6fae5f3add10cde4f93268ff8 (patch) | |
tree | e0b22e8a0184009075a7d1ba8b4dae44cc809318 /ci | |
parent | df5fed9c34a394b55194b3fb69413bcc4c76fd64 (diff) |
ci(github): also mark up compile errors
When GCC produces those helpful errors, we will want to present them in
the GitHub workflow runs in the most helpful manner. To that end, we
want to use workflow commands to render errors and warnings:
https://docs.github.com/en/actions/using-workflows/workflow-commands-for-github-actions
In the previous commit, we ensured that grouping is used for the build
in all jobs, and this allows us to piggy-back onto the `group` function
to transmogrify the output.
Note: If `set -o pipefail` was available, we could do this in a little
more elegant way. But since some of the steps are run using `dash`, we
have to do a little `{ ...; echo $? >exit.status; } | ...` dance.
Signed-off-by: Johannes Schindelin <johannes.schindelin@gmx.de>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
Diffstat (limited to 'ci')
-rwxr-xr-x | ci/lib.sh | 10 |
1 files changed, 8 insertions, 2 deletions
@@ -29,8 +29,14 @@ else set +x begin_group "$1" shift - "$@" - res=$? + # work around `dash` not supporting `set -o pipefail` + ( + "$@" 2>&1 + echo $? >exit.status + ) | + sed 's/^\(\([^ ]*\):\([0-9]*\):\([0-9]*:\) \)\(error\|warning\): /::\5 file=\2,line=\3::\1/' + res=$(cat exit.status) + rm exit.status end_group return $res } |