diff options
| author | Ævar Arnfjörð Bjarmason <avarab@gmail.com> | 2022-11-30 11:28:23 +0300 |
|---|---|---|
| committer | Junio C Hamano <gitster@pobox.com> | 2022-12-01 01:25:57 +0300 |
| commit | cddd68ae33667c4bfc81c81f74815bb2ba0e4f3a (patch) | |
| tree | 70b45ba36288ba07525a730da096a8a77c1339dc /contrib | |
| parent | 07047d68294769d5e8700fc200ac326a21d04f8e (diff) | |
cocci: avoid "should ... be a metavariable" warnings
Since [1] running "make coccicheck" has resulted in [2] being emitted
to the *.log files for the "spatch" run, and in the case of "make
coccicheck-test" we'd emit these to the user's terminal.
Nothing was broken as a result, but let's refactor the relevant rules
to eliminate the ambiguity between a possible variable and an
identifier.
1. 0e6550a2c63 (cocci: add a index-compatibility.pending.cocci,
2022-11-19)
2. warning: line 257: should active_cache be a metavariable?
warning: line 260: should active_cache_changed be a metavariable?
warning: line 263: should active_cache_tree be a metavariable?
warning: line 271: should active_nr be a metavariable?
Signed-off-by: Ævar Arnfjörð Bjarmason <avarab@gmail.com>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
Diffstat (limited to 'contrib')
| -rw-r--r-- | contrib/coccinelle/index-compatibility.cocci | 12 |
1 files changed, 8 insertions, 4 deletions
diff --git a/contrib/coccinelle/index-compatibility.cocci b/contrib/coccinelle/index-compatibility.cocci index 4c1b890c3e..8520f03128 100644 --- a/contrib/coccinelle/index-compatibility.cocci +++ b/contrib/coccinelle/index-compatibility.cocci @@ -1,22 +1,26 @@ // the_index.* variables @@ +identifier AC = active_cache; +identifier ACC = active_cache_changed; +identifier ACT = active_cache_tree; @@ ( -- active_cache +- AC + the_index.cache | -- active_cache_changed +- ACC + the_index.cache_changed | -- active_cache_tree +- ACT + the_index.cache_tree ) @@ +identifier AN = active_nr; identifier f != prepare_to_commit; @@ f(...) {<... -- active_nr +- AN + the_index.cache_nr ...>} |