diff options
author | brian m. carlson <sandals@crustytoothpaste.net> | 2023-08-02 19:49:32 +0300 |
---|---|---|
committer | Junio C Hamano <gitster@pobox.com> | 2023-08-02 19:50:52 +0300 |
commit | 1c04cb0744d2acdcaebc77b0e78c47efbba67fd5 (patch) | |
tree | 9e2954c21b9663e16dde5fc345047da3e285fc15 /ident.c | |
parent | fb7d80edcae482f4fa5d4be0227dc3054734e5f3 (diff) |
ident: don't consider '.' a crud
When we process a user's name (as in user.name), we strip all
leading and trailing crud from it. Right now, we consider a dot
a crud character, and strip it off.
However, this is unsuitable for many personal names because humans
frequently have abbreviated suffixes, such as "Jr." or "Sr." at the end
of their names, and this corrupts them. Some other users may wish to
use an abbreviated name or initial, which will pose a problem especially
in cultures that write the family name first, followed by the personal
name.
Since the current approach causes lots of practical problems, let's
avoid it by no longer considering a dot to be crud.
Note that "." in the name forces the entire name to be quoted to
please mailers, but stripping "." only at the beginning and the end
does not help a name with "." in the middle (like "brian m. carlson")
so this change will not make it much worse. A name like "Given
Family, Jr." that did not have to be quoted now would need to be, in
order to be placed on the e-mail headers, though.
This is based on a weather-balloon patch by Jeff King sent in Aug 2021
https://lore.kernel.org/git/YSKm8Q8nyTavQaox@coredump.intra.peff.net/
Signed-off-by: brian m. carlson <sandals@crustytoothpaste.net>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
Diffstat (limited to 'ident.c')
-rw-r--r-- | ident.c | 1 |
1 files changed, 0 insertions, 1 deletions
@@ -203,7 +203,6 @@ void reset_ident_date(void) static int crud(unsigned char c) { return c <= 32 || - c == '.' || c == ',' || c == ':' || c == ';' || |