diff options
| author | Jeff King <peff@peff.net> | 2023-01-07 16:48:55 +0300 |
|---|---|---|
| committer | Junio C Hamano <gitster@pobox.com> | 2023-01-08 04:52:54 +0300 |
| commit | b25562e63fe8afaf0f103362a4e672e9ccdc2d68 (patch) | |
| tree | 64820cb1014bf61e2e31fc23cee7818664d2d8ad /object-store.h | |
| parent | 4dbebc36b0893f5094668ddea077d0e235560b16 (diff) | |
object-file: inline calls to read_object()
Since read_object() is these days just a thin wrapper around
oid_object_info_extended(), and since it only has two callers, let's
just inline those calls. This has a few positive outcomes:
- it's a net reduction in source code lines
- even though the callers end up with a few extra lines, they're now
more flexible and can use object_info flags directly. So no more
need to convert die_if_corrupt between parameter/flag, and we can
ask for lookup replacement with a flag rather than doing it
ourselves.
- there's one fewer function in an already crowded namespace (e.g.,
the difference between read_object() and read_object_file() was not
immediately obvious; now we only have one of them).
Signed-off-by: Jeff King <peff@peff.net>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
Diffstat (limited to 'object-store.h')
| -rw-r--r-- | object-store.h | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/object-store.h b/object-store.h index 98c1d67946..f0aa03bbb9 100644 --- a/object-store.h +++ b/object-store.h @@ -358,7 +358,7 @@ void assert_oid_type(const struct object_id *oid, enum object_type expect); /* * Enabling the object read lock allows multiple threads to safely call the * following functions in parallel: repo_read_object_file(), read_object_file(), - * read_object_file_extended(), read_object_with_reference(), read_object(), + * read_object_file_extended(), read_object_with_reference(), * oid_object_info() and oid_object_info_extended(). * * obj_read_lock() and obj_read_unlock() may also be used to protect other |