diff options
| author | Jeff King <peff@peff.net> | 2022-08-28 15:50:50 +0300 |
|---|---|---|
| committer | Junio C Hamano <gitster@pobox.com> | 2022-08-28 23:23:37 +0300 |
| commit | 969a5645876ccf368ed74fde2c5dc9b5432b7bb0 (patch) | |
| tree | 1b9b000d98486d1a0640cc6072c14e227fe344e8 /pack-bitmap-write.c | |
| parent | 761416ef91d819d84a11222ec5bc3cbc66d3ddac (diff) | |
pack-bitmap-write: drop unused pack_idx_entry parameters
Our write_selected_commits_v1() function takes an array of
pack_idx_entry structs. We used to need them for computing commit
positions, but since aa30162559 (bitmap: move `get commit positions`
code to `bitmap_writer_finish`, 2022-08-14), the caller passes in a
separate array of positions for us. We can drop the unused array (and
its matching length parameter).
Likewise, when we added write_lookup_table() in 93eb41e240
(pack-bitmap-write.c: write lookup table extension, 2022-08-14), it
receives the same array of positions. So its "index" parameter was never
used at all.
Signed-off-by: Jeff King <peff@peff.net>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
Diffstat (limited to 'pack-bitmap-write.c')
| -rw-r--r-- | pack-bitmap-write.c | 8 |
1 files changed, 2 insertions, 6 deletions
diff --git a/pack-bitmap-write.c b/pack-bitmap-write.c index 2cfc92f287..a213f5eddc 100644 --- a/pack-bitmap-write.c +++ b/pack-bitmap-write.c @@ -649,8 +649,6 @@ static const struct object_id *oid_access(size_t pos, const void *table) } static void write_selected_commits_v1(struct hashfile *f, - struct pack_idx_entry **index, - uint32_t index_nr, uint32_t *commit_positions, off_t *offsets) { @@ -685,8 +683,6 @@ static int table_cmp(const void *_va, const void *_vb, void *_data) } static void write_lookup_table(struct hashfile *f, - struct pack_idx_entry **index, - uint32_t index_nr, uint32_t *commit_positions, off_t *offsets) { @@ -808,10 +804,10 @@ void bitmap_writer_finish(struct pack_idx_entry **index, commit_positions[i] = commit_pos; } - write_selected_commits_v1(f, index, index_nr, commit_positions, offsets); + write_selected_commits_v1(f, commit_positions, offsets); if (options & BITMAP_OPT_LOOKUP_TABLE) - write_lookup_table(f, index, index_nr, commit_positions, offsets); + write_lookup_table(f, commit_positions, offsets); if (options & BITMAP_OPT_HASH_CACHE) write_hash_cache(f, index, index_nr); |