diff options
author | Patrick Steinhardt <ps@pks.im> | 2023-12-14 16:37:02 +0300 |
---|---|---|
committer | Junio C Hamano <gitster@pobox.com> | 2023-12-14 20:25:26 +0300 |
commit | 668cdc043fe6f6d1fa2bf2b3f3c2375a20819e77 (patch) | |
tree | bb7d9f35543be78997bacb5b1397726c080b5a3f /refs.c | |
parent | 8f61321ccbdea20945a73446f24a6c380cb2c53b (diff) |
refs: propagate errno when reading special refs fails
Some refs in Git are more special than others due to reasons explained
in the next commit. These refs are read via `refs_read_special_head()`,
but this function doesn't behave the same as when we try to read a
normal ref. Most importantly, we do not propagate `failure_errno` in the
case where the reference does not exist, which is behaviour that we rely
on in many parts of Git.
Fix this bug by propagating errno when `strbuf_read_file()` fails.
Signed-off-by: Patrick Steinhardt <ps@pks.im>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
Diffstat (limited to 'refs.c')
-rw-r--r-- | refs.c | 4 |
1 files changed, 3 insertions, 1 deletions
@@ -1806,8 +1806,10 @@ static int refs_read_special_head(struct ref_store *ref_store, int result = -1; strbuf_addf(&full_path, "%s/%s", ref_store->gitdir, refname); - if (strbuf_read_file(&content, full_path.buf, 0) < 0) + if (strbuf_read_file(&content, full_path.buf, 0) < 0) { + *failure_errno = errno; goto done; + } result = parse_loose_ref_contents(content.buf, oid, referent, type, failure_errno); |