diff options
author | Ævar Arnfjörð Bjarmason <avarab@gmail.com> | 2021-06-08 13:48:03 +0300 |
---|---|---|
committer | Junio C Hamano <gitster@pobox.com> | 2021-06-09 03:15:58 +0300 |
commit | 338abb0f045b87df5e628543800e74dec0e72cdf (patch) | |
tree | 52e8b1cb82decf173d31647abca84a65945fc93c /shell.c | |
parent | 48bf2fa8bad054d66bd79c6ba903c89c704201f7 (diff) |
builtins + test helpers: use return instead of exit() in cmd_*
Change various cmd_* functions that claim to return an "int" to use
"return" instead of exit() to indicate an exit code. These were not
marked with NORETURN, and by directly exit()-ing we'll skip the
cleanup git.c would otherwise do (e.g. closing fd's, erroring if we
can't). See run_builtin() in git.c.
In the case of shell.c and sh-i18n--envsubst.c this was the result of
an incomplete migration to using a cmd_main() in 3f2e2297b9 (add an
extra level of indirection to main(), 2016-07-01).
This was spotted by SunCC 12.5 on Solaris 10 (gcc210 on the gccfarm).
Signed-off-by: Ævar Arnfjörð Bjarmason <avarab@gmail.com>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
Diffstat (limited to 'shell.c')
-rw-r--r-- | shell.c | 2 |
1 files changed, 1 insertions, 1 deletions
@@ -177,7 +177,7 @@ int cmd_main(int argc, const char **argv) default: continue; } - exit(cmd->exec(cmd->name, arg)); + return cmd->exec(cmd->name, arg); } cd_to_homedir(); |