diff options
| author | Jonathan Nieder <jrnieder@gmail.com> | 2019-12-24 04:01:10 +0300 |
|---|---|---|
| committer | Junio C Hamano <gitster@pobox.com> | 2020-01-16 01:03:55 +0300 |
| commit | 8a1b0978abf8b3fb0ee2dc7a7d71766ed0ef4768 (patch) | |
| tree | b0a1252c909f25c0b6263a541b0ec7d52df6423a /t/t5552-skipping-fetch-negotiator.sh | |
| parent | b9ab170752f39f4a72e3595129735c87a491dffd (diff) | |
test: request GIT_TEST_PROTOCOL_VERSION=0 when appropriate
Since 8cbeba0632 (tests: define GIT_TEST_PROTOCOL_VERSION,
2019-02-25), it has been possible to run tests with a newer protocol
version by setting the GIT_TEST_PROTOCOL_VERSION envvar to a version
number. Tests that assume protocol v0 handle this by explicitly
setting
GIT_TEST_PROTOCOL_VERSION=
or similar constructs like 'test -z "$GIT_TEST_PROTOCOL_VERSION" ||
return 0' to declare that they only handle the default (v0) protocol.
The emphasis there is a bit off: it would be clearer to specify
GIT_TEST_PROTOCOL_VERSION=0 to inform the reader that these tests are
specifically testing and relying on details of protocol v0. Do so.
This way, a reader does not need to know what the default protocol
version is, and the tests can continue to work when the default
protocol version used by Git advances past v0.
Signed-off-by: Jonathan Nieder <jrnieder@gmail.com>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
Diffstat (limited to 't/t5552-skipping-fetch-negotiator.sh')
| -rwxr-xr-x | t/t5552-skipping-fetch-negotiator.sh | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/t/t5552-skipping-fetch-negotiator.sh b/t/t5552-skipping-fetch-negotiator.sh index 8f25f4b31f..156c704040 100755 --- a/t/t5552-skipping-fetch-negotiator.sh +++ b/t/t5552-skipping-fetch-negotiator.sh @@ -108,7 +108,7 @@ test_expect_success 'use ref advertisement to filter out commits' ' # The ref advertisement itself is filtered when protocol v2 is used, so # use v0. ( - GIT_TEST_PROTOCOL_VERSION= && + GIT_TEST_PROTOCOL_VERSION=0 && export GIT_TEST_PROTOCOL_VERSION && trace_fetch client origin to_fetch ) && |