diff options
| author | Beat Bolli <dev+git@drbeat.li> | 2023-07-20 19:48:23 +0300 |
|---|---|---|
| committer | Junio C Hamano <gitster@pobox.com> | 2023-07-20 21:52:53 +0300 |
| commit | a27eecea75b3858b4052b191143f144a7e966869 (patch) | |
| tree | 23a314b2ea37269e2fedd0b3a46260fa87293030 /wrapper.h | |
| parent | cba07a324d2cda06dd7a7b35b4579f800de024aa (diff) | |
wrapper: use trace2 counters to collect fsync stats
As mentioned in the thread starting at [1], trace2 counters should be
used to count events instead of ad-hoc static variables.
Convert the two fsync static variables to trace2 counters, reducing the
coupling between wrapper.c and the trace2 subsystem. Adjust t/t5351 to
match the trace2 counter output format.
The counters are not per-thread because the ones being replaced also
were not.
[1] https://lore.kernel.org/git/20230627195251.1973421-2-calvinwan@google.com/
Signed-off-by: Beat Bolli <dev+git@drbeat.li>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
Diffstat (limited to 'wrapper.h')
| -rw-r--r-- | wrapper.h | 5 |
1 files changed, 0 insertions, 5 deletions
@@ -88,11 +88,6 @@ enum fsync_action { int git_fsync(int fd, enum fsync_action action); /* - * Writes out trace statistics for fsync using the trace2 API. - */ -void trace_git_fsync_stats(void); - -/* * Preserves errno, prints a message, but gives no warning for ENOENT. * Returns 0 on success, which includes trying to unlink an object that does * not exist. |