diff options
| author | Petr Štetiar <ynezz@true.cz> | 2019-12-25 12:27:59 +0300 |
|---|---|---|
| committer | Petr Štetiar <ynezz@true.cz> | 2019-12-25 19:14:32 +0300 |
| commit | eb7eb6393d47a918c420f5b287946dbd6c0d5f57 (patch) | |
| tree | 245ab209ff6fe27fcb8c1fe80d3f5dc7a0c1320e /blobmsg.c | |
| parent | 86f6a5b8d1f160cc6f278f08f69d2c3d0f90b43c (diff) | |
blobmsg: fix array out of bounds GCC 10 warning
Fixes following warning reported by GCC 10.0.0 20191203:
blobmsg.c:234:2: error: 'strcpy' offset 6 from the object at 'attr' is out of the bounds of referenced subobject 'name' with type 'uint8_t[0]' {aka 'unsigned char[0]'} at offset 6 [-Werror=array-bounds]
234 | strcpy((char *) hdr->name, (const char *)name);
| ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
In file included from blobmsg.c:16:
blobmsg.h:42:10: note: subobject 'name' declared here
42 | uint8_t name[];
| ^~~~
Reported-by: Khem Raj <raj.khem@gmail.com>
Signed-off-by: Petr Štetiar <ynezz@true.cz>
Diffstat (limited to 'blobmsg.c')
| -rw-r--r-- | blobmsg.c | 5 |
1 files changed, 4 insertions, 1 deletions
@@ -240,7 +240,10 @@ blobmsg_new(struct blob_buf *buf, int type, const char *name, int payload_len, v attr->id_len |= be32_to_cpu(BLOB_ATTR_EXTENDED); hdr = blob_data(attr); hdr->namelen = cpu_to_be16(namelen); - strcpy((char *) hdr->name, (const char *)name); + + memcpy(hdr->name, name, namelen); + hdr->name[namelen] = '\0'; + pad_end = *data = blobmsg_data(attr); pad_start = (char *) &hdr->name[namelen]; if (pad_start < pad_end) |