diff options
| author | Michael Boelen <michael.boelen@cisofy.com> | 2019-07-16 14:20:30 +0300 |
|---|---|---|
| committer | Michael Boelen <michael.boelen@cisofy.com> | 2019-07-16 14:20:30 +0300 |
| commit | fa8bad20db100d95cf089b0b2d897c339327215c (patch) | |
| tree | 2f80f2e015d26056cd741137dc4fdd069a6c4c5d /include/tests_dns | |
| parent | 2777caf6d218aeb40c2ebd8af2564be8201eeff1 (diff) | |
Use -n instead of ! -z
Diffstat (limited to 'include/tests_dns')
| -rw-r--r-- | include/tests_dns | 8 |
1 files changed, 4 insertions, 4 deletions
diff --git a/include/tests_dns b/include/tests_dns index a2732b16..b7cf2ba8 100644 --- a/include/tests_dns +++ b/include/tests_dns @@ -38,7 +38,7 @@ # # Description : Validate DNSSEC signiture is checked # Register --test-no DNS-1600 --weight L --network YES --category security --description "Validate DNSSEC igniture is checked" # if [ "${SKIPTEST}" -eq 0 ]; then -# if [ ! -z "${DIGBINARY}" ]; then +# if [ -n "${DIGBINARY}" ]; then # # GOOD=$("${DIGBINARY}" +short +time=1 $SIGOKDNS) # BAD=$("${DIGBINARY}" +short +time=1 $SIGFAILDNS) @@ -47,16 +47,16 @@ # LogText "Result: received timeout, can't determine DNSSEC validation" # Display --indent 4 --text "- Checking DNSSEC validation" --result "${STATUS_UNKOWN}" --color YELLOW # #ReportException "${TEST_NO}" "Exception found, both query failed, due to connection timeout" -# elif [ -z "${GOOD}" -a ! -z "${BAD}" ]; then +# elif [ -z "${GOOD}" -a -n "${BAD}" ]; then # LogText "Result: good signature failed, yet bad signature was accepted" # Display --indent 4 --text "- Checking DNSSEC validation" --result "${STATUS_UNKOWN}" --color YELLOW # #ReportException "${TEST_NO}" "Exception found, OK failed, bad signature was accepted" -# elif [ ! -z "${GOOD}" -a ! -z "${BAD}" ]; then +# elif [ -n "${GOOD}" -a -n "${BAD}" ]; then # Display --indent 4 --text "- Checking DNSSEC validation" --result "${STATUS_SUGGESTION}" --color YELLOW # LogText "Note: Using DNSSEC validation can protect from DNS hijacking" # #ReportSuggestion "${TEST_NO}" "Altered DNS queries are accepted, configure DNSSEC valdating name servers" # AddHP 2 2 -# elif [ ! -z "${GOOD}" -a -z "${BAD}" ]; then +# elif [ -n "${GOOD}" -a -z "${BAD}" ]; then # Display --indent 4 --text "- Checking DNSSEC validation" --result "${STATUS_OK}" --color GREEN # LogText "Result: altered DNS responses were ignored" # AddHP 0 2 |