diff options
| author | Michael Boelen <michael.boelen@cisofy.com> | 2019-12-18 14:17:46 +0300 |
|---|---|---|
| committer | Michael Boelen <michael.boelen@cisofy.com> | 2019-12-18 14:17:46 +0300 |
| commit | 09f29a5e64d4eb0fbbec2a0a503fa173a973b898 (patch) | |
| tree | 18631dc8b10382e2eddb633d7fbcd03f3c87dbd1 /include/tests_firewalls | |
| parent | 94ba30e765d02ce638e01d731882f8b7086506e2 (diff) | |
Code style improvement: quote argument
Diffstat (limited to 'include/tests_firewalls')
| -rw-r--r-- | include/tests_firewalls | 12 |
1 files changed, 6 insertions, 6 deletions
diff --git a/include/tests_firewalls b/include/tests_firewalls index dabb7a97..67f21020 100644 --- a/include/tests_firewalls +++ b/include/tests_firewalls @@ -128,7 +128,7 @@ "ACCEPT") LogText "Result: Found ACCEPT for ${chainname} (table: ${table})" Display --indent 6 --text "- Checking chain ${chainname} (table: ${table}, policy ${policy})" --result "ACCEPT" --color YELLOW - #ReportSuggestion ${TEST_NO} "Consider settings default chain policy to DROP (iptables chain ${chainname}, table: ${table})" + #ReportSuggestion "${TEST_NO}" "Consider settings default chain policy to DROP (iptables chain ${chainname}, table: ${table})" AddHP 1 3 ;; "DROP") @@ -139,7 +139,7 @@ *) Display --indent 6 --text "- Checking chain ${chainname} (table: ${table}, policy ${policy})" --result "other" --color YELLOW LogText "Result: Unknown policy: ${policy}" - #ReportSuggestion ${TEST_NO} "Check iptables ${chainname} (table: ${table}) chain policy" + #ReportSuggestion "${TEST_NO}" "Check iptables ${chainname} (table: ${table}) chain policy" ;; esac fi @@ -162,7 +162,7 @@ FIREWALL_EMPTY_RULESET=1 LogText "Result: iptables ruleset seems to be empty (found ${FIND} rules)" Display --indent 4 --text "- Checking for empty ruleset" --result "${STATUS_WARNING}" --color RED - ReportWarning ${TEST_NO} "iptables module(s) loaded, but no rules active" + ReportWarning "${TEST_NO}" "iptables module(s) loaded, but no rules active" else LogText "Result: one or more rules are available (${FIND} rules)" Display --indent 4 --text "- Checking for empty ruleset" --result "${STATUS_OK}" --color GREEN @@ -187,7 +187,7 @@ LogText "Description: Unused rules can be a sign that the firewall rules aren't optimized or up-to-date" LogText "Note: Sometimes rules aren't triggered but still in use. Keep this in mind before cleaning up rules." LogText "Output: iptables rule numbers: ${FIND}" - ReportSuggestion ${TEST_NO} "Check iptables rules to see which rules are currently not used" + ReportSuggestion "${TEST_NO}" "Check iptables rules to see which rules are currently not used" LogText "Tip: iptables --list --numeric --line-numbers --verbose" fi fi @@ -282,7 +282,7 @@ else Display --indent 4 --text "- Checking pf configuration consistency" --result "${STATUS_WARNING}" --color RED LogText "Result: found one or more warnings in the pf filter rules" - ReportWarning ${TEST_NO} "Found one or more warnings in pf configuration file" "/etc/pf.conf" "text:Run 'pfctl -n -f /etc/pf.conf -vvv' to see available pf warnings" + ReportWarning "${TEST_NO}" "Found one or more warnings in pf configuration file" "/etc/pf.conf" "text:Run 'pfctl -n -f /etc/pf.conf -vvv' to see available pf warnings" fi else LogText "Result: /etc/pf.conf does NOT exist" @@ -548,7 +548,7 @@ else Display --indent 2 --text "- Checking host based firewall" --result "NOT ACTIVE" --color YELLOW LogText "Result: no host based firewall/packet filter found or configured" - ReportSuggestion ${TEST_NO} "Configure a firewall/packet filter to filter incoming and outgoing traffic" + ReportSuggestion "${TEST_NO}" "Configure a firewall/packet filter to filter incoming and outgoing traffic" AddHP 0 5 fi fi |