diff options
author | Michael Boelen <michael.boelen@cisofy.com> | 2019-12-18 14:17:46 +0300 |
---|---|---|
committer | Michael Boelen <michael.boelen@cisofy.com> | 2019-12-18 14:17:46 +0300 |
commit | 09f29a5e64d4eb0fbbec2a0a503fa173a973b898 (patch) | |
tree | 18631dc8b10382e2eddb633d7fbcd03f3c87dbd1 /include/tests_insecure_services | |
parent | 94ba30e765d02ce638e01d731882f8b7086506e2 (diff) |
Code style improvement: quote argument
Diffstat (limited to 'include/tests_insecure_services')
-rw-r--r-- | include/tests_insecure_services | 28 |
1 files changed, 14 insertions, 14 deletions
diff --git a/include/tests_insecure_services b/include/tests_insecure_services index 40cd9cf0..61a66066 100644 --- a/include/tests_insecure_services +++ b/include/tests_insecure_services @@ -45,7 +45,7 @@ INETD_PACKAGE_INSTALLED=1 LogText "Result: inetd is installed" Display --indent 2 --text "- Installed inetd package" --result "${STATUS_FOUND}" --color YELLOW - #ReportSuggestion ${TEST_NO} "If there are no inetd services required, it is recommended that the daemon be removed" + #ReportSuggestion "${TEST_NO}" "If there are no inetd services required, it is recommended that the daemon be removed" else LogText "Result: inetd is NOT installed" Display --indent 2 --text "- Installed inetd package" --result "${STATUS_NOT_FOUND}" --color GREEN @@ -105,7 +105,7 @@ else LogText "Result: found services in inetd, even though inetd is not running" Display --indent 4 --text "- Checking enabled inetd services" --result "${STATUS_SUGGESTION}" --color YELLOW - ReportSuggestion ${TEST_NO} "Although inetd is not running, make sure no services are enabled in ${INETD_CONFIG_FILE}, or remove inetd service" + ReportSuggestion "${TEST_NO}" "Although inetd is not running, make sure no services are enabled in ${INETD_CONFIG_FILE}, or remove inetd service" fi fi # @@ -141,7 +141,7 @@ if PackageIsInstalled "xinetd"; then LogText "Result: xinetd is installed" Display --indent 2 --text "- Installed xinetd package" --result "${STATUS_FOUND}" --color YELLOW - ReportSuggestion ${TEST_NO} "If there are no xinetd services required, it is recommended that the daemon be removed" + ReportSuggestion "${TEST_NO}" "If there are no xinetd services required, it is recommended that the daemon be removed" else LogText "Result: xinetd is NOT installed" Display --indent 2 --text "- Installed xinetd package" --result "${STATUS_OK}" --color GREEN @@ -200,7 +200,7 @@ else LogText "Result: found services in ${XINETD_CONFIG_DIR}, even though xinetd is not running" Display --indent 6 --text "- Enabled xinetd.d services" --result "${STATUS_FOUND}" --color YELLOW - ReportSuggestion ${TEST_NO} "Although xinetd is not running, make sure no services are enabled in ${XINETD_CONFIG_DIR}, or remove xinetd service" + ReportSuggestion "${TEST_NO}" "Although xinetd is not running, make sure no services are enabled in ${XINETD_CONFIG_DIR}, or remove xinetd service" fi fi # @@ -264,7 +264,7 @@ else LogText "Result: tcp_wrappers is NOT installed" Display --indent 2 --text "- Checking tcp_wrappers installation" --result "${STATUS_SUGGESTION}" --color YELLOW - #ReportSuggestion ${TEST_NO} "When network services are using the inetd/xinetd service, the tcp_wrappers package should be installed" + #ReportSuggestion "${TEST_NO}" "When network services are using the inetd/xinetd service, the tcp_wrappers package should be installed" fi fi # @@ -283,7 +283,7 @@ if [ ${FOUND} -eq 1 ]; then LogText "Result: rsh client is installed" Display --indent 2 --text "- Installed rsh client package" --result "${STATUS_SUGGESTION}" --color YELLOW - ReportSuggestion ${TEST_NO} "Remove rsh client when it is not in use or replace with the more secure SSH package" + ReportSuggestion "${TEST_NO}" "Remove rsh client when it is not in use or replace with the more secure SSH package" else LogText "Result: rsh client is NOT installed" Display --indent 2 --text "- Installed rsh client package" --result "${STATUS_OK}" --color GREEN @@ -317,7 +317,7 @@ # if [ ${FOUND} -eq 1 ]; then # LogText "Result: found one or more Rsh Trust Files" # Display --indent 4 --text "- Checking presence of Rsh Trust Files" --result "${STATUS_SUGGESTION}" --color YELLOW - # ReportSuggestion ${TEST_NO} "Remove every Rsh Trust Files as they can allow unauthenticated access to a system" + # ReportSuggestion "${TEST_NO}" "Remove every Rsh Trust Files as they can allow unauthenticated access to a system" # else # LogText "Result: no Rsh Trust Files found" # Display --indent 4 --text "- Checking presence of Rsh Trust Files" --result "${STATUS_OK}" --color GREEN @@ -340,7 +340,7 @@ if [ ${FOUND} -eq 1 ]; then LogText "Result: rsh server is installed" Display --indent 2 --text "- Installed rsh server package" --result "${STATUS_SUGGESTION}" --color YELLOW - ReportSuggestion ${TEST_NO} "Remove the rsh-server package and replace with a more secure alternative like SSH" + ReportSuggestion "${TEST_NO}" "Remove the rsh-server package and replace with a more secure alternative like SSH" Report "insecure_service[]=rsh-server" else LogText "Result: rsh server is NOT installed" @@ -362,7 +362,7 @@ LogText "Result: telnet client is installed" Display --indent 2 --text "- Installed telnet client package" --result "${STATUS_FOUND}" --color YELLOW # Telnet client usage might be used for troubleshooting instead of system administration - #ReportSuggestion ${TEST_NO} "telnet client contain numerous security exposures and have been replaced with the more secure SSH package" + #ReportSuggestion "${TEST_NO}" "telnet client contain numerous security exposures and have been replaced with the more secure SSH package" else LogText "Result: telnet client is NOT installed" Display --indent 2 --text "- Installed telnet client package" --result "${STATUS_OK}" --color GREEN @@ -385,7 +385,7 @@ if [ ${FOUND} -eq 1 ]; then LogText "Result: telnet server is installed" Display --indent 2 --text "- Installed telnet server package" --result "${STATUS_FOUND}" --color YELLOW - ReportSuggestion ${TEST_NO} "Removing the ${FOUND} package and replace with SSH when possible" + ReportSuggestion "${TEST_NO}" "Removing the ${FOUND} package and replace with SSH when possible" Report "insecure_service[]=telnet-server" else LogText "Result: telnet server is NOT installed" @@ -411,7 +411,7 @@ if [ -n "${FOUND}" ]; then LogText "Result: NIS client is installed" Display --indent 2 --text "- Checking NIS client installation" --result "${STATUS_SUGGESTION}" --color YELLOW - ReportSuggestion ${TEST_NO} "NIS client should be removed if not required. Use a more secure alternative or a protocol that can use encrypted communications." + ReportSuggestion "${TEST_NO}" "NIS client should be removed if not required. Use a more secure alternative or a protocol that can use encrypted communications." else LogText "Result: NIS client is NOT installed" Display --indent 2 --text "- Checking NIS client installation" --result "${STATUS_OK}" --color GREEN @@ -435,7 +435,7 @@ if [ -n "${FOUND}" ]; then LogText "Result: NIS server is installed" Display --indent 2 --text "- Checking NIS server installation" --result "${STATUS_SUGGESTION}" --color YELLOW - ReportSuggestion ${TEST_NO} "Removing the ${FOUND} package decreases the risk of the accidental (or intentional) activation of NIS or NIS+ services" + ReportSuggestion "${TEST_NO}" "Removing the ${FOUND} package decreases the risk of the accidental (or intentional) activation of NIS or NIS+ services" else LogText "Result: NIS server is NOT installed" Display --indent 2 --text "- Checking NIS server installation" --result "${STATUS_OK}" --color GREEN @@ -459,7 +459,7 @@ if [ -n "${FOUND}" ]; then LogText "Result: TFTP client is installed" Display --indent 2 --text "- Checking TFTP client installation" --result "${STATUS_SUGGESTION}" --color YELLOW - ReportSuggestion ${TEST_NO} "It is recommended that TFTP be removed, unless there is a specific need for TFTP (such as a boot server)" + ReportSuggestion "${TEST_NO}" "It is recommended that TFTP be removed, unless there is a specific need for TFTP (such as a boot server)" else LogText "Result: TFTP client is NOT installed" Display --indent 2 --text "- Checking TFTP client installation" --result "${STATUS_OK}" --color GREEN @@ -483,7 +483,7 @@ if [ -n "${FOUND}" ]; then LogText "Result: TFTP server is installed" Display --indent 2 --text "- Checking TFTP server installation" --result "${STATUS_SUGGESTION}" --color YELLOW - ReportSuggestion ${TEST_NO} "Removing the ${FOUND} package decreases the risk of the accidental (or intentional) activation of tftp services" + ReportSuggestion "${TEST_NO}" "Removing the ${FOUND} package decreases the risk of the accidental (or intentional) activation of tftp services" else LogText "Result: TFTP server is NOT installed" Display --indent 2 --text "- Checking TFTP server installation" --result "${STATUS_OK}" --color GREEN |