diff options
author | Michael Boelen <michael.boelen@cisofy.com> | 2019-07-16 14:20:30 +0300 |
---|---|---|
committer | Michael Boelen <michael.boelen@cisofy.com> | 2019-07-16 14:20:30 +0300 |
commit | fa8bad20db100d95cf089b0b2d897c339327215c (patch) | |
tree | 2f80f2e015d26056cd741137dc4fdd069a6c4c5d /include/tests_insecure_services | |
parent | 2777caf6d218aeb40c2ebd8af2564be8201eeff1 (diff) |
Use -n instead of ! -z
Diffstat (limited to 'include/tests_insecure_services')
-rw-r--r-- | include/tests_insecure_services | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/include/tests_insecure_services b/include/tests_insecure_services index df616e56..3ba08570 100644 --- a/include/tests_insecure_services +++ b/include/tests_insecure_services @@ -222,7 +222,7 @@ if [ -f "${FILE}" ]; then LogText "Test: checking status in xinetd configuration file (${FILE})" FIND=$(${GREPBINARY} "disable\s*=\s*no" ${FILE}) - if [ ! -z "${FIND}" ]; then + if [ -n "${FIND}" ]; then LogText "Result: found insecure service enabled: ${SERVICE}" XINETD_INSECURE_SERVICE_FOUND=1 ReportSuggestion "${TEST_NO}" "Disable or remove any insecure services in the xinetd configuration" "${SERVICE}" "text:See log file for more details" @@ -492,7 +492,7 @@ # ################################################################################# # - if [ ! -z "${LAUNCHCTL_BINARY}" ]; then PREQS_MET="YES"; SKIPREASON=""; else PREQS_MET="NO"; SKIPREASON="No launchctl binary on this system"; fi + if [ -n "${LAUNCHCTL_BINARY}" ]; then PREQS_MET="YES"; SKIPREASON=""; else PREQS_MET="NO"; SKIPREASON="No launchctl binary on this system"; fi Register --test-no INSE-8050 --os "macOS" --preqs-met ${PREQS_MET} --skip-reason "${SKIPREASON}" --weight M --network NO --category security --description "Check for insecure services on macOS" if [ ${SKIPTEST} -eq 0 ]; then TEST_SERVICES="com.apple.fingerd" |