diff options
author | Michael Boelen <michael.boelen@cisofy.com> | 2019-12-18 14:17:46 +0300 |
---|---|---|
committer | Michael Boelen <michael.boelen@cisofy.com> | 2019-12-18 14:17:46 +0300 |
commit | 09f29a5e64d4eb0fbbec2a0a503fa173a973b898 (patch) | |
tree | 18631dc8b10382e2eddb633d7fbcd03f3c87dbd1 /include/tests_nameservices | |
parent | 94ba30e765d02ce638e01d731882f8b7086506e2 (diff) |
Code style improvement: quote argument
Diffstat (limited to 'include/tests_nameservices')
-rw-r--r-- | include/tests_nameservices | 18 |
1 files changed, 9 insertions, 9 deletions
diff --git a/include/tests_nameservices b/include/tests_nameservices index aa60885b..59983cac 100644 --- a/include/tests_nameservices +++ b/include/tests_nameservices @@ -84,7 +84,7 @@ if [ ${COUNT} -gt 6 ]; then LogText "Result: Found ${COUNT} search domains" Display --indent 2 --text "- Checking search domains" --result "${STATUS_WARNING}" --color YELLOW - ReportWarning ${TEST_NO} "Found more than 6 search domains, which is usually more than the maximum allowed number in most resolvers" + ReportWarning "${TEST_NO}" "Found more than 6 search domains, which is usually more than the maximum allowed number in most resolvers" else LogText "Result: Found ${COUNT} search domains" Display --indent 2 --text "- Checking search domains" --result "${STATUS_FOUND}" --color GREEN @@ -95,7 +95,7 @@ if [ ! "${FIND}" = "0" -a ! "${FIND}" = "1" ]; then LogText "Result: found ${FIND} line(s) with a search statement (expecting less than 2 lines)" Display --indent 4 --text "- Checking search domains lines" --result "CONFIG ERROR" --color YELLOW - ReportWarning ${TEST_NO} "Found more than 1 search lines in /etc/resolv.conf, which is probably a misconfiguration" + ReportWarning "${TEST_NO}" "Found more than 1 search lines in /etc/resolv.conf, which is probably a misconfiguration" else LogText "Result: found ${FIND} line(s) with a search statement (expecting less than 2 lines)" fi @@ -204,7 +204,7 @@ Display --indent 6 --text "Domain name: ${DOMAINNAME}" else Display --indent 2 --text "- Searching DNS domain name" --result "${STATUS_UNKNOWN}" --color YELLOW - ReportSuggestion ${TEST_NO} "Check DNS configuration for the dns domain name" + ReportSuggestion "${TEST_NO}" "Check DNS configuration for the dns domain name" fi fi # @@ -324,7 +324,7 @@ else LogText "Result: possible errors found in ${BIND_CONFIG_LOCATION}" Display --indent 4 --text "- Checking BIND configuration consistency" --result "${STATUS_WARNING}" --color RED - ReportWarning ${TEST_NO} "Errors discovered in BIND configuration file" + ReportWarning "${TEST_NO}" "Errors discovered in BIND configuration file" fi else LogText "Result: named-checkconf not found, skipping test" @@ -347,8 +347,8 @@ else LogText "Result: possible BIND version available in version banner" Display --indent 4 --text "- Checking BIND version in banner" --result "${STATUS_WARNING}" --color RED - ReportWarning ${TEST_NO} "Found BIND version in banner" - ReportSuggestion ${TEST_NO} "The version in BIND can be masked by defining 'version none' in the configuration file" + ReportWarning "${TEST_NO}" "Found BIND version in banner" + ReportSuggestion "${TEST_NO}" "The version in BIND can be masked by defining 'version none' in the configuration file" AddHP 0 2 fi fi @@ -599,7 +599,7 @@ else LogText "Result: No entry found for ${HOSTNAME} in ${ROOTDIR}etc/hosts" Display --indent 4 --text "- Presence of configured hostname in /etc/hosts" --result "${STATUS_NOT_FOUND}" --color YELLOW - ReportSuggestion ${TEST_NO} "Add the IP name and FQDN to /etc/hosts for proper name resolving" + ReportSuggestion "${TEST_NO}" "Add the IP name and FQDN to /etc/hosts for proper name resolving" LogText "Risk: No entry for the server name [hostname] in /etc/hosts may cause unexpected performance problems for local connections" fi else @@ -621,7 +621,7 @@ LogText "Output: ${DATA}" Display --indent 4 --text "- Hostname mapped to localhost" --result "${STATUS_FOUND}" --color YELLOW LogText "Information: Linking the hostname to the localhost entry may break some resolving. Split resolving so that localhost resolves back to 127.0.0.1 (and ::1) and the hostname of the machine to the real IP address on the network interface." - ReportSuggestion ${TEST_NO} "Split resolving between localhost and the hostname of the system" + ReportSuggestion "${TEST_NO}" "Split resolving between localhost and the hostname of the system" else LogText "Result: this server hostname is not mapped to a local address" Display --indent 4 --text "- Hostname mapped to localhost" --result "${STATUS_NOT_FOUND}" --color GREEN @@ -654,7 +654,7 @@ LogText "Result: this server hostname is not mapped to a local address" Display --indent 4 --text "- Localhost mapping to IP address" --result "${STATUS_SUGGESTION}" --color YELLOW LogText "Information: Ensure that localhost resolves back to 127.0.0.1 (and/or ::1)." - ReportSuggestion ${TEST_NO} "Split resolving between localhost and the hostname of the system" "/etc/hosts" "text:Check your localhost line" + ReportSuggestion "${TEST_NO}" "Split resolving between localhost and the hostname of the system" "/etc/hosts" "text:Check your localhost line" fi fi # |