diff options
author | DrZlo13 <who.just.the.doctor@gmail.com> | 2020-10-15 21:23:18 +0300 |
---|---|---|
committer | GitHub <noreply@github.com> | 2020-10-15 21:23:18 +0300 |
commit | 05ef19b07a5f7aa383676249a9fd1b3b99892d11 (patch) | |
tree | 4c051af6197fa86971fade6fd77f1a2ea327076e /applications/tests | |
parent | 59740349fa3318017eadacf50bd0b109792e3c0b (diff) |
Pubsub core api feature (#174)
* fixed inline functions for modern C standart
* pubsub api, base version
* basic test for pubsub
* update applications.mk, add test file
* more test for pubsub
* remove unimplemented files, cleanup header file
* remove legacy tests, check unsubscribe not call cb
* implement deleting mutex, fail test
* release mutex before deleting
Co-authored-by: aanper <mail@s3f.ru>
Diffstat (limited to 'applications/tests')
-rw-r--r-- | applications/tests/furi_pubsub_test.c | 56 | ||||
-rw-r--r-- | applications/tests/furi_record_test.c | 194 | ||||
-rw-r--r-- | applications/tests/minunit_test.c | 16 |
3 files changed, 63 insertions, 203 deletions
diff --git a/applications/tests/furi_pubsub_test.c b/applications/tests/furi_pubsub_test.c new file mode 100644 index 00000000..4447f542 --- /dev/null +++ b/applications/tests/furi_pubsub_test.c @@ -0,0 +1,56 @@ +#include <stdio.h> +#include <string.h> +#include "flipper_v2.h" +#include "log.h" + +#include "minunit.h" + +const uint32_t context_value = 0xdeadbeef; +const uint32_t notify_value_0 = 0x12345678; +const uint32_t notify_value_1 = 0x11223344; + +uint32_t pubsub_value = 0; +uint32_t pubsub_context_value = 0; + +void test_pubsub_handler(void* arg, void* ctx) { + pubsub_value = *(uint32_t*)arg; + pubsub_context_value = *(uint32_t*)ctx; +} + +void test_furi_pubsub() { + bool result; + PubSub test_pubsub; + PubSubItem* test_pubsub_item; + + // init pubsub case + result = init_pubsub(&test_pubsub); + mu_assert(result, "init pubsub failed"); + + // subscribe pubsub case + test_pubsub_item = subscribe_pubsub(&test_pubsub, test_pubsub_handler, (void*)&context_value); + mu_assert_pointers_not_eq(test_pubsub_item, NULL); + + /// notify pubsub case + result = notify_pubsub(&test_pubsub, (void*)¬ify_value_0); + mu_assert(result, "notify pubsub failed"); + mu_assert_int_eq(pubsub_value, notify_value_0); + mu_assert_int_eq(pubsub_context_value, context_value); + + // unsubscribe pubsub case + result = unsubscribe_pubsub(test_pubsub_item); + mu_assert(result, "unsubscribe pubsub failed"); + + result = unsubscribe_pubsub(test_pubsub_item); + mu_assert(!result, "unsubscribe pubsub not failed"); + + /// notify unsubscribed pubsub case + result = notify_pubsub(&test_pubsub, (void*)¬ify_value_1); + mu_assert(result, "notify pubsub failed"); + mu_assert_int_not_eq(pubsub_value, notify_value_1); + + // delete pubsub case + result = delete_pubsub(&test_pubsub); + mu_assert(result, "unsubscribe pubsub failed"); + + // TODO test case that the pubsub_delete will remove pubsub from heap +}
\ No newline at end of file diff --git a/applications/tests/furi_record_test.c b/applications/tests/furi_record_test.c index f3fdcf1c..4481602c 100644 --- a/applications/tests/furi_record_test.c +++ b/applications/tests/furi_record_test.c @@ -14,197 +14,3 @@ void test_furi_create_open() { void* record = furi_open("test/holding"); mu_assert_pointers_eq(record, &test_data); } - -/* -TEST: non-existent data -1. Try to open non-existent record -2. Check for NULL handler -3. Try to write/read, get error - -TODO: implement this test -*/ -bool test_furi_nonexistent_data() { - return true; -} - -/* -TEST: mute algorithm -1. Create "parent" application: - 1. Create pipe record - 2. Open watch handler: no_mute=false, solo=false, subscribe to data. - -2. Open handler A: no_mute=false, solo=false, NULL subscriber. Subscribe to state. -Try to write data to A and check subscriber. - -3. Open handler B: no_mute=true, solo=true, NULL subscriber. -Check A state cb get FlipperRecordStateMute. -Try to write data to A and check that subscriber get no data. (muted) -Try to write data to B and check that subscriber get data. - -TODO: test 3 not pass beacuse state callback not implemented - -4. Open hadler C: no_mute=false, solo=true, NULL subscriber. -Try to write data to A and check that subscriber get no data. (muted) -Try to write data to B and check that subscriber get data. (not muted because open with no_mute) -Try to write data to C and check that subscriber get data. - -5. Open handler D: no_mute=false, solo=false, NULL subscriber. -Try to write data to A and check that subscriber get no data. (muted) -Try to write data to B and check that subscriber get data. (not muted because open with no_mute) -Try to write data to C and check that subscriber get data. (not muted because D open without solo) -Try to write data to D and check that subscriber get data. - -6. Close C, close B. -Check A state cb get FlipperRecordStateUnmute -Try to write data to A and check that subscriber get data. (unmuted) -Try to write data to D and check that subscriber get data. - -TODO: test 6 not pass beacuse cleanup is not implemented -TODO: test 6 not pass because mute algorithm is unfinished. - -7. Exit "parent application" -Check A state cb get FlipperRecordStateDeleted - -TODO: test 7 not pass beacuse cleanup is not implemented -*/ - -static uint8_t mute_last_value = 0; -static FlipperRecordState mute_last_state = 255; - -void mute_record_cb(const void* value, size_t size, void* ctx) { - // hold value to static var - mute_last_value = *((uint8_t*)value); -} - -void mute_record_state_cb(FlipperRecordState state, void* ctx) { - mute_last_state = state; -} - -void furi_mute_parent_app(void* p) { - // 1. Create pipe record - if(!furi_create_deprecated("test/mute", NULL, 0)) { - printf("cannot create record\n"); - furiac_exit(NULL); - } - - // 2. Open watch handler: solo=false, no_mute=false, subscribe to data - FuriRecordSubscriber* watch_handler = - furi_open_deprecated("test/mute", false, false, mute_record_cb, NULL, NULL); - if(watch_handler == NULL) { - printf("cannot open watch handler\n"); - furiac_exit(NULL); - } - - while(1) { - // TODO we don't have thread sleep - delay(100000); - } -} - -bool test_furi_mute_algorithm() { - // 1. Create "parent" application: - FuriApp* parent_app = furiac_start(furi_mute_parent_app, "parent app", NULL); - - delay(2); // wait creating record - - // 2. Open handler A: solo=false, no_mute=false, NULL subscriber. Subscribe to state. - FuriRecordSubscriber* handler_a = - furi_open_deprecated("test/mute", false, false, NULL, mute_record_state_cb, NULL); - if(handler_a == NULL) { - printf("cannot open handler A\n"); - return false; - } - - uint8_t test_counter = 1; - - // Try to write data to A and check subscriber - if(!furi_write(handler_a, &test_counter, sizeof(uint8_t))) { - printf("write to A failed\n"); - return false; - } - - if(mute_last_value != test_counter) { - printf("value A mismatch: %d vs %d\n", mute_last_value, test_counter); - return false; - } - - // 3. Open handler B: solo=true, no_mute=true, NULL subscriber. - FuriRecordSubscriber* handler_b = - furi_open_deprecated("test/mute", true, true, NULL, NULL, NULL); - if(handler_b == NULL) { - printf("cannot open handler B\n"); - return false; - } - - // Check A state cb get FlipperRecordStateMute. - if(mute_last_state != FlipperRecordStateMute) { - printf("A state is not FlipperRecordStateMute: %d\n", mute_last_state); - return false; - } - - test_counter = 2; - - // Try to write data to A and check that subscriber get no data. (muted) - if(furi_write(handler_a, &test_counter, sizeof(uint8_t))) { - printf("A not muted\n"); - return false; - } - - if(mute_last_value == test_counter) { - printf("value A must be muted\n"); - return false; - } - - test_counter = 3; - - // Try to write data to B and check that subscriber get data. - if(!furi_write(handler_b, &test_counter, sizeof(uint8_t))) { - printf("write to B failed\n"); - return false; - } - - if(mute_last_value != test_counter) { - printf("value B mismatch: %d vs %d\n", mute_last_value, test_counter); - return false; - } - - // 4. Open hadler C: solo=true, no_mute=false, NULL subscriber. - FuriRecordSubscriber* handler_c = - furi_open_deprecated("test/mute", true, false, NULL, NULL, NULL); - if(handler_c == NULL) { - printf("cannot open handler C\n"); - return false; - } - - // TODO: Try to write data to A and check that subscriber get no data. (muted) - // TODO: Try to write data to B and check that subscriber get data. (not muted because open with no_mute) - // TODO: Try to write data to C and check that subscriber get data. - - // 5. Open handler D: solo=false, no_mute=false, NULL subscriber. - FuriRecordSubscriber* handler_d = - furi_open_deprecated("test/mute", false, false, NULL, NULL, NULL); - if(handler_d == NULL) { - printf("cannot open handler D\n"); - return false; - } - - // TODO: Try to write data to A and check that subscriber get no data. (muted) - // TODO: Try to write data to B and check that subscriber get data. (not muted because open with no_mute) - // TODO: Try to write data to C and check that subscriber get data. (not muted because D open without solo) - // TODO: Try to write data to D and check that subscriber get data. - - // 6. Close C, close B. - // TODO: Check A state cb get FlipperRecordStateUnmute - // TODO: Try to write data to A and check that subscriber get data. (unmuted) - // TODO: Try to write data to D and check that subscriber get data. - - // 7. Exit "parent application" - if(!furiac_kill(parent_app)) { - printf("kill parent_app fail\n"); - return false; - } - - // TODO: Check A state cb get FlipperRecordStateDeleted - - return true; -}
\ No newline at end of file diff --git a/applications/tests/minunit_test.c b/applications/tests/minunit_test.c index 631c1892..472dfa7d 100644 --- a/applications/tests/minunit_test.c +++ b/applications/tests/minunit_test.c @@ -7,13 +7,12 @@ bool test_furi_ac_create_kill(); bool test_furi_ac_switch_exit(); -bool test_furi_nonexistent_data(); -bool test_furi_mute_algorithm(); - // v2 tests void test_furi_create_open(); void test_furi_valuemutex(); void test_furi_concurrent_access(); +void test_furi_pubsub(); + void test_furi_memmgr(); static int foo = 0; @@ -38,10 +37,6 @@ MU_TEST(mu_test_furi_ac_switch_exit) { mu_assert_int_eq(test_furi_ac_switch_exit(), true); } -MU_TEST(mu_test_furi_nonexistent_data) { - mu_assert_int_eq(test_furi_nonexistent_data(), true); -} - // v2 tests MU_TEST(mu_test_furi_create_open) { test_furi_create_open(); @@ -55,6 +50,10 @@ MU_TEST(mu_test_furi_concurrent_access) { test_furi_concurrent_access(); } +MU_TEST(mu_test_furi_pubsub) { + test_furi_pubsub(); +} + MU_TEST(mu_test_furi_memmgr) { // this test is not accurate, but gives a basic understanding // that memory management is working fine @@ -68,12 +67,11 @@ MU_TEST_SUITE(test_suite) { MU_RUN_TEST(mu_test_furi_ac_create_kill); MU_RUN_TEST(mu_test_furi_ac_switch_exit); - MU_RUN_TEST(mu_test_furi_nonexistent_data); - // v2 tests MU_RUN_TEST(mu_test_furi_create_open); MU_RUN_TEST(mu_test_furi_valuemutex); MU_RUN_TEST(mu_test_furi_concurrent_access); + MU_RUN_TEST(mu_test_furi_pubsub); MU_RUN_TEST(mu_test_furi_memmgr); } |