diff options
| author | Zhao Zhili <zhilizhao@tencent.com> | 2022-09-17 07:30:01 +0300 |
|---|---|---|
| committer | Zhao Zhili <zhilizhao@tencent.com> | 2022-09-23 14:58:08 +0300 |
| commit | 686096739b129c7e3ea26be29c875e0887e58c49 (patch) | |
| tree | 32cf4abc521d615e954eb7fe001692419643bd43 /fftools | |
| parent | 668f43af2004af92e2df4f8633e7fc3602975073 (diff) | |
fftools/ffmpeg_filter: configure min_hard_comp unconditionally
There are two issues here. Firstly, the floating-point comparison
is always true. Seconly, the code depends on the default value of
min_hard_comp implicitly, which can be dangerous.
Partially fixes ticket 9859.
Reviewed-by: Anton Khirnov <anton@khirnov.net>
Signed-off-by: Zhao Zhili <zhilizhao@tencent.com>
Diffstat (limited to 'fftools')
| -rw-r--r-- | fftools/ffmpeg_filter.c | 3 |
1 files changed, 1 insertions, 2 deletions
diff --git a/fftools/ffmpeg_filter.c b/fftools/ffmpeg_filter.c index 7a5308425d..17928cea2c 100644 --- a/fftools/ffmpeg_filter.c +++ b/fftools/ffmpeg_filter.c @@ -896,8 +896,7 @@ static int configure_input_audio_filter(FilterGraph *fg, InputFilter *ifilter, char args[256] = {0}; av_strlcatf(args, sizeof(args), "async=%d", audio_sync_method); - if (audio_drift_threshold != 0.1) - av_strlcatf(args, sizeof(args), ":min_hard_comp=%f", audio_drift_threshold); + av_strlcatf(args, sizeof(args), ":min_hard_comp=%f", audio_drift_threshold); if (!fg->reconfiguration) av_strlcatf(args, sizeof(args), ":first_pts=0"); AUTO_INSERT_FILTER_INPUT("-async", "aresample", args); |