diff options
| author | shine <4771718+shinenelson@users.noreply.github.com> | 2021-06-25 21:26:38 +0300 |
|---|---|---|
| committer | shine <4771718+shinenelson@users.noreply.github.com> | 2021-06-25 21:26:38 +0300 |
| commit | de0289499c4efb1fc5e83e3eca87f6e216faf354 (patch) | |
| tree | 1d5650f8142f27c45e8558ccdf89d50f794e7ed1 | |
| parent | 964d92e199856be623ccf4c31ffd27603ecb2944 (diff) | |
add note about linking pull requests to issues
if pull request creators are considerate enough to follow this, it could
save the maintainers a lot of time in triaging issues to be closed after
they have already been merged into the icon set
| -rw-r--r-- | CONTRIBUTING.md | 7 |
1 files changed, 7 insertions, 0 deletions
diff --git a/CONTRIBUTING.md b/CONTRIBUTING.md index 6c184038a..ea41aa538 100644 --- a/CONTRIBUTING.md +++ b/CONTRIBUTING.md @@ -28,6 +28,13 @@ Adding a new icon is a couple steps process that will require your attention and 5. Once you are satisfied with your design and the preview of it. Add the icon name, unicode point and icon information at the bottom of the `src/icons/icons.yml` file. Look at other entries to see how it's done and to give it a proper classification. 6. Once all this is done, commit your changes and make a pull request. +Note : Please be considerate about maintainers' time and please +[link your pull requests] to the icon request issue if it exists. You +could use it within your commit message as well. This saves the +maintainers extra effort in having to keep track of and close completed +issues. + +[link your pull requests]: https://docs.github.com/en/issues/tracking-your-work-with-issues/linking-a-pull-request-to-an-issue ## Suggesting icon keyword addition/removal |