diff options
| author | Tim-Philipp Müller <tim@centricular.com> | 2021-03-03 04:08:25 +0300 |
|---|---|---|
| committer | Tim-Philipp Müller <tim@centricular.com> | 2021-03-15 15:56:18 +0300 |
| commit | 8a88e5c1db05ebadfd4569955f6f47c23cdca3c4 (patch) | |
| tree | 46b5166bd5fe50e9b7245a41200140644c2bafb1 | |
| parent | 42b4ed92881ea1c08cec1259fa09d187201cea31 (diff) | |
tag: id3v2: fix frame size check and potential invalid reads
Check the right variable when checking if there's
enough data left to read the frame size.
Closes https://gitlab.freedesktop.org/gstreamer/gst-plugins-base/-/issues/876
Part-of: <https://gitlab.freedesktop.org/gstreamer/gst-plugins-base/-/merge_requests/1066>
| -rw-r--r-- | gst-libs/gst/tag/id3v2frames.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/gst-libs/gst/tag/id3v2frames.c b/gst-libs/gst/tag/id3v2frames.c index 8e9f78254..f39659bf7 100644 --- a/gst-libs/gst/tag/id3v2frames.c +++ b/gst-libs/gst/tag/id3v2frames.c @@ -109,7 +109,7 @@ id3v2_parse_frame (ID3TagsWorking * work) if (work->frame_flags & (ID3V2_FRAME_FORMAT_COMPRESSION | ID3V2_FRAME_FORMAT_DATA_LENGTH_INDICATOR)) { - if (work->hdr.frame_data_size <= 4) + if (frame_data_size <= 4) return FALSE; if (ID3V2_VER_MAJOR (work->hdr.version) == 3) { work->parse_size = GST_READ_UINT32_BE (frame_data); |