diff options
| author | Nicolas Dufresne <nicolas.dufresne@collabora.com> | 2020-09-23 20:26:51 +0300 |
|---|---|---|
| committer | Nicolas Dufresne <nicolas.dufresne@collabora.com> | 2020-09-23 22:48:24 +0300 |
| commit | ecc110ca8bd0ab30ad01c3de849383fee41e1b82 (patch) | |
| tree | 76a2a0c419d654a43ea8cfa3f5d31b982b39b223 /gst | |
| parent | ea61714c70502240d6564523c7f0f184e4aea3fb (diff) | |
rtpbin: Cleanup dead code
The rtpjitterbuffer is now part of the session elements, we no longer need
to do the ref_sink dance when signalling it. It is already owned by the bin
when signalled. Also, the code that handles generic session elements already
handle the ref_sink() calls since:
03dc22951bacb6fdc3868c8f801e6a52c33a745f
Part-of: <https://gitlab.freedesktop.org/gstreamer/gst-plugins-good/-/merge_requests/735>
Diffstat (limited to 'gst')
| -rw-r--r-- | gst/rtpmanager/gstrtpbin.c | 7 |
1 files changed, 0 insertions, 7 deletions
diff --git a/gst/rtpmanager/gstrtpbin.c b/gst/rtpmanager/gstrtpbin.c index 5e88e47a5..bdb16a0a3 100644 --- a/gst/rtpmanager/gstrtpbin.c +++ b/gst/rtpmanager/gstrtpbin.c @@ -1790,19 +1790,12 @@ create_stream (GstRtpBinSession * session, guint32 ssrc) g_object_set (buffer, "max-ts-offset-adjustment", rtpbin->max_ts_offset_adjustment, NULL); - /* need to sink the jitterbufer or otherwise signal handlers from bindings will - * take ownership of it and we don't own it anymore */ - gst_object_ref_sink (buffer); g_signal_emit (rtpbin, gst_rtp_bin_signals[SIGNAL_NEW_JITTERBUFFER], 0, buffer, session->id, ssrc); if (!rtpbin->ignore_pt) gst_bin_add (GST_BIN_CAST (rtpbin), demux); - /* unref the jitterbuffer again, the bin has a reference now and - * we don't need it anymore */ - gst_object_unref (buffer); - /* link stuff */ if (demux) gst_element_link_pads_full (buffer, "src", demux, "sink", |